[ http://issues.apache.org/jira/browse/COLLECTIONS-215?page=all ]
Hendrik Maryns updated COLLECTIONS-215: --------------------------------------- Attachment: DefaultedMap.diff A patch including the alterations I mean. -> changed names of parameters -> changed type of value -> changed implementation of get(Object) -> made Javadocs more consistent > Javadoc in DefaultedMap very inconsistent > ----------------------------------------- > > Key: COLLECTIONS-215 > URL: http://issues.apache.org/jira/browse/COLLECTIONS-215 > Project: Commons Collections > Type: Improvement > Versions: 3.2 > Reporter: Hendrik Maryns > Attachments: DefaultedMap.diff > > The javadocs in DefaultedMap is very inconsistent. It speaks > of factory > when a transformer is meant, it speaks of transformer when value is > meant and that sort of stuff. > > Besides, it would be much cleaner to declare 'value' of type > Transformer, and create a transformer every time, except when one is > passed (the instanceof checks are wrong anyway), (I'd rename it to > transformer, too). > > Even nicer would be to split up the constructor(s) into one > that takes a > value, and one that takes a Transformer, no instanceof checks needed, > much cleaner code, generification is almost trivial :-) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]