[lang] customizing the PMD report [WAS Re: added empty statement to empty catch blocks [WAS: svn commit: r202043 - in /jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang: NumberUtils.java SerializationUtils.java enum/Enum.java enums/E

As I mentioned peviously, I added an empty statement to catch blocks because an empty catch block is not a good thing and an empty statement is a way to at least show there was a modicum of thought to having the catch do nothing. The empty statement works for some style checkers like Checkstyle

[lang] customizing the PMD report [WAS: Re: added empty statement to empty catch blocks [WAS: svn commit: r202043 - in /jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang: NumberUtils.java SerializationUtils.java enum/Enum.java enums/

As I mentioned peviously, I added an empty statement to catch blocks because an empty catch block is not a good thing and an empty statement is a way to at least show there was a modicum of thought to having the catch do nothing. The empty statement works for some style checkers like Checkstyle

RE: [lang] customizing the PMD report [WAS Re: added empty statement to empty catch blocks [WAS: svn commit: r202043 - in /jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang: NumberUtils.java SerializationUtils.java enum/Enum.java enums/E

I am +1 on removing the ; and making the style checker behave with reason. IMHO, an empty catch block is OK IFF it is { // documented in-line }. I have my Eclipse settings set to warn me of this but I know not everyone uses Eclipse. Gary -Original Message- From: Steven Caswell