Re: [math] RealMatrixImpl changes was: RE: cvs commit: jakarta-commons/math/src/test/org/apache/commons/math/linear RealMatrixImplTest.java

2004-10-11 Thread Phil Steitz
Mark R. Diggory wrote: Yes, your right, We should rather use just getEntry(x,y) and getRowDimension/getColumnDimension shouldn't we. Yes, below looks good and definitely an improvement over the current code. If there are cases where access to the full matrix of the external operand is really

Re: [math] RealMatrixImpl changes was: RE: cvs commit: jakarta-commons/math/src/test/org/apache/commons/math/linear RealMatrixImplTest.java

2004-10-11 Thread Mark R. Diggory
Yes, your right, We should rather use just getEntry(x,y) and getRowDimension/getColumnDimension shouldn't we. Phil Steitz wrote: I understand what you are trying to do here and support the basic idea, but I don't know if this will work in general. What happens when we want to add a sparse matrix

RE: [math] RealMatrixImpl changes was: RE: cvs commit: jakarta-commons/math/src/test/org/apache/commons/math/linear RealMatrixImplTest.java

2004-10-11 Thread Phil Steitz
Mark R. Diggory [mailto:[EMAIL PROTECTED] Sent: Mon 10/11/2004 12:10 PM To: Jakarta Commons Developers List Cc: Subject: Re: [math] RealMatrixImpl changes was: RE: cvs commit: jakarta-commons/math/src/test/org/apache/commons/math/linear RealMatr

Re: [math] RealMatrixImpl changes was: RE: cvs commit: jakarta-commons/math/src/test/org/apache/commons/math/linear RealMatrixImplTest.java

2004-10-11 Thread Mark R. Diggory
Phil, Heres a patch that shows the changes which would solve this copying issue in the current RealMatrixImpl. Index: RealMatrixImpl.java === RCS file: /home/cvs/jakarta-commons/math/src/java/org/apache/commons/math/linear/RealMatri

Re: [math] RealMatrixImpl changes was: RE: cvs commit: jakarta-commons/math/src/test/org/apache/commons/math/linear RealMatrixImplTest.java

2004-10-11 Thread Mark R. Diggory
Phil Steitz wrote: Mark, I now see (more fully) what you mean about the extra copy operations and agree that there is a little more to do than what I responded below. Using getElement and getDataRef for the current instance should suffice, however, in most cases. I need to understand better wh

[math] RealMatrixImpl changes was: RE: cvs commit: jakarta-commons/math/src/test/org/apache/commons/math/linear RealMatrixImplTest.java

2004-10-11 Thread Phil Steitz
Mark, I now see (more fully) what you mean about the extra copy operations and agree that there is a little more to do than what I responded below. Using getElement and getDataRef for the current instance should suffice, however, in most cases. I need to understand better what you are propos