DO NOT REPLY [Bug 31918] New: - javadoc FTPClient inconsistent

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=31918>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=31918

javadoc FTPClient inconsistent

           Summary: javadoc FTPClient inconsistent
           Product: Commons
           Version: 1.2 Final
          Platform: PC
        OS/Version: All
            Status: NEW
          Severity: Minor
          Priority: Other
         Component: Net
        AssignedTo: [EMAIL PROTECTED]
        ReportedBy: [EMAIL PROTECTED]


The javadoc of ftpclient says :
you must first connect to the server with connect before doing anything, and
finally disconnect after you're completely finished interacting with the server

but the given source code doesn't disconnect if ftp.connect("ftp.foobar.com");
succeed

change proposal:
replace in FTPClient javaDoc

     if(!FTPReply.isPositiveCompletion(reply)) {
        ftp.disconnect();
        System.err.println("FTP server refused connection.");
        System.exit(1);
      }
    } catch(IOException e) {
      if(ftp.isConnected()) 

by

     if(!FTPReply.isPositiveCompletion(reply)) {
        ftp.disconnect();
        System.err.println("FTP server refused connection.");
        System.exit(1);
      }
     ftp.disconnect();
    } catch(IOException e) {
      if(ftp.isConnected())

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]