Re: Isn't Rule really an Action?

2002-05-15 Thread Ceki Gülcü
Hi Robert, I am not a huge fan of name changes, quite the contrary, but this particular change would be beneficial to new and old users alike. Naming Rule as Action would make the documentation as well as the code clearer. Just my unsolicited 2 cents. At 18:09 14.05.2002 +0100, robert burrell d

Re: Isn't Rule really an Action?

2002-05-14 Thread robert burrell donkin
hi ceki digester has grown rather than been designed and poor naming is one of the consequences. the concepts behind them are very clear (once you understand them) but as digester has grown, the word 'rule' has probably become rather over-used. 'Rules' implementations are really 'Rule' patter

Isn't Rule really an Action?

2002-05-14 Thread Ceki Gülcü
Am I the only one that finds the disctinction between Rule, Rules and RuleSet confusing? Isn't a Rule really an Action? Wouldn't it be better to name Rule as Action such that a Rule becomes the association of a pattern and an Action? One would then write Digester.addRule(String pattern, Action