Re: [collections] Minor improvements to UnmodifiableMap: local vars made final, only one return statement in the mapIterator.

2006-07-30 Thread Stephen Colebourne
What do you see as the benefits of this? The code works fine currently, and this doesn't change that one way or the other. Stephen Robert Ribnitz wrote: Hello, I had a look at UnmodifiableMap. -in the mapIterator() the return statement can be taken out; we also need to define the it outside

Minor improvements to UnmodifiableMap: local vars made final, only one return statement in the mapIterator.

2006-07-29 Thread Robert Ribnitz
Hello, I had a look at UnmodifiableMap. -in the mapIterator() the return statement can be taken out; we also need to define the it outside the if block then. Also made final. -entrySet()/keySet()/values(): the local variable can be made final I have attached an unidiff (diff -u..) against a 3