Re: cvs commit: jakarta-commons/validator/src/share/org/apache/commons/validator Field.java Msg.java

2004-11-11 Thread David Graham
: Thursday, November 11, 2004 2:37 PM > Subject: Re: cvs commit: > jakarta-commons/validator/src/share/org/apache/commons/validator > Field.java > Msg.java > > > > Can we change getMessageObject() to getMessage() ? Most everything in > > Java is an object so it's

cvs commit: jakarta-commons/validator/src/share/org/apache/commons/validator Field.java Msg.java

2004-11-11 Thread niallp
niallp 2004/11/11 07:32:49 Modified:validator/src/share/org/apache/commons/validator Field.java Msg.java Log: Re-name getMsgObject() and getMsgs() methods Revision ChangesPath 1.35 +8 -6 jakarta-commons/validator/src/share/org/apache/co

cvs commit: jakarta-commons/validator/src/share/org/apache/commons/validator Field.java Msg.java

2004-11-11 Thread niallp
niallp 2004/11/11 07:32:03 Modified:validator/src/share/org/apache/commons/validator Tag: VALIDATOR_1_1_2_BRANCH Field.java Msg.java Log: Re-name getMsgObject() and getMsgs() methods Revision ChangesPath No revision No

Re: cvs commit: jakarta-commons/validator/src/share/org/apache/commons/validator Field.java Msg.java

2004-11-11 Thread Niall Pemberton
OK I'll do that. Niall - Original Message - From: "David Graham" <[EMAIL PROTECTED]> To: <[EMAIL PROTECTED]>; <[EMAIL PROTECTED]> Sent: Thursday, November 11, 2004 2:37 PM Subject: Re: cvs commit: jakarta-commons/validator/src/share/org/apache/comm

Re: cvs commit: jakarta-commons/validator/src/share/org/apache/commons/validator Field.java Msg.java

2004-11-11 Thread David Graham
Can we change getMessageObject() to getMessage() ? Most everything in Java is an object so it's redundant. Also, getMsgs() doesn't read very well; what about getMessages() ? It would be good to add @since javadoc tags so people don't assume this functionality was there from the beginning. David

cvs commit: jakarta-commons/validator/src/share/org/apache/commons/validator Field.java Msg.java

2004-11-11 Thread niallp
niallp 2004/11/11 04:18:25 Modified:validator/src/share/org/apache/commons/validator Field.java Msg.java Log: Bug 29452 Enable Field/Msg to support all DTD attributes, based on patch submitted by Rich Wertz Changed Field to add getMsgObject(key) and get

cvs commit: jakarta-commons/validator/src/share/org/apache/commons/validator Field.java Msg.java

2004-11-11 Thread niallp
niallp 2004/11/11 04:17:32 Modified:validator/src/share/org/apache/commons/validator Tag: VALIDATOR_1_1_2_BRANCH Field.java Msg.java Log: Bug 29452 Enable Field/Msg to support all DTD attributes, based on patch submitted by Rich Wertz Changed Field to a