Re: svn commit: r149313 - in jakarta/commons/sandbox/javaflow/trunk/src: java/org/apache/commons/javaflow/ java/org/apache/commons/javaflow/bytecode/bcel/ test/org/apache/commons/javaflow/ test/org/apache/commons/javaflow/testcode/

2005-02-01 Thread Torsten Curdt
Closing an OutputStream twice is a bug or is it indeed nitpicking? ;) Bummer missed that one :) That nitpicking was not aimed at your submission. ...it was on a new line on the commit message ;) Well, the point is that the file writing code is temporary anyway. I should go away in the near future.

Re: svn commit: r149313 - in jakarta/commons/sandbox/javaflow/trunk/src: java/org/apache/commons/javaflow/ java/org/apache/commons/javaflow/bytecode/bcel/ test/org/apache/commons/javaflow/ test/org/apache/commons/javaflow/testcode/

2005-02-01 Thread WHIRLYCOTT
Torsten Curdt wrote: Well, the point is that the file writing code is temporary anyway. I should go away in the near future. That's why fixing it is not that important. Yes, I was going to ask about that one... can you let me in on your plans for this? I agree that it should go away, but I

svn commit: r149313 - in jakarta/commons/sandbox/javaflow/trunk/src: java/org/apache/commons/javaflow/ java/org/apache/commons/javaflow/bytecode/bcel/ test/org/apache/commons/javaflow/ test/org/apache/commons/javaflow/testcode/

2005-01-31 Thread tcurdt
Author: tcurdt Date: Mon Jan 31 14:53:31 2005 New Revision: 149313 URL: http://svn.apache.org/viewcvs?view=revrev=149313 Log: improved the testcase as suggested by phil http://issues.apache.org/bugzilla/show_bug.cgi?id=33313 some nitpicking Modified:

Re: svn commit: r149313 - in jakarta/commons/sandbox/javaflow/trunk/src: java/org/apache/commons/javaflow/ java/org/apache/commons/javaflow/bytecode/bcel/ test/org/apache/commons/javaflow/ test/org/apache/commons/javaflow/testcode/

2005-01-31 Thread WHIRLYCOTT
Closing an OutputStream twice is a bug or is it indeed nitpicking? ;) I was thinking that it might make sense for me to work on some docs as well... might be a good opportunity for me to dig deeper through things as well as put down in words what I'm seeing and learn a few things from you about