Author: henning Date: Thu Aug 25 03:16:26 2005 New Revision: 240037 URL: http://svn.apache.org/viewcvs?rev=240037&view=rev Log: Found by Findbugs:
WMI: Method org.apache.commons.mail.Email.setHeaders(java.util.Map) makes inefficient use of keySet iterator instead of entrySet iterator Modified: jakarta/commons/proper/email/trunk/src/java/org/apache/commons/mail/Email.java Modified: jakarta/commons/proper/email/trunk/src/java/org/apache/commons/mail/Email.java URL: http://svn.apache.org/viewcvs/jakarta/commons/proper/email/trunk/src/java/org/apache/commons/mail/Email.java?rev=240037&r1=240036&r2=240037&view=diff ============================================================================== --- jakarta/commons/proper/email/trunk/src/java/org/apache/commons/mail/Email.java (original) +++ jakarta/commons/proper/email/trunk/src/java/org/apache/commons/mail/Email.java Thu Aug 25 03:16:26 2005 @@ -652,12 +652,13 @@ */ public void setHeaders(Map map) { - Iterator iterKeyBad = map.keySet().iterator(); + Iterator iterKeyBad = map.entrySet().iterator(); while (iterKeyBad.hasNext()) { - String strName = (String) iterKeyBad.next(); - String strValue = (String) map.get(strName); + Map.Entry entry = (Map.Entry) iterKeyBad.next(); + String strName = (String) entry.getKey(); + String strValue = (String) entry.getValue(); if (!StringUtils.isNotEmpty(strName)) { --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]