Re: svn commit: r491359 - /jakarta/commons/proper/io/trunk/src/java/org/apache/commons/io/EndianUtils.java

2006-12-31 Thread Stephen Colebourne
This was a recent bug fix. Do we have tests to show that removing this cast doesn't cause the bug to reappear? Stephen [EMAIL PROTECTED] wrote: Author: ggregory Date: Sat Dec 30 17:08:34 2006 New Revision: 491359 URL: http://svn.apache.org/viewvc?view=revrev=491359 Log: Remove unnecessary

Re: svn commit: r491359 - /jakarta/commons/proper/io/trunk/src/java/org/apache/commons/io/EndianUtils.java

2006-12-31 Thread Henri Yandell
https://issues.apache.org/jira/browse/IO-101 with a testSymmetryOfLong in EndianUtilsTest. With Gary's change, the fix becomes: -return low + (high 32); +return (high 32) + (0xL low); The test still passes, so I guess things are good. Hen On 12/31/06, Stephen

svn commit: r491359 - /jakarta/commons/proper/io/trunk/src/java/org/apache/commons/io/EndianUtils.java

2006-12-30 Thread ggregory
Author: ggregory Date: Sat Dec 30 17:08:34 2006 New Revision: 491359 URL: http://svn.apache.org/viewvc?view=revrev=491359 Log: Remove unnecessary cast from long to long. Modified: jakarta/commons/proper/io/trunk/src/java/org/apache/commons/io/EndianUtils.java Modified: