Author: jochen Date: Tue Jan 9 13:53:55 2007 New Revision: 494610 URL: http://svn.apache.org/viewvc?view=rev&rev=494610 Log: A descriptive NPE is now thrown, if the FileItemFactory hasn't been set. PR: FILEUPLOAD-123
Modified: jakarta/commons/proper/fileupload/trunk/src/changes/changes.xml jakarta/commons/proper/fileupload/trunk/src/java/org/apache/commons/fileupload/FileUploadBase.java Modified: jakarta/commons/proper/fileupload/trunk/src/changes/changes.xml URL: http://svn.apache.org/viewvc/jakarta/commons/proper/fileupload/trunk/src/changes/changes.xml?view=diff&rev=494610&r1=494609&r2=494610 ============================================================================== --- jakarta/commons/proper/fileupload/trunk/src/changes/changes.xml (original) +++ jakarta/commons/proper/fileupload/trunk/src/changes/changes.xml Tue Jan 9 13:53:55 2007 @@ -88,6 +88,11 @@ Added the FileCleanerCleanup as an example for how to close down the FileCleaner's reaper thread nicely. </action> + + <action dev="jochen" type="fix" issue="FILEUPLOAD-123"> + A descriptive NPE is now thrown, if the FileItemFactory + has not been set. + </action> </release> <release version="1.1.1" date="2006-06-08" description="Bugfix release"> Modified: jakarta/commons/proper/fileupload/trunk/src/java/org/apache/commons/fileupload/FileUploadBase.java URL: http://svn.apache.org/viewvc/jakarta/commons/proper/fileupload/trunk/src/java/org/apache/commons/fileupload/FileUploadBase.java?view=diff&rev=494610&r1=494609&r2=494610 ============================================================================== --- jakarta/commons/proper/fileupload/trunk/src/java/org/apache/commons/fileupload/FileUploadBase.java (original) +++ jakarta/commons/proper/fileupload/trunk/src/java/org/apache/commons/fileupload/FileUploadBase.java Tue Jan 9 13:53:55 2007 @@ -341,6 +341,9 @@ FileItemIterator iter = getItemIterator(ctx); List items = new ArrayList(); FileItemFactory fac = getFileItemFactory(); + if (fac == null) { + throw new NullPointerException("No FileItemFactory has been set."); + } while (iter.hasNext()) { FileItemStream item = iter.next(); FileItem fileItem = fac.createItem(item.getFieldName(), --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]