Re: [PATCH] MultipartPost revisited (take 2) ATTN: Mike Becke

2003-02-12 Thread Michael Becke
Hi Oleg, I hear what you are saying. I think this can be accomplished in a different way though. To ensure that the wire is always handed correctly we just need to be sure that HttpConnection inputStream and outputStream are never accessed directly. Instead they should only be used via

Re: [PATCH] MultipartPost revisited (take 2) ATTN: Mike Becke

2003-02-12 Thread Jeffrey Dever
Haven't had time to review all of this, but I am a bit concerned over any performance issues and buffering. The wirelog is a good thing, but there are other ways of getting a request/response log. I wouldnot like to see it excessively effect performance or resident set size, or add too much

[PATCH] MultipartPost revisited (take 2) ATTN: Mike Becke

2003-02-11 Thread Oleg Kalnichevski
On Tue, 2003-02-11 at 04:19, Jeffrey Dever wrote: I like the refactoring. Only complaint is that the classes are public. Package access would be prefered, but this may not be possible. The new patch addressed concerns raised by Jeff Jandalf. Now all the wire logging is (should be) confined