RE: [PATCH] Fix for bug 16458

2003-02-24 Thread Aurelien Pernoud
Wow sorry I missed the end of this conversation ! If I understand well, the "new" trouble doesn't come from connectionManager, even if it throws the same exception, but from the fact that the connection was lost, for some external reason, after writing the request but before reading the response

Re: [PATCH] Fix for bug 16458

2003-02-21 Thread Michael Becke
Sam, I quite agree. This could very well be what is happening for Aurelien. One question. Why is there no error when writing the request, but only when reading the response? When I let the connection time out I always get a HttpRecoverableException in writeRequest(). This exception is caug

Re: [PATCH] Fix for bug 16458

2003-02-21 Thread Sam Maloney
Hi, This is what I have found, as I have worked in that area now: The exception you speak is caused by fix for 16458. Before, instead of said exception, you would have got 100% CPU * forever. Here is the source of the exception (HttpMethodBase.java): protected void readStatusLine(HttpState st

RE: [PATCH] Fix for bug 16458

2003-02-21 Thread Aurelien Pernoud
Weel, this one seems to be over (for me at least). But I'm sorry Mike, I found out my webapp was not logging httpexception correctly (I catched it and logged it in debug mode and i was only logging errors so...), I still have HttpRecoverable exception about "can't find line starting with HTTP/" w

RE: [PATCH] Fix for bug 16458

2003-02-20 Thread Aurelien Pernoud
Made a test for 45 min, seems to be going fine now. I'll test furthermore tomorrow. Aurelien Pernoud a écrit : > Ok, I'm gonna test it right now and tell you tomorrow morning if > everything went ok with my app. > > Oleg Kalnichevski a écrit : > >> Committed ---

Re: [PATCH] Fix for bug 16458

2003-02-20 Thread Jeffrey Dever
There is that one more bug I have fixed that is important to be included in final (perhaps beta even). I will post it soon. The next bug doesn't have a tracking number that I could find, but it results in the app using HttpClient to wait indefinatly for a connection that will never be release

RE: [PATCH] Fix for bug 16458

2003-02-20 Thread Aurelien Pernoud
Ok, I'm gonna test it right now and tell you tomorrow morning if everything went ok with my app. Oleg Kalnichevski a écrit : > Committed - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTEC

RE: [PATCH] Fix for bug 16458

2003-02-20 Thread Aurelien Pernoud
Thx a lot Sam (and of course oll others from httpclient), I totally agree with all you just said about httpclient. I love encountering bugs and find out there might already be fixed ;) Sam Maloney a écrit : >> Thank you so much for tracking it down. It's really appreciated. > No problem. When w

Re: [PATCH] Fix for bug 16458

2003-02-20 Thread Oleg Kalnichevski
Committed On Thu, 2003-02-20 at 17:32, Jeffrey Dever wrote: > Oleg, this fix will need to go in before we drop alpha3. > > Sam Maloney wrote: > > >On Wednesday 19 February 2003 17:39, Oleg Kalnichevski wrote: > > > > > >>Hi Sam > >> > >>I believe the bug has been fixed by now. I stumbled upon

Re: [PATCH] Fix for bug 16458

2003-02-20 Thread Sam Maloney
> Thank you so much for tracking it down. It's really appreciated. No problem. When writing the adaptor for HttpClient to plug into ApacheSOAP (we use both in our project), I instantly fell in love with the architecture (as I said, I came from HTTPClient, which Jeffery Dever agrees with me is a

Re: [PATCH] Fix for bug 16458

2003-02-20 Thread Jeffrey Dever
Oleg, this fix will need to go in before we drop alpha3. Sam Maloney wrote: On Wednesday 19 February 2003 17:39, Oleg Kalnichevski wrote: Hi Sam I believe the bug has been fixed by now. I stumbled upon it a few days ago pretty much by chance http://www.mail-archive.com/commons-httpclient-de

Re: [PATCH] Fix for bug 16458

2003-02-20 Thread Oleg Kalnichevski
No, it would not. I was wrong in my assumption. I am going to apply Sam's patch and commit it after having run all the test cases Oleg On Thu, 2003-02-20 at 17:18, Oleg Kalnichevski wrote: > Sam > > Thank you so much for tracking it down. It's really appreciated. > > Would not it be a bit c

Re: [PATCH] Fix for bug 16458

2003-02-20 Thread Oleg Kalnichevski
Sam Thank you so much for tracking it down. It's really appreciated. Would not it be a bit cleaner to fix this part, though? What's your opinion on that? while ((statusString != null) && !statusString.startsWith("HTTP/")) { statusString = conn.readLine(); } Cheers Oleg On

Re: [PATCH] Fix for bug 16458

2003-02-20 Thread Sam Maloney
On Wednesday 19 February 2003 17:39, Oleg Kalnichevski wrote: > Hi Sam > > I believe the bug has been fixed by now. I stumbled upon it a few days > ago pretty much by chance > > http://www.mail-archive.com/commons-httpclient-dev%40jakarta.apache.org/msg >00536.html > This fix does not fix the same

Re: [PATCH] Fix for bug 16458

2003-02-19 Thread Jeffrey Dever
In a very large project I am a senior on, I use to be using HTTPClient v0.3-3 (www.innovation.ch/java/HTTPClient/). b) After looking at the code to try to fix the problem, not only did I give up trying to fix the problem, but I also gave up on the product :) Yes, I went through exactly the

Re: [PATCH] Fix for bug 16458

2003-02-19 Thread Oleg Kalnichevski
Hi Sam I believe the bug has been fixed by now. I stumbled upon it a few days ago pretty much by chance http://www.mail-archive.com/commons-httpclient-dev%40jakarta.apache.org/msg00536.html I was not aware that it might have fixed bug# 16458. Could you please take the newest CVS snapshout for a