Re: [compiz] [PATCH] Grab state & Last state remembering

2007-03-06 Thread Danny Baumann
Hi, > > - Remembering of the last window state inside the state change notify > > This is useful for properly tracking down the window state changes (e.g. > > has the window been maximized in that state change?). In Beryl, we added > > a variable lastState into CompWindow, which is updated inside

Re: [compiz] [PATCH] Grab state & Last state remembering

2007-03-06 Thread Danny Baumann
Hi, > > - Remembering the grabbing state > > Previously, only one window could be grabbed at a certain time. However, > > when using group, a number of windows can be grabbed at a certain time, > > so I think it's useful to provide this information to all plugins > > without requiring them to wrap

Re: [compiz] [PATCH] Grab state & Last state remembering

2007-03-05 Thread Danny Baumann
Hi, > This patch should be removed i think. > > http://forum.go-compiz.org/viewtopic.php?p=5071#5071 > > I just post a version of group plugin working without lastState from core. > > Danny, you can save previous window state in GroupWindow instead of core: > look > at previousState variable

Re: [compiz] [PATCH] Grab state & Last state remembering

2007-03-05 Thread Bellegarde Cedric
Le lundi 5 mars 2007, David Reveman a écrit : > I've applied the patch. However, all code that cause a change to the > state should be modified so that a mask of changed bits can be passed to > the state change notify function instead. This lastState variable > shouldn't have to exist. This patch

Re: [compiz] [PATCH] Grab state & Last state remembering

2007-03-05 Thread David Reveman
On Mon, 2007-03-05 at 17:07 +0100, Danny Baumann wrote: > Hi, > > while porting "Group with tabs" to Compiz > (http://forum.go-compiz.org/viewtopic.php?t=649), I noticed some things > which are available in Beryl, but not in Compiz and which I believe > Compiz should have, too: > > - Remembering

[compiz] [PATCH] Grab state & Last state remembering

2007-03-05 Thread Danny Baumann
Hi, while porting "Group with tabs" to Compiz (http://forum.go-compiz.org/viewtopic.php?t=649), I noticed some things which are available in Beryl, but not in Compiz and which I believe Compiz should have, too: - Remembering of the last window state inside the state change notify This is useful f