[compiz] Re: compiz: Changes to 'master' (Added possibility to load textures with fixed RGBA byte ordering from header files)

2007-03-28 Thread David Reveman
On Wed, 2007-03-28 at 06:29 -0700, Danny Baumann wrote: include/compiz.h |5 +++-- src/cursor.c |3 ++- src/texture.c| 17 +++-- 3 files changed, 16 insertions(+), 9 deletions(-) New commits: commit 8e3b26fe3000602cfad0eaae2242abb1274c2ce3 Author: Danny

[compiz] Re: compiz: Changes to 'master' (Added possibility to load textures with fixed RGBA byte ordering from header files)

2007-03-28 Thread Danny Baumann
Hi, I find this change pretty ugly. Bool fixedRGBA looks like a quick hack to extend the imageToTexture function with some specific functionality. Creating a lower level function that accept a format and a type GLenum seems like a more appropriate solution to me. To be honest, I'm a bit

[compiz] Re: compiz: Changes to 'master' (Added possibility to load textures with fixed RGBA byte ordering from header files)

2007-03-28 Thread David Reveman
On Wed, 2007-03-28 at 18:28 +0200, Danny Baumann wrote: Hi, I find this change pretty ugly. Bool fixedRGBA looks like a quick hack to extend the imageToTexture function with some specific functionality. Creating a lower level function that accept a format and a type GLenum seems like