[jira] [Commented] (CONNECTORS-221) A CMIS connector would be helpful

2011-07-18 Thread Piergiorgio Lucidi (JIRA)
[ https://issues.apache.org/jira/browse/CONNECTORS-221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13066852#comment-13066852 ] Piergiorgio Lucidi commented on CONNECTORS-221: --- Ok, thank you for your

invalid unit tests

2011-07-18 Thread Tobias Rübner
The unit tests are currently not working. The first test in a module creates the properties and logging files and initializes the framework. All following tests are also creating those files, but because the framework is already initialized, they are useless. This depends on the static behaviour

Re: invalid unit tests

2011-07-18 Thread Karl Wright
These tests run fine under ant, but the ant build invokes test files explicitly. I'm not quite sure what Ant's behavior is here, and how exactly it differs from Maven's. Karl On Mon, Jul 18, 2011 at 7:41 AM, Tobias Rübner d...@tobr.eu wrote: The unit tests are currently not working. The first

[jira] [Commented] (CONNECTORS-223) Tests in project hierarchy do not adhere to maven conventions

2011-07-18 Thread Karl Wright (JIRA)
[ https://issues.apache.org/jira/browse/CONNECTORS-223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13066923#comment-13066923 ] Karl Wright commented on CONNECTORS-223: The only requirement I have for

Re: invalid unit tests

2011-07-18 Thread Karl Wright
I think the likely difference is that ant is running each test in its own JVM, and Maven is not. Now, it is straightforward enough to add functionality that resets the ManifoldCF core classes, and tie that into the tests. However, that is not how ManifoldCF will be used in practice. The concern

Re: invalid unit tests

2011-07-18 Thread Karl Wright
Looking at this a little more, the proper cleanup of a ManifoldCF process requires that the shutdown thread be run. This thread is added as a shutdown hook to the JVM. The alreadyClosed flag is used to prevent it from being run more than once if more than one shutdown signal is received, since

Re: invalid unit tests

2011-07-18 Thread Tobias Rübner
Maybe I'm on the wrong track, but there are currently 2 modules (agents | pull-agent) containing 3 individual test cases (Derby, HSQLDB, postgresql). In maven I run the test for the agents module and I thought I would end up with 3 Configuration file successfully read messages, because each Test

Re: invalid unit tests

2011-07-18 Thread Karl Wright
run-tests-framework only invokes the Derby tests. That's why you are not seeing any others. Karl On Mon, Jul 18, 2011 at 9:50 AM, Tobias Rübner d...@tobr.eu wrote: Maybe I'm on the wrong track, but there are currently 2 modules (agents | pull-agent) containing 3 individual test cases (Derby,

Re: invalid unit tests

2011-07-18 Thread Tobias Rübner
Ahh ok, sorry for that! I run all the tests of a module at once. That leads to confusing results. Now I would also structure the tests in maven to run the derby tests per default. All other test must be invoked through different profiles. Tobias On Mon, Jul 18, 2011 at 3:58 PM, Karl Wright

Re: invalid unit tests

2011-07-18 Thread Karl Wright
So please let me know if I should commit the patch I created which allows tests to run all in the same JVM. It's reasonably harmless (I think), but I'd not want to commit it if it was unnecessary. Thanks, Karl On Mon, Jul 18, 2011 at 10:26 AM, Tobias Rübner d...@tobr.eu wrote: Ahh ok, sorry

[jira] [Updated] (CONNECTORS-221) A CMIS connector would be helpful

2011-07-18 Thread Piergiorgio Lucidi (JIRA)
[ https://issues.apache.org/jira/browse/CONNECTORS-221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piergiorgio Lucidi updated CONNECTORS-221: -- Attachment: CONNECTORS-221-branch-build-patch-3.txt This patch will

[jira] [Commented] (CONNECTORS-221) A CMIS connector would be helpful

2011-07-18 Thread Karl Wright (JIRA)
[ https://issues.apache.org/jira/browse/CONNECTORS-221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13067324#comment-13067324 ] Karl Wright commented on CONNECTORS-221: Committed these changes to the