RE: [PATCH 1/1] Check error before call dbus_message_get_args to acquire arguments.

2010-04-26 Thread Marcel Holtmann
Hi Martin, > > you email still gets attached to a previous thread from you. It should > > show up as a new one. This is weird, > > > > > Function dbus_message_get_args just checks the signature which may > > > happens to be s(string), then it will just return TRUE, and the error > > > message is

RE: [PATCH 1/1] Check error before call dbus_message_get_args to acquire arguments.

2010-04-26 Thread Xu, Martin
> -Original Message- > From: connman-boun...@connman.net > [mailto:connman-boun...@connman.net] On Behalf Of Marcel Holtmann > Sent: Tuesday, April 27, 2010 1:31 PM > To: connman@connman.net > Subject: Re: [PATCH 1/1] Check error before call dbus_message_get_args to > acquire arguments. >

Re: [PATCH 1/1] Check error before call dbus_message_get_args to acquire arguments.

2010-04-26 Thread Marcel Holtmann
Hi Martin, you email still gets attached to a previous thread from you. It should show up as a new one. This is weird, > Function dbus_message_get_args just checks the signature which may > happens to be s(string), then it will just return TRUE, and the error > message is treated as return value.

[PATCH 1/1] Check error before call dbus_message_get_args to acquire arguments.

2010-04-26 Thread martin . xu
From: Martin Xu Function dbus_message_get_args just checks the signature which may happens to be s(string), then it will just return TRUE, and the error message is treated as return value. So dbus_set_error_from_message is used to check the error, before call dbus_message_get_args. --- plugins/b

Re: [PATCH 1/1] Check error beofre call dbus_message_get_args to acquire arguments.

2010-04-26 Thread Marcel Holtmann
Hi Martin, I think you see the spelling mistake in the subject after me point you at it ;) And please figure out why this email gets threaded as part of an old thread. It should be a new one actually. > Function dbus_message_get_args just checks the signature which may > happens to be s(string),

[PATCH 1/1] Check error beofre call dbus_message_get_args to acquire arguments.

2010-04-26 Thread martin . xu
From: Martin Xu Function dbus_message_get_args just checks the signature which may happens to be s(string), then it will just return TRUE, and the wrong error message is gotten. So dbus_set_error_from_message is used to check the error, before call dbus_message_get_args. --- plugins/bluetooth.c