Re: [PATCH v3 2/3] Add service statistic data structure

2010-06-29 Thread Marcel Holtmann
Hi Daniel, > The static values are maintained in the > Service object and exposed through simple > accessors. > > When a Service object enters the ready state it > registers itself at Counter. > > If the Service object is leaving the ready > state it will de-register itself from Counter > and co

Re: [PATCH v3 3/3] Update service statistic

2010-06-29 Thread Marcel Holtmann
Hi Daniel, > Instead of collecting statistics on interface > name base and storing it local in counter.c, update > the Service object. > > counter.c maps interface names to Service objects. > The assumption is made that there is a 1:1 mapping > between Service objects and interface name. > > A C

Re: [PATCH v3 1/3] Centralize rntl update timers

2010-06-29 Thread Marcel Holtmann
Hi Daniel, > Instead of creating a new rntl trigger > for each Counter object move this part > to the rtnl core. Only one update trigger > will be registered at RTNL. The minimum > interval will used for the timeout callback. patch looks good, but here are some minor nitpicks. > +static gint com

[PATCH v3 2/3] Add service statistic data structure

2010-06-29 Thread Daniel Wagner
From: Daniel Wagner The static values are maintained in the Service object and exposed through simple accessors. When a Service object enters the ready state it registers itself at Counter. If the Service object is leaving the ready state it will de-register itself from Counter and consequently

[PATCH v3 3/3] Update service statistic

2010-06-29 Thread Daniel Wagner
From: Daniel Wagner Instead of collecting statistics on interface name base and storing it local in counter.c, update the Service object. counter.c maps interface names to Service objects. The assumption is made that there is a 1:1 mapping between Service objects and interface name. A Counter o

[no subject]

2010-06-29 Thread Daniel Wagner
These patches change the Counter object interface. The Counter object sends now the Service path with the rx/tx/time statistics. The values are stored into the profile file of the Service object which makes it persistant. v3: - do not add default update interval when service registers itself

[PATCH v3 1/3] Centralize rntl update timers

2010-06-29 Thread Daniel Wagner
From: Daniel Wagner Instead of creating a new rntl trigger for each Counter object move this part to the rtnl core. Only one update trigger will be registered at RTNL. The minimum interval will used for the timeout callback. --- src/connman.h |2 + src/counter.c | 23 +++---