Re: [PATCH] Support multiple interfaces on -i and -I cmdline option.

2010-09-21 Thread Lucio Maciel
Hi Samuel On Tue, Sep 21, 2010 at 19:42, Samuel Ortiz wrote: > Hi Lucio, > > We should keep the same logic as the curent one, which means: > > +     for (pattern = device_filter; *pattern; pattern++) { > +             if (g_pattern_match_simple(*pattern, devname) == FALSE) > +                    

Re: [PATCH] Support multiple interfaces on -i and -I cmdline option.

2010-09-21 Thread Samuel Ortiz
Hi Lucio, On Tue, Sep 21, 2010 at 03:16:43PM -0300, Lucio Maciel wrote: > From: Lucio Maciel > > Support multiple comma-separeted interfaces for -i and -I > command line option. > > E.g.: > connmand -i eth*,wlan*,ppp* > connmand -I virbr*,usb*,ppp* > > --- > src/element.c | 34 +

Re: [PATCH] Update service security when changing from wpa -> wpa2.

2010-09-21 Thread Samuel Ortiz
Hi Lucio, On Tue, Sep 21, 2010 at 04:01:17PM -0300, Lucio Maciel wrote: > From: Lucio Maciel > > If the user changes the security of the AP from wpa to wpa2 > or vice-versa, connman correctly updates the network sctruct > but don't reflect it on the service. I think this is something we shouldn'

Re: [PATCH] Fix build outside of tree after linker script change

2010-09-21 Thread Marcel Holtmann
Hi Lucas, > Let configure generate connman.ver file and copy it to the build > directory. > --- > configure.ac |2 +- > src/connman.ver.in |8 > 2 files changed, 9 insertions(+), 1 deletions(-) > create mode 100644 src/connman.ver.in > > diff --git a/configure.ac b/config

[PATCH] Update service security when changing from wpa -> wpa2.

2010-09-21 Thread Lucio Maciel
From: Lucio Maciel If the user changes the security of the AP from wpa to wpa2 or vice-versa, connman correctly updates the network sctruct but don't reflect it on the service. This changes the service security and emits a Security PropertyChanged signal. --- src/service.c | 26 +

[PATCH] Support multiple interfaces on -i and -I cmdline option.

2010-09-21 Thread Lucio Maciel
From: Lucio Maciel Support multiple comma-separeted interfaces for -i and -I command line option. E.g.: connmand -i eth*,wlan*,ppp* connmand -I virbr*,usb*,ppp* --- src/element.c | 34 ++ 1 files changed, 22 insertions(+), 12 deletions(-) diff --git a/src/el

Re: [PATCH] Fix build outside of tree after linker script change

2010-09-21 Thread Lucas De Marchi
On Tue, Sep 21, 2010 at 11:55 AM, Lucas De Marchi wrote: > Let configure generate connman.ver file and copy it to the build > directory. > --- >  configure.ac       |    2 +- >  src/connman.ver.in |    8 >  2 files changed, 9 insertions(+), 1 deletions(-) Sorry, I forgot to delete the o

[PATCH] Fix build outside of tree after linker script change

2010-09-21 Thread Lucas De Marchi
Let configure generate connman.ver file and copy it to the build directory. --- configure.ac |2 +- src/connman.ver|8 src/connman.ver.in |8 3 files changed, 9 insertions(+), 9 deletions(-) delete mode 100644 src/connman.ver create mode 100644 src/connman

[PATCH] Fix build outside of tree after linker script change

2010-09-21 Thread Lucas De Marchi
Let configure generate connman.ver file and copy it to the build directory. --- configure.ac |2 +- src/connman.ver.in |8 2 files changed, 9 insertions(+), 1 deletions(-) create mode 100644 src/connman.ver.in diff --git a/configure.ac b/configure.ac index 24c61ff..93a64bc

Re: [PATCH] Call remove_network() on unsolicited disconnect.

2010-09-21 Thread Samuel Ortiz
Hi Lucio, On Tue, Sep 21, 2010 at 11:22:31AM -0300, Lucio Maciel wrote: > From: Lucio Maciel > > When receiving an unsolicited disconnect (turn-off the AP) > wpa_supplicant starts scanning every 5 seconds looking for the > previously connected ssid. > > This causes the grow of the network list

Re: [PATCH 0/4] Implement agent API 'RequestInput' method call passphrase query, take 3

2010-09-21 Thread Samuel Ortiz
Hi Patrik, On Tue, Sep 21, 2010 at 10:07:47AM +0300, patrik.fl...@nokia.com wrote: > From: Patrik Flykt > > Hi, > > The patchset has been explained in the earlier mails, so let's keep it short > and note the changes: > > The first patch is split out from the previous 2nd patch and adds

Re: connmand scanning too much?

2010-09-21 Thread Lucio Maciel
Hi, On 09/20/2010 11:51 AM, Samuel Ortiz wrote: this repeats forever... and I'm already connected to wifi on eth1 (broadcom-sta, "wl" driver). That shouldn't happen, and I'm suspecting connmand is not triggering those scans. Could you please check if wifi_scan() is called before those scans. ?

Re: [PATCH] Simplify linker script

2010-09-21 Thread Marcel Holtmann
Hi Lucas, > Version linker scripts support function names and globs, so there's no > need to rely on nm tool to gather the exported symbols. > --- > .gitignore |2 -- > Makefile.am | 12 +--- > configure.ac|3 --- > src/connman.ver |8 > 4 files changed

[PATCH] Call remove_network() on unsolicited disconnect.

2010-09-21 Thread Lucio Maciel
From: Lucio Maciel When receiving an unsolicited disconnect (turn-off the AP) wpa_supplicant starts scanning every 5 seconds looking for the previously connected ssid. This causes the grow of the network list since connman will not remove the unavailable networks if it is not the initiator of t

[PATCH] Simplify linker script

2010-09-21 Thread Lucas De Marchi
Version linker scripts support function names and globs, so there's no need to rely on nm tool to gather the exported symbols. --- .gitignore |2 -- Makefile.am | 12 +--- configure.ac|3 --- src/connman.ver |8 4 files changed, 9 insertions(+), 16 delet

Re: [PATCH v6 2/2] Add statistics ring buffer analyze tool

2010-09-21 Thread Samuel Ortiz
Hi Daniel, A few comments on this one: On Tue, Sep 21, 2010 at 01:33:43PM +0200, Daniel Wagner wrote: > From: Daniel Wagner > > This tool prints the statistic ring buffer. > --- > Makefile.am |3 +- > tools/stats-ringbuffer-test.c | 349 > +++

Re: [PATCH] Simplify linker script

2010-09-21 Thread Marcel Holtmann
Hi Lucas, > Version linker scripts support function names and globs, so there's no > need to rely on nm tool to gather the exported symbols. > --- > .gitignore |2 -- > Makefile.am | 12 +--- > configure.ac|1 - > src/connman.ver |8 > 4 files changed,

[PATCH v6 2/2] Add statistics ring buffer analyze tool

2010-09-21 Thread Daniel Wagner
From: Daniel Wagner This tool prints the statistic ring buffer. --- Makefile.am |3 +- tools/stats-ringbuffer-test.c | 349 + 2 files changed, 351 insertions(+), 1 deletions(-) create mode 100644 tools/stats-ringbuffer-test.c diff

[PATCH v6 1/2] Store stats information into separate files

2010-09-21 Thread Daniel Wagner
From: Daniel Wagner Currently the statistic information is stored into the profile file. This results in rewriting the whole file if connann_stats_save is called. This results in too many disk I/Os for low power devices. Furthermore, only the current value is stored. There is no way to find out

Statistic patches

2010-09-21 Thread Daniel Wagner
Hi, an update on the patched "3 and 4". cheers, daniel ___ connman mailing list connman@connman.net http://lists.connman.net/listinfo/connman

Re: [PATCH] Simplify linker script

2010-09-21 Thread Lucas De Marchi
On Mon, Sep 20, 2010 at 11:27 PM, Marcel Holtmann wrote: >> new file mode 100644 >> index 000..9a178a2 >> --- /dev/null >> +++ b/src/connman.ver >> @@ -0,0 +1,8 @@ >> +{ >> +     global: >> +             connman_*; >> +             g_dbus_*; >> +             g_dhcp_*; >> +     local: >> +    

Re: [PATCH v5 3/4] Store stats information into separate files

2010-09-21 Thread Daniel Wagner
On Mon, Sep 20, 2010 at 04:45:26PM +0200, Daniel Wagner wrote: > +int __connman_stats_update(struct connman_service *service, > + connman_bool_t roaming, > + struct connman_stats_data *data) > +{ > + struct stats_handle *handle; > + s

Re: [PATCH v5 3/4] Store stats information into separate files

2010-09-21 Thread Daniel Wagner
On Mon, Sep 20, 2010 at 04:45:26PM +0200, Daniel Wagner wrote: > +struct stats_record { > + struct timeval tv; > + struct connman_stats_data data; > +}; time_t for timestamping might be enough. I think we do not really care about higher resolution here. daniel

[PATCH 3/4] Use RequestInput method call when requesting passphrases

2010-09-21 Thread patrik . flykt
From: Patrik Flykt Change password query to use RequestInput method call instead of RequestPassphrase. The supplied passphrase_cb_t function sets the password returned via Agent API and tries to reconnect to the service. --- src/service.c | 21 + 1 files changed, 17 inserti

[PATCH 1/4] Add connman_service_set_passphrase helper function

2010-09-21 Thread patrik . flykt
From: Patrik Flykt Create helper function for setting a service passphrase by factoring out the code from set_property. --- src/service.c | 27 +-- 1 files changed, 17 insertions(+), 10 deletions(-) diff --git a/src/service.c b/src/service.c index b22edb1..42c8339 1006

[PATCH 4/4] Remove RequestPassphrase functionality from Agent API

2010-09-21 Thread patrik . flykt
From: Patrik Flykt Remove the obsolete __connman_agent_request_passphrase function as the RequestPassphrase method call has been replaced with RequestInput. --- src/agent.c | 28 src/connman.h |2 -- 2 files changed, 0 insertions(+), 30 deletions(-) diff --g

[PATCH 2/4] Agent API RequestInput method for requesting passphrases

2010-09-21 Thread patrik . flykt
From: Patrik Flykt request_input_passphrase_reply creates and sends an Agent API RequestInput method call and waits for the method call return. The function expects a passhphrase_cb_t to be supplied. Only the "Passphrase" dictionary field is requested by the method call and only the "Passphrase"

[PATCH 0/4] Implement agent API 'RequestInput' method call passphrase query, take 3

2010-09-21 Thread patrik . flykt
From: Patrik Flykt Hi, The patchset has been explained in the earlier mails, so let's keep it short and note the changes: The first patch is split out from the previous 2nd patch and adds a passphrase setting helper function. The second patch implements the new RequesInput Agent API me