Re: [PATCH memleak resend 08/15] memoryleak: check return value correctly before clearing pointer

Hi Jukka, > >> --- a/src/service.c > >> +++ b/src/service.c > >> @@ -3406,10 +3406,10 @@ int __connman_service_disconnect(struct > >> connman_service *service) > >> __connman_ipconfig_clear_address(service->ipconfig_ipv4); > >> __connman_ipconfig_clear_address(service->ipconfig_ipv6);

Re: [PATCH memleak resend 08/15] memoryleak: check return value correctly before clearing pointer

Hi Marcel, On 31 December 2010 20:14, Marcel Holtmann wrote: >> --- a/src/service.c >> +++ b/src/service.c >> @@ -3406,10 +3406,10 @@ int __connman_service_disconnect(struct >> connman_service *service) >>       __connman_ipconfig_clear_address(service->ipconfig_ipv4); >>       __connman_ipconfi

Re: Client or Connman Error When Dealing with Special SSIDs

On 12/31/10 11:17 AM, Grant Erickson wrote: > On 12/31/10 9:21 AM, Grant Erickson wrote: >> On 12/31/10 8:05 AM, Grant Erickson wrote: >>> On 12/30/10 12:25 PM, Marcel Holtmann wrote: > I recently came across a use case in which connmand-0.64 generates two > conflicting network service entr

Re: [PATCH memleak resend 08/15] memoryleak: check return value correctly before clearing pointer

Hi Jukka, > src/service.c |4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/service.c b/src/service.c > index befd026..68606dd 100644 > --- a/src/service.c > +++ b/src/service.c > @@ -3406,10 +3406,10 @@ int __connman_service_disconnect(struct > connman_servic

Re: [PATCH memleak resend 00/15] Memory leak fixes

Hi Jukka, > Here are the memory leak patches that I sent before christmas. > There are still issues with supplicant.c but as it is being > deprecated I have not really looked the memory leaks in it. so I applied all of the patches except one. Thanks for re-sending the whole patchset. Regards Ma

Re: [PATCH] [Memleak] Free the IO channel if connection to the DNS server fails

Hi Leena, > From: Leena Gunda > > Fixes BMC#11878 > > --- > plugins/dnsproxy.c |5 - > 1 files changed, 4 insertions(+), 1 deletions(-) patch has been applied. Thanks. Regards Marcel ___ connman mailing list connman@connman.net http://li

[PATCH] [Memleak] Free the IO channel if connection to the DNS server fails

From: Leena Gunda Fixes BMC#11878 --- plugins/dnsproxy.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/plugins/dnsproxy.c b/plugins/dnsproxy.c index 5ce6429..60b7a39 100644 --- a/plugins/dnsproxy.c +++ b/plugins/dnsproxy.c @@ -769,11 +769,14 @@ static struct serve

[PATCH memleak resend 13/15] memoryleak: remove the element when not needed

--- src/ipv4.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/src/ipv4.c b/src/ipv4.c index da115ed..c864c72 100644 --- a/src/ipv4.c +++ b/src/ipv4.c @@ -147,6 +147,8 @@ static void ipv4_remove(struct connman_element *element) if ((__connman_inet_modify_address(R

[PATCH memleak resend 15/15] memoryleak: root element was not freed

--- src/element.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/src/element.c b/src/element.c index a4230b7..1dcc695 100644 --- a/src/element.c +++ b/src/element.c @@ -1463,6 +1463,8 @@ void __connman_element_cleanup(void) g_node_traverse(element_root, G_POST_OR

[PATCH memleak resend 14/15] memoryleak: remove element when not needed any more

--- src/dhcp.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/dhcp.c b/src/dhcp.c index 36e2ff5..76c0b75 100644 --- a/src/dhcp.c +++ b/src/dhcp.c @@ -328,6 +328,7 @@ static void dhcp_remove(struct connman_element *element) } connman_dhcp_unref(dhcp);

[PATCH memleak resend 12/15] memoryleak: dhcp_client is already referenced when created

--- plugins/dhcp.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/plugins/dhcp.c b/plugins/dhcp.c index 5fe99d7..54306ed 100644 --- a/plugins/dhcp.c +++ b/plugins/dhcp.c @@ -191,8 +191,6 @@ static int dhcp_request(struct connman_dhcp *dhcp) connman_dhcp_set_dat

[PATCH memleak resend 09/15] Possible memory leak when creating ipconfig

--- src/service.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/service.c b/src/service.c index 68606dd..dafdc45 100644 --- a/src/service.c +++ b/src/service.c @@ -4329,7 +4329,8 @@ __connman_service_create_from_provider(struct connman_provider *provider)

[PATCH memleak resend 11/15] memoryleak: remove the element for real

--- src/connection.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/src/connection.c b/src/connection.c index cb0ca22..bfd19b5 100644 --- a/src/connection.c +++ b/src/connection.c @@ -408,6 +408,8 @@ static void connection_remove(struct connman_element *element)

[PATCH memleak resend 10/15] Possible memory leak when setting up ipconfig

--- src/service.c |8 ++-- 1 files changed, 6 insertions(+), 2 deletions(-) diff --git a/src/service.c b/src/service.c index dafdc45..cabc79b 100644 --- a/src/service.c +++ b/src/service.c @@ -4185,8 +4185,12 @@ struct connman_service * __connman_service_create_from_network(struct connma

[PATCH memleak resend 08/15] memoryleak: check return value correctly before clearing pointer

--- src/service.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/service.c b/src/service.c index befd026..68606dd 100644 --- a/src/service.c +++ b/src/service.c @@ -3406,10 +3406,10 @@ int __connman_service_disconnect(struct connman_service *service) __con

[PATCH memleak resend 07/15] memoryleak: proxy method string was not freed

--- src/service.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/service.c b/src/service.c index 4b2be46..befd026 100644 --- a/src/service.c +++ b/src/service.c @@ -4520,6 +4520,7 @@ static int service_load(struct connman_service *service) str = g_key_file_get

[PATCH memleak resend 04/15] memoryleak: address was not freed

--- plugins/dhcp.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/plugins/dhcp.c b/plugins/dhcp.c index 07fed38..5fe99d7 100644 --- a/plugins/dhcp.c +++ b/plugins/dhcp.c @@ -76,6 +76,7 @@ static void lease_available_cb(GDHCPClient *dhcp_client, gpointer user_data)

[PATCH memleak resend 06/15] memoryleak: method was not freed

--- src/ipconfig.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/src/ipconfig.c b/src/ipconfig.c index 57e3218..690b51e 100644 --- a/src/ipconfig.c +++ b/src/ipconfig.c @@ -1634,7 +1634,7 @@ void __connman_ipconfig_append_ethernet(struct connman_ipconfig *ipconfig, i

[PATCH memleak resend 05/15] memoryleak: block was not freed

--- plugins/supplicant.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/plugins/supplicant.c b/plugins/supplicant.c index df181d8..6e29911 100644 --- a/plugins/supplicant.c +++ b/plugins/supplicant.c @@ -224,6 +224,7 @@ static void remove_block(gpointer user_data)

[PATCH memleak resend 03/15] memoryleak: device name was not freed

--- src/inet.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/inet.c b/src/inet.c index a98896c..4523f16 100644 --- a/src/inet.c +++ b/src/inet.c @@ -459,6 +459,7 @@ struct connman_device *connman_inet_create_device(int index) if (__connman_element_device_is

[PATCH memleak resend 02/15] memoryleak: SSID was not freed

--- plugins/supplicant.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/plugins/supplicant.c b/plugins/supplicant.c index 5f2d204..df181d8 100644 --- a/plugins/supplicant.c +++ b/plugins/supplicant.c @@ -635,8 +635,12 @@ static void add_interface_reply(DBusPendingCal

[PATCH memleak resend 00/15] Memory leak fixes

Here are the memory leak patches that I sent before christmas. There are still issues with supplicant.c but as it is being deprecated I have not really looked the memory leaks in it. Regards, Jukka Jukka Rissanen (15): memoryleak: network interface string was not freed memoryleak: SSID was

[PATCH memleak resend 01/15] memoryleak: network interface string was not freed

--- plugins/portal.c | 18 -- 1 files changed, 12 insertions(+), 6 deletions(-) diff --git a/plugins/portal.c b/plugins/portal.c index 941f03d..043caaf 100644 --- a/plugins/portal.c +++ b/plugins/portal.c @@ -118,7 +118,7 @@ static int location_detect(struct connman_location *l