Re: [PATCH] Install polkit policy file as net.connman.policy

2011-01-21 Thread Samuel Ortiz
Hi Robert, On Fri, Jan 21, 2011 at 04:19:28PM +, rob...@piasek.co.uk wrote: > From: Robert Piasek Patch applied, many thanks. Cheers, Samuel. -- Intel Open Source Technology Centre http://oss.intel.com/ ___ connman mailing list connman@connman.ne

Re: [PATCH] add debug info for the readability of log

2011-01-21 Thread Samuel Ortiz
Hi Li. On Thu, Jan 20, 2011 at 03:40:57PM +0800, Li Jian wrote: > Some init/clean functions lack DBG("") which affect the readability of log Patch applied, thanks. Cheers, Samuel. -- Intel Open Source Technology Centre http://oss.intel.com/ ___ connma

Re: [PATCH v2] manager: send network-manager state change signals

2011-01-21 Thread Samuel Ortiz
Hi Kalle, On Tue, Jan 18, 2011 at 03:01:15PM +0200, Kalle Valo wrote: > When using network-manager compatibility mode in connman applications, > for example pidgin and firefox, didn't notice when connman changed states > from offline to online (and vice versa) and applications would notice the > n

Re: [PATCH v0] OpenVPN: Remove double reason parsing

2011-01-21 Thread Samuel Ortiz
Hi Daniel, On Tue, Jan 18, 2011 at 11:05:05AM +0100, Daniel Wagner wrote: > From: Daniel Wagner > > Fix a copy/past error. Patch applied, many thanks. Cheers, Samuel. -- Intel Open Source Technology Centre http://oss.intel.com/ ___ connman mailing l

Re: [PATCH 15/15] gsupplicant: Disconnect request might not need to go through RemoveNetwork call.

2011-01-21 Thread Samuel Ortiz
Hi Tomasz, On Tue, Jan 11, 2011 at 03:54:08PM +0200, Tomasz Bursztyka wrote: > --- > gsupplicant/supplicant.c |3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/gsupplicant/supplicant.c b/gsupplicant/supplicant.c > index 162cbc7..13eff19 100644 > --- a/gsupplicant/su

Re: [PATCH 11/15] WPS: service internal accessor to know wether or not wps is enabled.

2011-01-21 Thread Samuel Ortiz
Hi Tomasz, On Tue, Jan 11, 2011 at 03:54:04PM +0200, Tomasz Bursztyka wrote: > --- > src/connman.h |1 + > src/service.c |8 > 2 files changed, 9 insertions(+), 0 deletions(-) > > diff --git a/src/connman.h b/src/connman.h > index b58f903..a084748 100644 > --- a/src/connman.h >

Re: [PATCH 09/15] WPS: service's wps property support in test scripts.

2011-01-21 Thread Samuel Ortiz
Hi Tomasz, Some nitpicking: On Tue, Jan 11, 2011 at 03:54:02PM +0200, Tomasz Bursztyka wrote: > --- > test/get-services |2 +- > test/list-services |2 +- > test/test-manager |2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/test/get-services b/test/get-se

Re: [PATCH 07/15] WPS: support in service core part.

2011-01-21 Thread Samuel Ortiz
Hi Tomasz, On Tue, Jan 11, 2011 at 03:54:00PM +0200, Tomasz Bursztyka wrote: > @@ -3106,6 +3112,17 @@ int __connman_service_indicate_state(struct > connman_service *service, > > __connman_notifier_connect(service->type); > > + if (connman_network_get_bool(service->ne

Re: [PATCH 06/15] WPS: support in wifi plugin (non legacy one).

2011-01-21 Thread Samuel Ortiz
Hi Tomasz, On Tue, Jan 11, 2011 at 03:53:59PM +0200, Tomasz Bursztyka wrote: > --- > plugins/wifi.c | 70 > > 1 files changed, 70 insertions(+), 0 deletions(-) > > diff --git a/plugins/wifi.c b/plugins/wifi.c > index 040d2f9..7d87235 10

Re: [PATCH 04/15] WPS: Start() method enabler added in gsupplicant library.

2011-01-21 Thread Samuel Ortiz
Hi Tomasz, On Tue, Jan 11, 2011 at 03:53:57PM +0200, Tomasz Bursztyka wrote: > --- > gsupplicant/gsupplicant.h |2 + > gsupplicant/supplicant.c | 82 > - > 2 files changed, 83 insertions(+), 1 deletions(-) > > diff --git a/gsupplicant/gsupplica

Re: [PATCH 03/15] WPS: event signal support added in gsupplicant library.

2011-01-21 Thread Samuel Ortiz
Hi Tomasz, On Tue, Jan 11, 2011 at 03:53:56PM +0200, Tomasz Bursztyka wrote: > --- > gsupplicant/gsupplicant.h |7 ++ > gsupplicant/supplicant.c | 52 > + > 2 files changed, 59 insertions(+), 0 deletions(-) > > diff --git a/gsupplicant/gsup

Re: [PATCH 02/15] WPS: credentials signal support added in gsupplicant library.

2011-01-21 Thread Samuel Ortiz
Hi Tomasz, On Tue, Jan 11, 2011 at 03:53:55PM +0200, Tomasz Bursztyka wrote: > +const void *g_supplicant_interface_get_wps_ssid(GSupplicantInterface > *interface, > + unsigned int *ssid_len) This is more than 80 chars long. > +static void wps_

Re: [PATCH 01/15] WPS: bss/network wps enabled support in gsupplicant library.

2011-01-21 Thread Samuel Ortiz
Hi Tomasz, On Tue, Jan 11, 2011 at 03:53:54PM +0200, Tomasz Bursztyka wrote: > static void merge_network(GSupplicantNetwork *network) > { > GString *str; > @@ -930,6 +939,11 @@ static void add_bss_to_network(struct g_supplicant_bss > *bss) > memcpy(network->ssid, bss->ssid, bss->ssi

Re: [PATCH 00/15] WPS support

2011-01-21 Thread Samuel Ortiz
Hi Tomasz, On Tue, Jan 11, 2011 at 03:53:53PM +0200, Tomasz Bursztyka wrote: > Hi, > > Got WPS working in ConnMan. At least Push-Button works fine. There are still > issues with PIN method but I am strongly suspecting wpa_supplicant. Since it > adds anyway no regression whatsoever I think it i

Re: [RFC v1 1/2] Update session documantion

2011-01-21 Thread Gustavo F. Padovan
Hi Daniel, * Daniel Wagner [2011-01-21 15:56:05 +0100]: > From: Daniel Wagner > > --- > doc/manager-api.txt | 33 > doc/session-api.txt | 239 > +++ > 2 files changed, 256 insertions(+), 16 deletions(-) > create mode 100644 doc/ses

[PATCH] Install polkit policy file as net.connman.policy

2011-01-21 Thread robert
From: Robert Piasek --- Makefile.plugins |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile.plugins b/Makefile.plugins index 025e972..889705a 100644 --- a/Makefile.plugins +++ b/Makefile.plugins @@ -212,7 +212,7 @@ endif if DATAFILES policydir = @POLKIT_DATADI

[RFC v1 2/2] Refactor current Session API

2011-01-21 Thread Daniel Wagner
From: Daniel Wagner Instead of supporting only one Session, create a Session object per request. --- include/dbus.h|2 + src/connman-dbus.conf |1 + src/connman.h | 19 ++- src/manager.c | 30 +-- src/ondemand.c| 61 ++--- src/service.c |

[RFC v1 1/2] Update session documantion

2011-01-21 Thread Daniel Wagner
From: Daniel Wagner --- doc/manager-api.txt | 33 doc/session-api.txt | 239 +++ 2 files changed, 256 insertions(+), 16 deletions(-) create mode 100644 doc/session-api.txt diff --git a/doc/manager-api.txt b/doc/manager-api.txt index 7

[RFC v1 0/2] Session API

2011-01-21 Thread Daniel Wagner
From: Daniel Wagner Hi, this is a very rough first version. Right now it's only the D-Bus API and the adoption of the ondemand code. So not much to see so far. cheers, daniel Daniel Wagner (2): Update session documantion Refactor current Session API doc/manager-api.txt | 33 ++-- do

ConnMan (0.66.1) Weekly Test Report - WW04

2011-01-21 Thread Zheng, Jeff
Hi all, This is test report for ConnMan upstream connman-0.66.1. In this testing, we ran 331 cases. 304 cases passed and 27 case failed because of known/new bug. The pass rate is 92%. We found 4 new bugs and verified 5 bug Verified Bugs === [11879] conn