[PATCH v0 0/3] Move dnsproxy from plugins to core

2011-01-25 Thread Daniel Wagner
From: Daniel Wagner Hi, That was thing was too simple to be true. So I must miss something. Please have a look where I oversee the obvious thing... cheers, daniel Daniel Wagner (3): Move plugins/dnsproxy.c to src/dnsproxy.c. dnsproxy: fix checkpatch warnings dnsproxy: add command line sw

[PATCH v0 2/3] dnsproxy: fix checkpatch warnings

2011-01-25 Thread Daniel Wagner
From: Daniel Wagner --- src/dnsproxy.c | 19 --- 1 files changed, 12 insertions(+), 7 deletions(-) diff --git a/src/dnsproxy.c b/src/dnsproxy.c index 52f707d..cbd07c3 100644 --- a/src/dnsproxy.c +++ b/src/dnsproxy.c @@ -192,7 +192,7 @@ static void send_response(int sk, unsigne

[PATCH v0 3/3] dnsproxy: add command line switch

2011-01-25 Thread Daniel Wagner
From: Daniel Wagner Command line switch to disable dnsproxy. --- src/main.c | 10 -- 1 files changed, 8 insertions(+), 2 deletions(-) diff --git a/src/main.c b/src/main.c index a38eb60..8eaab16 100644 --- a/src/main.c +++ b/src/main.c @@ -63,6 +63,7 @@ static gchar *option_nodevice =

[PATCH] test: don't print Passphrase

2011-01-25 Thread Jussi Kukkonen
The test scripts are useful when asking users for debugging info, but the sensitive information makes using the output on open forums problematic. --- test/get-services |2 ++ test/list-services |2 ++ test/test-manager |2 ++ 3 files changed, 6 insertions(+), 0 deletions(-) diff --

[PATCH v1 0/4] Move dnsproxy from plugins to core

2011-01-25 Thread Daniel Wagner
From: Daniel Wagner v1: - remove ondemand v0: - initial version Daniel Wagner (4): Move plugins/dnsproxy.c to src/dnsproxy.c. dnsproxy: fix checkpatch warnings dnsproxy: add command line switch ondemand: Remove ondemand.c Makefile.am|8 +- Makefile.plugins | 12 - incl

[PATCH v1 2/4] dnsproxy: fix checkpatch warnings

2011-01-25 Thread Daniel Wagner
From: Daniel Wagner --- src/dnsproxy.c | 19 --- 1 files changed, 12 insertions(+), 7 deletions(-) diff --git a/src/dnsproxy.c b/src/dnsproxy.c index f09368c..cf907bc 100644 --- a/src/dnsproxy.c +++ b/src/dnsproxy.c @@ -195,7 +195,7 @@ static void send_response(int sk, unsigne

[PATCH v1 4/4] ondemand: Remove ondemand.c

2011-01-25 Thread Daniel Wagner
From: Daniel Wagner --- Makefile.am|8 ++--- include/ondemand.h | 38 src/connman.h |3 -- src/dnsproxy.c | 37 +--- src/main.c |2 - src/ondemand.c | 96 6 fi

[PATCH v1 3/4] dnsproxy: add command line switch

2011-01-25 Thread Daniel Wagner
From: Daniel Wagner Command line switch to disable dnsproxy. --- src/main.c | 10 -- 1 files changed, 8 insertions(+), 2 deletions(-) diff --git a/src/main.c b/src/main.c index a38eb60..8eaab16 100644 --- a/src/main.c +++ b/src/main.c @@ -63,6 +63,7 @@ static gchar *option_nodevice =

[PATCH] service: Added a script for toggling AutoConnect flag.

2011-01-25 Thread Jukka Rissanen
--- A simple script for setting and getting the service auto connect flag. test/set-autoconnect | 21 + 1 files changed, 21 insertions(+), 0 deletions(-) create mode 100755 test/set-autoconnect diff --git a/test/set-autoconnect b/test/set-autoconnect new file mode 100755 i

Re: [PATCH] test: don't print Passphrase

2011-01-25 Thread Marcel Holtmann
Hi Jussi, > The test scripts are useful when asking users for debugging info, > but the sensitive information makes using the output on open forums > problematic. > --- > test/get-services |2 ++ > test/list-services |2 ++ > test/test-manager |2 ++ > 3 files changed, 6 insertions(

Re: [PATCH] service: Added a script for toggling AutoConnect flag.

2011-01-25 Thread Marcel Holtmann
Hi Jukka, > A simple script for setting and getting the service auto connect > flag. > > test/set-autoconnect | 21 + > 1 files changed, 21 insertions(+), 0 deletions(-) > create mode 100755 test/set-autoconnect what is wrong with using test-connman autoconnect for this?

RE: USB tethering issues

2011-01-25 Thread Marcel Holtmann
Hi Guillaume, > > > I'm currently trying to test the USB tethering with connman-0.65. > > > I'm facing some issues and I'll appreciate your help. > > > > Before going further into debugging this issue, could you please add > > some debug in rtnl.c/read_uevent() to see which file it's reading, and

RE: [PATCH] service: Added a script for toggling AutoConnect flag.

2011-01-25 Thread Jukka.Rissanen
Hi Marcel, ext Marcel Holtmann wrote: > Hi Jukka, > >> A simple script for setting and getting the service auto connect >> flag. >> >> test/set-autoconnect | 21 + >> 1 files changed, 21 insertions(+), 0 deletions(-) create mode >> 100755 test/set-autoconnect > > what i

Re: [PATCH v1 3/4] dnsproxy: add command line switch

2011-01-25 Thread Marcel Holtmann
Hi Daniel, > src/main.c | 10 -- > 1 files changed, 8 insertions(+), 2 deletions(-) > > diff --git a/src/main.c b/src/main.c > index a38eb60..8eaab16 100644 > --- a/src/main.c > +++ b/src/main.c > @@ -63,6 +63,7 @@ static gchar *option_nodevice = NULL; > static gchar *option_noplugin

[PATCH v2 0/5] Move dnsproxy from plugins to core

2011-01-25 Thread Daniel Wagner
From: Daniel Wagner v2: - remove resolver module - cleanup configure.ac and README (dnsproxy: plugin -> core) v1: - remove ondemand v0: - initial version Daniel Wagner (5): dnsproxy: Move from plugins to core dnsproxy: Fix checkpatch warnings dnsproxy: Add command line switch ondema

[PATCH v2 2/5] dnsproxy: Fix checkpatch warnings

2011-01-25 Thread Daniel Wagner
From: Daniel Wagner --- src/dnsproxy.c | 19 --- 1 files changed, 12 insertions(+), 7 deletions(-) diff --git a/src/dnsproxy.c b/src/dnsproxy.c index f09368c..cf907bc 100644 --- a/src/dnsproxy.c +++ b/src/dnsproxy.c @@ -195,7 +195,7 @@ static void send_response(int sk, unsigne

[PATCH v2 3/5] dnsproxy: Add command line switch

2011-01-25 Thread Daniel Wagner
From: Daniel Wagner Command line switch to disable dnsproxy. --- src/main.c | 10 -- 1 files changed, 8 insertions(+), 2 deletions(-) diff --git a/src/main.c b/src/main.c index a38eb60..8eaab16 100644 --- a/src/main.c +++ b/src/main.c @@ -63,6 +63,7 @@ static gchar *option_nodevice =

[PATCH v2 5/5] resolver: Only support resolv.conf and dnsproxy

2011-01-25 Thread Daniel Wagner
From: Daniel Wagner Remove resolver module support. --- include/resolver.h | 17 --- src/connman.h |8 +- src/dnsproxy.c | 29 +--- src/main.c |6 +- src/resolver.c | 400 +--- 5 files changed, 172 insertions(+), 2

[PATCH v2 4/5] ondemand: Remove ondemand.c

2011-01-25 Thread Daniel Wagner
From: Daniel Wagner --- Makefile.am|8 ++--- include/ondemand.h | 38 src/connman.h |3 -- src/dnsproxy.c | 37 +--- src/main.c |2 - src/ondemand.c | 96 6 fi

[PATCH v3 0/5] Move dnsproxy from plugins to core

2011-01-25 Thread Daniel Wagner
From: Daniel Wagner v3: - use '-r' instead of '-x' for disabling the DNS Proxy v2: - remove resolver module - cleanup configure.ac and README (dnsproxy: plugin -> core) v1: - remove ondemand v0: - initial version Daniel Wagner (5): dnsproxy: Move from plugins to core dnsproxy: Fix check

[PATCH v3 2/5] dnsproxy: Fix checkpatch warnings

2011-01-25 Thread Daniel Wagner
From: Daniel Wagner --- src/dnsproxy.c | 19 --- 1 files changed, 12 insertions(+), 7 deletions(-) diff --git a/src/dnsproxy.c b/src/dnsproxy.c index f09368c..cf907bc 100644 --- a/src/dnsproxy.c +++ b/src/dnsproxy.c @@ -195,7 +195,7 @@ static void send_response(int sk, unsigne

[PATCH v3 3/5] dnsproxy: Add command line switch

2011-01-25 Thread Daniel Wagner
From: Daniel Wagner Command line switch to disable dnsproxy. --- src/main.c | 10 -- 1 files changed, 8 insertions(+), 2 deletions(-) diff --git a/src/main.c b/src/main.c index a38eb60..ce0c5e3 100644 --- a/src/main.c +++ b/src/main.c @@ -63,6 +63,7 @@ static gchar *option_nodevice =

[PATCH v3 4/5] ondemand: Remove ondemand.c

2011-01-25 Thread Daniel Wagner
From: Daniel Wagner --- Makefile.am|8 ++--- include/ondemand.h | 38 src/connman.h |3 -- src/dnsproxy.c | 37 +--- src/main.c |2 - src/ondemand.c | 96 6 fi

[PATCH v3 5/5] resolver: Only support resolv.conf and dnsproxy

2011-01-25 Thread Daniel Wagner
From: Daniel Wagner Remove resolver module support. --- include/resolver.h | 17 --- src/connman.h |8 +- src/dnsproxy.c | 29 +--- src/main.c |6 +- src/resolver.c | 400 +--- 5 files changed, 172 insertions(+), 2

Re: [PATCH] test: don't print Passphrase

2011-01-25 Thread Jussi Kukkonen
On 01/25/2011 01:43 PM, Marcel Holtmann wrote: > Hi Jussi, > >> The test scripts are useful when asking users for debugging info, >> but the sensitive information makes using the output on open forums >> problematic. >> --- >> test/get-services |2 ++ >> test/list-services |2 ++ >> test

Re: [PATCH] test: don't print Passphrase

2011-01-25 Thread Marcel Holtmann
Hi Jussi, > >> The test scripts are useful when asking users for debugging info, > >> but the sensitive information makes using the output on open forums > >> problematic. > >> --- > >> test/get-services |2 ++ > >> test/list-services |2 ++ > >> test/test-manager |2 ++ > >> 3 file

RE: USB tethering issues

2011-01-25 Thread Lucas, GuillaumeX
Hi Marcel, > > > > We can see on it that nothing occurs when I run the enable-tethering > script and that the bridge is never created :( > > if the bridge does not get created, then no wonder that Tethering does > not work. > > Can you check with brctl (part of bridge-utils) that bridge support

RE: USB tethering issues

2011-01-25 Thread Marcel Holtmann
Hi Lucas, > > > We can see on it that nothing occurs when I run the enable-tethering > > script and that the bridge is never created :( > > > > if the bridge does not get created, then no wonder that Tethering does > > not work. > > > > Can you check with brctl (part of bridge-utils) that bridge

RE: USB tethering issues

2011-01-25 Thread Lucas, GuillaumeX
Hi Marcel, > there is one bridge for all Tethering. So it could be that this already > gets enabled for Bluetooth and then we don't create a second bridge for > USB. The bridge is shared and Bluetooth clients can talk to USB > clients. > That is on purpose. I agree, this is managed by the __connm

[RFC] doc: Extended tethering API

2011-01-25 Thread Samuel Ortiz
Hi folks, So I've been thinking about how ConnMan could support the DUN server case. I gathered that the ConnMan requirements for that use case are the following: - Provide a free IP range for oFono's ppp gateway address. The address range should be a /24 one, in which oFono can freely pick a cou

Re: [RFC] doc: Extended tethering API

2011-01-25 Thread Marcel Holtmann
Hi Samuel, > So I've been thinking about how ConnMan could support the DUN server case. > I gathered that the ConnMan requirements for that use case are the following: > > - Provide a free IP range for oFono's ppp gateway address. The address range > should be a /24 one, in which oFono can freely

Re: [RFC] doc: Extended tethering API

2011-01-25 Thread Marcel Holtmann
Hi Samuel, > > So I've been thinking about how ConnMan could support the DUN server case. > > I gathered that the ConnMan requirements for that use case are the > > following: > > > > - Provide a free IP range for oFono's ppp gateway address. The address range > > should be a /24 one, in which o

Re: [PATCH v3 1/5] dnsproxy: Move from plugins to core

2011-01-25 Thread Marcel Holtmann
Hi Daniel, > Makefile.am|4 +- > Makefile.plugins | 12 - > README | 17 +- > configure.ac |7 - > plugins/dnsproxy.c | 1517 > > src/connman.h |4 + > src/dnsproxy.c | 1512

Re: [PATCH v3 3/5] dnsproxy: Add command line switch

2011-01-25 Thread Marcel Holtmann
Hi Daniel, > - __connman_dnsproxy_init(); > + if (option_dnsproxy == TRUE) > + __connman_dnsproxy_init(); this might be better done as, __connman_dnsproxy_init(option_dnsproxy); I do have the slight suspicion that we have to run basic DNS proxy enabling to ha

Re: [ofono-autoconnect PATCH 2/7] Add connman_network_clear_error()

2011-01-25 Thread Samuel Ortiz
Hi Pekka, On Mon, Jan 24, 2011 at 07:55:35PM +0200, pekka.pe...@nokia.com wrote: > From: Pekka Pessi Could we merge patch #1 and this one together ? > +void connman_network_clear_error(struct connman_network *network) > +{ > + struct connman_service *service; > + > + DBG("network %p", (

Re: [ofono-autoconnect PATCH 3/7] Set reconnect when loading a favorite service

2011-01-25 Thread Samuel Ortiz
Hi Pekka, On Mon, Jan 24, 2011 at 07:55:36PM +0200, pekka.pe...@nokia.com wrote: > From: Pekka Pessi > > Once connect succeeds, allow retrying autoconnect. > --- > src/service.c |3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/src/service.c b/src/service.c > inde

Re: [ofono-autoconnect PATCH 5/7] Mark service as failed if connect fails

2011-01-25 Thread Samuel Ortiz
Hi Pekka, On Mon, Jan 24, 2011 at 07:55:38PM +0200, pekka.pe...@nokia.com wrote: > From: Pekka Pessi > > The connman_network/provider_connect() could fail in two different ways, > returning an error code or setting the service state to failed. > > Ethernet, WiMax, Bluetooth, VPN, Cellular and W

Re: [ofono-autoconnect PATCH 7/7] ofono: be proactive with registration status

2011-01-25 Thread Samuel Ortiz
Hi Pekka, On Mon, Jan 24, 2011 at 07:55:40PM +0200, pekka.pe...@nokia.com wrote: > @@ -765,20 +770,26 @@ static void modem_roaming_changed(struct modem_data > *modem, > char const *status) > { > struct connman_device *device = modem->device; > - co

Re: [PATCH] Fix for bugs 12104

2011-01-25 Thread Samuel Ortiz
Hi Mohamed, On Wed, Jan 19, 2011 at 04:25:00PM -0800, Mohamed Abbas wrote: > The proplem related unbalnced call to connman_device_set_scanning with > TRUE/FALSE this will end up leaving device->scanning in wrong state > causing autoconnect to be not called. This patch also add > connman_device_res

[PATCH v2] Fix for bugs 12104

2011-01-25 Thread Mohamed Abbas
The proplem related unbalnced call to connman_device_set_scanning with TRUE/FALSE this will end up leaving device->scanning in wrong state causing autoconnect to be not called. This patch also add connman_device_reset_scannind api to reset device->scanning to false if scan for some reason did not s

[PATCH] Fix bug #12452.

2011-01-25 Thread Mohamed Abbas
Check if pointer is valid before free. --- gweb/gweb.c | 12 +--- 1 files changed, 9 insertions(+), 3 deletions(-) diff --git a/gweb/gweb.c b/gweb/gweb.c index 5de1083..7387e7c 100644 --- a/gweb/gweb.c +++ b/gweb/gweb.c @@ -151,10 +151,16 @@ static void free_session(struct web_session *

Re: [PATCH v2] Fix for bugs 12104

2011-01-25 Thread Samuel Ortiz
Hi Mohamed, On Tue, Jan 25, 2011 at 01:14:04PM -0800, Mohamed Abbas wrote: > The proplem related unbalnced call to connman_device_set_scanning with > TRUE/FALSE this will end up leaving device->scanning in wrong state > causing autoconnect to be not called. This patch also add > connman_device_res

Re: [PATCH] Fix bug #12452.

2011-01-25 Thread Samuel Ortiz
Hi Mohamed, On Tue, Jan 25, 2011 at 02:17:37PM -0800, Mohamed Abbas wrote: > Check if pointer is valid before free. Patch applied. Please provide a better subject for you patches in the future. Cheers, Samuel. > --- > gweb/gweb.c | 12 +--- > 1 files changed, 9 insertions(+), 3 delet

Re: [PATCH v2] Do not fail when systemd is not installed

2011-01-25 Thread Samuel Ortiz
Hi Lucas, On Mon, Jan 24, 2011 at 03:56:03PM -0200, Lucas De Marchi wrote: > Use --with-systemdsystemunitdir instead of --enabled-systemd so it's > possible to enable systemd even if systemd is not installed. Thanks, patch applied. Cheers, Samuel. -- Intel Open Source Technology Centre http://o

RE: OpenVPN does not work?

2011-01-25 Thread Zheng, Jeff
Hi Daniel, Attached is the log. Connmand still crashes with latest code. Bests Jeff > -Original Message- > From: Daniel Wagner [mailto:w...@monom.org] > Sent: Tuesday, January 25, 2011 1:58 AM > To: Zheng, Jeff > Cc: connman@connman.net > Subject: Re: OpenVPN does not work? > > Hi Jeff

Re: OpenVPN does not work?

2011-01-25 Thread Daniel Wagner
Hi Jeff, > Attached is the log. Connmand still crashes with latest code. Thanks for the log. Unfortunatly the last DBGs which I was very interested in is not printed, because the crash handler takes prefernce. Can you start connman in gdb and when it crashes dump the backtrace and the log here

Re: [PATCH v3 1/5] dnsproxy: Move from plugins to core

2011-01-25 Thread Daniel Wagner
Hi Marcel, On Tue, Jan 25, 2011 at 06:48:46PM +0100, Marcel Holtmann wrote: > Applying: dnsproxy: Move from plugins to core > /data/devel/connman/.git/rebase-apply/patch:1646: new blank line at EOF. > + > fatal: 1 line adds whitespace errors. > Patch failed at 0001 dnsproxy: Move from plugins to c

Re: [PATCH v3 3/5] dnsproxy: Add command line switch

2011-01-25 Thread Daniel Wagner
Hi Marcel, On Tue, Jan 25, 2011 at 06:50:18PM +0100, Marcel Holtmann wrote: > Hi Daniel, > > > - __connman_dnsproxy_init(); > > + if (option_dnsproxy == TRUE) > > + __connman_dnsproxy_init(); > > this might be better done as, > > __connman_dnsproxy_init(option_dnspro

RE: OpenVPN does not work?

2011-01-25 Thread Zheng, Jeff
Hi Daniel, Below is the output from gdb. > Can you start connman in gdb and when it crashes dump the > backtrace and the log here? E.g. connmand[6049]: src/ipconfig.c:__connman_ipconfig_save() ipconfig 0x80c6ee8 identifier vpn_image_build_sh_intel_com_mydomain connmand[6049]: src/ipconfig.c:__c

Re: OpenVPN does not work?

2011-01-25 Thread Daniel Wagner
Hi Jeff, > Below is the output from gdb. Great! Finally I see what's going wrong. Next time I'll ask for the gdb dump much earlier :) > Program received signal SIGSEGV, Segmentation fault. > 0x0087d933 in strchr () from /lib/libc.so.6 > (gdb) bt full > #0 0x0087d933 in strchr () from /lib/libc.s