Re: [PATCH] stats: Add comment about MAP_SHARED

Hi Samuel, On Thu, Feb 03, 2011 at 01:09:40AM +0100, Samuel Ortiz wrote: > Hi Daniel, > > On Wed, Feb 02, 2011 at 09:40:48AM +0100, Daniel Wagner wrote: > > From: Daniel Wagner > > > > Clarify why MAP_SHARED is used instead of the obvious MAP_PRIVATE. > Patch applied, after a whitespace fix. Ma

Re: [PATCH] stats: Add comment about MAP_SHARED

Hi Daniel, On Wed, Feb 02, 2011 at 09:40:48AM +0100, Daniel Wagner wrote: > From: Daniel Wagner > > Clarify why MAP_SHARED is used instead of the obvious MAP_PRIVATE. Patch applied, after a whitespace fix. Many thanks. Cheers, Samuel. -- Intel Open Source Technology Centre http://oss.intel.co

Re: [PATCH v2 1/2] technology: trigger technology creation by new interface

Hi Guillaume, On Wed, Feb 02, 2011 at 03:06:51PM +, Lucas, GuillaumeX wrote: > From: Guillaume Lucas The patch looks fine, but when applied I get: cc1: warnings being treated as errors src/technology.c: In function ‘technology_get’: src/technology.c:144: error: implicit declaration of functi

Re: [RFC] doc: Extended tethering API

Hi Marcel, * Marcel Holtmann [2011-01-25 18:17:37 +0100]: > Hi Samuel, > > > So I've been thinking about how ConnMan could support the DUN server case. > > I gathered that the ConnMan requirements for that use case are the > > following: > > > > - Provide a free IP range for oFono's ppp gatew

[PATCH v2 2/2] ethernet: Create the bridge before to add an interface to it.

From: Guillaume Lucas The bridge is created by the connman_technology_tethering_notify() function. So this function must be called before to add an interface to the bridge. Means before the call to connman_inet_add_to_bridge(). --- plugins/ethernet.c |4 ++-- 1 files changed, 2 insertions(+)

[PATCH v2 1/2] technology: trigger technology creation by new interface

From: Guillaume Lucas --- src/technology.c | 198 +++-- 1 files changed, 101 insertions(+), 97 deletions(-) diff --git a/src/technology.c b/src/technology.c index ff1cf78..5ebd134 100644 --- a/src/technology.c +++ b/src/technology.c @@ -133,6 +13

[PATCH v2 0/2] USB tethering

Hi, Following patch fix issues for USB tethering. Those patches was successfully tested in HW with latest version of connman and latest version of ofono. Patch "Call __connman_technology_add_interface() after rtnl->newlink()" from Martin is no more necessary with those patches. Regards, Guilla

Re: [PATCH 1/2] ethernet: Add gadget driver

Hi Guillaume, On Wed, Feb 02, 2011 at 01:46:54PM +, Lucas, GuillaumeX wrote: > Hi Samuel > > > Although the code is right and certainly fixes our issue, I'm bothered > > by the > > fact that we need a device driver to create a technology, although we > > know the > > technology exists since w

RE: [PATCH 1/2] ethernet: Add gadget driver

Hi Samuel > Although the code is right and certainly fixes our issue, I'm bothered > by the > fact that we need a device driver to create a technology, although we > know the > technology exists since we have an interface for it. In other words, I > don't > see why the technology creation could no

Re: [RFC 0/2] Service provisioning method in Manager API

On Mon, 2011-01-31 at 16:37 +0200, Henri Bragge wrote: > Hi, > > A dbus API is needed to provide UI support for 802.1X network > provisioning. This proposal adds a method in Manager API that > can be used to provide a service configuration as a single string > that follows the format described in

Re: [RFC] EAP login support in Agent API

On Mon, 2011-01-31 at 11:43 +0200, Henri Bragge wrote: > Hi, > > Support for interactive query of EAP credentials (username and/or > password) is sometimes needed when connecting to 802.1X networks. > [...] > Henri Bragge (1): > doc: Add EAP login support in Agent API > > doc/agent-api.txt

[PATCH v4 2/2] service: Extend Service nameserver API

From: Daniel Wagner The current __connman_service_append/remove_nameserver allows only changing nameserver for the manual (e.g. non DHCP) setup. __connman_service_append/remove_namerserver() is renamed to __connman_service_nameserver_append/remove to be more consistent with the other Service API

[PATCH v4 0/2] DHCP refactoring (aka get rid of DHCP element)

From: Daniel Wagner I have only included the first two patches since the other ones haven't changed. I have tested them ;) cheers, daniel Daniel Wagner (2): dnsproxy: Ignore empty domains in append_domain service: Extend Service nameserver API include/service.h |2 +- plugins/pacrun

[PATCH v4 1/2] dnsproxy: Ignore empty domains in append_domain

From: Daniel Wagner The server_list can contain global nameservers such as the Google ones 8.8.8.8, 8.8.4.4 which do not have a domain associated with it. Therefore we should not do any strcmp on those entries. --- src/dnsproxy.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff

Re: [PATCH 2/2] ethernet: Create the bridge before to add an interface to it.

Hi Guillaume, On Tue, Feb 01, 2011 at 03:35:52PM +, Lucas, GuillaumeX wrote: > From: Guillaume Lucas > > The bridge is created by the connman_technology_tethering_notify() > function. So this function must be called before to add an interface > to the bridge. Means before the call to connman

Re: [PATCH 1/2] ethernet: Add gadget driver

Hi Guillaume, On Tue, Feb 01, 2011 at 03:35:47PM +, Lucas, GuillaumeX wrote: > From: Guillaume Lucas Although the code is right and certainly fixes our issue, I'm bothered by the fact that we need a device driver to create a technology, although we know the technology exists since we have an

[PATCH] stats: Add comment about MAP_SHARED

From: Daniel Wagner Clarify why MAP_SHARED is used instead of the obvious MAP_PRIVATE. --- src/stats.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/src/stats.c b/src/stats.c index 929e09b..45b067e 100644 --- a/src/stats.c +++ b/src/stats.c @@ -286,6 +286,12 @@ st