Re: [PATCH] ipconfig: Enable IPv6 privacy extension for autoconf addresses

2011-02-15 Thread Samuel Ortiz
Hi Jukka, On Mon, Feb 14, 2011 at 10:24:23AM +0200, Jukka Rissanen wrote: This is described in RFC 3041 and RFC 4941 It makes sense to me. I have some comments though: +static void set_ipv6_privacy(gchar *ifname, int value) +{ + gchar *path; + FILE *f; + + if (ifname == NULL)

Re: [PATCH] Rename __connman_technology_enable_device() to __connman_technology_set_enable().

2011-02-15 Thread Samuel Ortiz
Hi Alok, On Wed, Feb 09, 2011 at 01:39:43PM +0200, Alok Barsode wrote: From: Alok Barsode alok.bars...@nokia.com __connman_technology_enable_device() enabled the technology (state). Hence renaming it aptly.It used the device pointer to just get connman_service_type. Could you please merge

Re: [PATCH] network: IPv6 must go through disconnect state before idle.

2011-02-15 Thread Samuel Ortiz
Hi Jukka, On Fri, Feb 11, 2011 at 03:22:53PM +0200, Jukka Rissanen wrote: --- Hi Samuel, please apply this patch as without it the system will not go offline. The patch adds DISCONNECT state for IPv6 that should be entered before IDLE state. Eventually the IPv6 disconnection should be

Re: [PATCH] Remove blocked Technology state and use offline state instead.

2011-02-15 Thread Samuel Ortiz
Hi Alok, On Wed, Feb 09, 2011 at 01:39:56PM +0200, Alok Barsode wrote: From: Alok Barsode alok.bars...@nokia.com Both offline and blocked states mean the same hence merging them. It makes sense, let's see how that goes. I applied this patch, thanks a lot. Cheers, Samuel. -- Intel Open

[RFC v9 00/11] DHCP refactoring (aka get rid of DHCP element)

2011-02-15 Thread Daniel Wagner
From: Daniel Wagner daniel.wag...@bmw-carit.de Hi, just an update... cheers, daniel Daniel Wagner (11): service: Refactor Service nameserver API ipconfig: Rename __connman_ipconfig_get_*(index) ipconfig: Add ipaddress setters/getters Remove connection element ipconfig: Add

[RFC v9 01/11] service: Refactor Service nameserver API

2011-02-15 Thread Daniel Wagner
From: Daniel Wagner daniel.wag...@bmw-carit.de __connman_service_append/remove_namerserver() is renamed to __connman_service_nameserver_append/remove to be more consistent with the other Service API naming. Also the semantic changes to append/remove instead of set/clear. The list of configured

[RFC v9 02/11] ipconfig: Rename __connman_ipconfig_get_*(index)

2011-02-15 Thread Daniel Wagner
From: Daniel Wagner daniel.wag...@bmw-carit.de To avoid a name clash with the next patch, the __connman_ipconfig_get_*(index) have to be renamed. Since they all use an index as lookup argument rename them to __connman_ipconfig_get_*_from_index(index). --- src/connman.h |6 +++---

[RFC v9 04/11] Remove connection element

2011-02-15 Thread Daniel Wagner
From: Daniel Wagner daniel.wag...@bmw-carit.de --- include/element.h |1 - src/connection.c | 325 + src/connman.h |8 +- src/element.c | 11 +- src/ipconfig.c| 47 - src/ipv4.c| 39 ---

[RFC v9 03/11] ipconfig: Add ipaddress setters/getters

2011-02-15 Thread Daniel Wagner
From: Daniel Wagner daniel.wag...@bmw-carit.de --- src/connman.h | 13 - src/ipconfig.c | 86 +++- src/network.c |4 +- 3 files changed, 99 insertions(+), 4 deletions(-) diff --git a/src/connman.h b/src/connman.h index

[RFC v9 05/11] ipconfig: Add __connman_ipconfig_set_ipv4/ipv6

2011-02-15 Thread Daniel Wagner
From: Daniel Wagner daniel.wag...@bmw-carit.de Remove also connman_ipaddress_set_ipv4/ipv6. --- include/inet.h |2 -- include/ipconfig.h |3 --- src/connman.h |6 ++ src/ipconfig.c | 48 +--- 4 files changed, 43

[RFC v9 06/11] service: Add __connman_service_timeserver_append/remove

2011-02-15 Thread Daniel Wagner
From: Daniel Wagner daniel.wag...@bmw-carit.de --- src/connman.h |5 + src/service.c | 21 + 2 files changed, 26 insertions(+), 0 deletions(-) diff --git a/src/connman.h b/src/connman.h index 36e2d91..c71e180 100644 --- a/src/connman.h +++ b/src/connman.h @@ -275,6

[RFC v9 07/11] service: Add __connman_service_pac_append/remove

2011-02-15 Thread Daniel Wagner
From: Daniel Wagner daniel.wag...@bmw-carit.de --- src/connman.h |4 src/service.c | 20 2 files changed, 24 insertions(+), 0 deletions(-) diff --git a/src/connman.h b/src/connman.h index c71e180..ee025f5 100644 --- a/src/connman.h +++ b/src/connman.h @@ -279,6

[RFC v9 08/11] provider: Add connman_provider_set_ipaddress

2011-02-15 Thread Daniel Wagner
From: Daniel Wagner daniel.wag...@bmw-carit.de And remove the unimplemented IP configuration functions. --- include/provider.h | 15 +++ src/provider.c | 41 + 2 files changed, 48 insertions(+), 8 deletions(-) diff --git

[RFC v9 09/11] openvpn: Use provider set/get functions

2011-02-15 Thread Daniel Wagner
From: Daniel Wagner daniel.wag...@bmw-carit.de --- plugins/openvpn.c | 45 ++--- 1 files changed, 42 insertions(+), 3 deletions(-) diff --git a/plugins/openvpn.c b/plugins/openvpn.c index 60e75dc..0eaa2cb 100644 --- a/plugins/openvpn.c +++

[RFC v9 10/11] ipconfig: Only save FIXED MANUAL IP configuraiton

2011-02-15 Thread Daniel Wagner
From: Daniel Wagner daniel.wag...@bmw-carit.de --- src/ipconfig.c | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/src/ipconfig.c b/src/ipconfig.c index 690a61e..d3f39f9 100644 --- a/src/ipconfig.c +++ b/src/ipconfig.c @@ -1947,6 +1947,17 @@ int

[RFC v9 11/11] dhcp: Remove DHCP element

2011-02-15 Thread Daniel Wagner
From: Daniel Wagner daniel.wag...@bmw-carit.de --- include/element.h |2 - src/connman.h | 12 ++ src/dhcp.c| 302 +++-- src/element.c |9 -- src/main.c|2 + src/network.c | 110 ++- 6

[PATCH v2] ipconfig: Enable IPv6 privacy extension for autoconf addresses.

2011-02-15 Thread Jukka Rissanen
This is described in RFC 3041 and RFC 4941 --- src/ipconfig.c | 64 1 files changed, 64 insertions(+), 0 deletions(-) diff --git a/src/ipconfig.c b/src/ipconfig.c index 1fb8281..f6af4c4 100644 --- a/src/ipconfig.c +++ b/src/ipconfig.c @@

Re: [PATCH v2] ipconfig: Enable IPv6 privacy extension for autoconf addresses.

2011-02-15 Thread Samuel Ortiz
Hi Jukka, One more coding style issue I didnt spot ealier: On Tue, Feb 15, 2011 at 04:21:06PM +0200, Jukka Rissanen wrote: This is described in RFC 3041 and RFC 4941 --- src/ipconfig.c | 64 1 files changed, 64 insertions(+), 0

[PATCH] ipconfig: Never return or set system wide IPv6 status value.

2011-02-15 Thread Jukka Rissanen
--- src/ipconfig.c | 18 +- 1 files changed, 9 insertions(+), 9 deletions(-) diff --git a/src/ipconfig.c b/src/ipconfig.c index 1fb8281..f8ca414 100644 --- a/src/ipconfig.c +++ b/src/ipconfig.c @@ -299,13 +299,13 @@ static gboolean get_ipv6_state(gchar *ifname) int

[PATCH v10 0/4] DHCP refactoring (aka get rid of DHCP element)

2011-02-15 Thread Daniel Wagner
From: Daniel Wagner daniel.wag...@bmw-carit.de Hi, Here is the first part of the DHCP removal series. This series includes the nameserver API refactoring and the connection element removal. cheers, daniel Daniel Wagner (4): service: Refactor Service nameserver API ipconfig: Rename

[PATCH v10 1/4] service: Refactor Service nameserver API

2011-02-15 Thread Daniel Wagner
From: Daniel Wagner daniel.wag...@bmw-carit.de __connman_service_append/remove_namerserver() is renamed to __connman_service_nameserver_append/remove to be more consistent with the other Service API naming. Also the semantic changes to append/remove instead of set/clear. The list of configured

[PATCH v10 3/4] ipconfig: Add ipaddress setters/getters

2011-02-15 Thread Daniel Wagner
From: Daniel Wagner daniel.wag...@bmw-carit.de --- src/connman.h | 13 - src/ipconfig.c | 86 +++- src/network.c |4 +- 3 files changed, 99 insertions(+), 4 deletions(-) diff --git a/src/connman.h b/src/connman.h index

[PATCH v10 4/4] connection: Remove connection element

2011-02-15 Thread Daniel Wagner
From: Daniel Wagner daniel.wag...@bmw-carit.de --- include/element.h |1 - src/connection.c | 325 + src/connman.h |8 +- src/element.c | 11 +- src/ipconfig.c| 47 - src/ipv4.c| 39 ---

[PATCH v3] ipconfig: Enable IPv6 privacy extension for autoconf addresses.

2011-02-15 Thread Jukka Rissanen
This is described in RFC 3041 and RFC 4941 --- src/ipconfig.c | 66 1 files changed, 66 insertions(+), 0 deletions(-) diff --git a/src/ipconfig.c b/src/ipconfig.c index 1fb8281..0f676d3 100644 --- a/src/ipconfig.c +++ b/src/ipconfig.c @@

Re: [PATCH v3] ipconfig: Enable IPv6 privacy extension for autoconf addresses.

2011-02-15 Thread Samuel Ortiz
Hi David, On Tue, Feb 15, 2011 at 04:34:58PM +, David Woodhouse wrote: On Tue, 2011-02-15 at 16:54 +0200, Jukka Rissanen wrote: This is described in RFC 3041 and RFC 4941 Your code isn't described there. static void free_ipdevice(gpointer data) { struct

Re: [PATCH v10 4/4] connection: Remove connection element

2011-02-15 Thread Samuel Ortiz
Hi Daniel, On Tue, Feb 15, 2011 at 03:51:52PM +0100, Daniel Wagner wrote: From: Daniel Wagner daniel.wag...@bmw-carit.de I applied this patch with the following fix: +int __connman_connection_gateway_add(struct connman_service *service, + const char

Re: [PATCH v10 0/4] DHCP refactoring (aka get rid of DHCP element)

2011-02-15 Thread Samuel Ortiz
Hi Daniel, On Tue, Feb 15, 2011 at 03:51:48PM +0100, Daniel Wagner wrote: From: Daniel Wagner daniel.wag...@bmw-carit.de Hi, Here is the first part of the DHCP removal series. This series includes the nameserver API refactoring and the connection element removal. All patches applied, with

Re: [PATCH v3] ipconfig: Enable IPv6 privacy extension for autoconf addresses.

2011-02-15 Thread Jukka Rissanen
Hi David, ... but while ConnMan is driving the device we *always* use this horrid 'privacy' mode when IPv6 is enabled? What kind of problems there is with the privacy mode? Regards, Jukka ___ connman mailing list connman@connman.net

Re: [RFC 0/3] Fix handling of provisioned APN

2011-02-15 Thread Samuel Ortiz
Hi Henri, On Mon, Feb 14, 2011 at 02:50:17PM +0200, Henri Bragge wrote: Hi, This patchset tries to fix handling of APNs that are provisioned in ofono ConnectionContexts rather than written there by connman. After reviewing your patch, and looking at the oFono GPRS provisioning, we decided to

Re: [PATCH] doc: ipv6 prefix length is a string

2011-02-15 Thread Marcel Holtmann
Hi Kalle, Also the dict type is a{ss}, not a{sv} as I expected, but don't know how I should mark that. --- doc/service-api.txt |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/doc/service-api.txt b/doc/service-api.txt index b3e758e..ff6b044 100644 ---

Re: [PATCH] doc: ipv6 prefix length is a string

2011-02-15 Thread Kalle Valo
Marcel Holtmann mar...@holtmann.org writes: Hi Kalle, Hi Marcel, --- a/doc/service-api.txt +++ b/doc/service-api.txt @@ -367,7 +367,7 @@ Properties string State [readonly] The current configured IPv6 address. -uint8 PrefixLength

crash in connman_ipaddress_free()

2011-02-15 Thread Kalle Valo
Hello, last week I saw a crash which I forgot to report here. IIRC I was just enabling and disabling ethernet and wifi connections and then connman crashed. I don't have the commit id anymore, but I think I was using latest git from 2011-02-08. Here's more information: connmand[23737]:

Re: [RFC 0/3] Fix handling of provisioned APN

2011-02-15 Thread Henri Bragge
On Wed, 2011-02-16 at 02:07 +0100, Samuel Ortiz wrote: Hi Henri, On Mon, Feb 14, 2011 at 02:50:17PM +0200, Henri Bragge wrote: Hi, This patchset tries to fix handling of APNs that are provisioned in ofono ConnectionContexts rather than written there by connman. After reviewing your