Re: [PATCH 1/5] doc: Add EAP login support in Agent API

2011-03-01 Thread Henri Bragge
Hi Marcel, On Tue, 2011-03-01 at 11:39 -0800, Marcel Holtmann wrote: > > Arguments string Type > > > > - Contains the type of a field. For example "psk", > > - "wep", "ssid", "wpspin" or plain "string". > > + Contains the type of a field. F

Re: [PATCH 1/5] doc: Add EAP login support in Agent API

2011-03-01 Thread Marcel Holtmann
Hi Henri, > doc/agent-api.txt | 27 +++ > 1 files changed, 23 insertions(+), 4 deletions(-) > > diff --git a/doc/agent-api.txt b/doc/agent-api.txt > index 98499a3..fbae242 100644 > --- a/doc/agent-api.txt > +++ b/doc/agent-api.txt > @@ -61,10 +61,15 @@ Fields

[PATCH 4/5] agent: Implement EAP identity and password query

2011-03-01 Thread Henri Bragge
Besides adding Identity field into the API, this patch also removes the restriction to receive value for only one field per response. Now both Identity and Passphrase can be received in one call. --- src/agent.c | 51 +++ src/connman.h |3 ++-

[PATCH 5/5] test: Add identity response support to simple-agent

2011-03-01 Thread Henri Bragge
Support also responding with arbitrary combination of parameters, instead of only one property at a time. --- test/simple-agent | 21 +++-- 1 files changed, 15 insertions(+), 6 deletions(-) diff --git a/test/simple-agent b/test/simple-agent index 5c73599..b0990de 100755 --- a/te

[PATCH 3/5] service: Add function to get phase2 method

2011-03-01 Thread Henri Bragge
--- src/connman.h |1 + src/service.c |8 2 files changed, 9 insertions(+), 0 deletions(-) diff --git a/src/connman.h b/src/connman.h index f6540af..1eda025 100644 --- a/src/connman.h +++ b/src/connman.h @@ -488,6 +488,7 @@ const char *__connman_service_get_path(struct connman_s

[PATCH 1/5] doc: Add EAP login support in Agent API

2011-03-01 Thread Henri Bragge
--- doc/agent-api.txt | 27 +++ 1 files changed, 23 insertions(+), 4 deletions(-) diff --git a/doc/agent-api.txt b/doc/agent-api.txt index 98499a3..fbae242 100644 --- a/doc/agent-api.txt +++ b/doc/agent-api.txt @@ -61,10 +61,15 @@ Fields string Name

[PATCH 2/5] service: Add function to set identity

2011-03-01 Thread Henri Bragge
--- src/connman.h |2 ++ src/service.c | 15 +++ 2 files changed, 17 insertions(+), 0 deletions(-) diff --git a/src/connman.h b/src/connman.h index 437eaed..f6540af 100644 --- a/src/connman.h +++ b/src/connman.h @@ -536,6 +536,8 @@ const char *__connman_service_get_nameserver(st

[PATCH 0/5] EAP login support in Agent API

2011-03-01 Thread Henri Bragge
Hi, This patchset adds support for interactive query of EAP credentials (username/password) in Agent API, which is needed when connecting to 802.1X networks. New "Identity" field is introduced for username and "Passphrase" field is reused for password. Also new field types are used that define wh

Re: [PATCH v2 0/3] Postpone cellular connections until needed

2011-03-01 Thread Henri Bragge
On Tue, 2011-03-01 at 17:20 +0200, Henri Bragge wrote: > Hi, > > The v2 adapts the previous patches to element removal. > Please ignore the two 3/3 patches without the "v2" tag, they are trash. Sorry for my carelessness. - Henri ___ connman mailing

[PATCH v2 3/3] ofono: Connect when context activation is requested

2011-03-01 Thread Henri Bragge
ConnMan should connect the corresponding network/service after a successful response to context activation request. If the context was already active, connecting has to happen this way instead of waiting for active property going up (it already is up). In case the context was inactive before activ

[PATCH 3/3] ofono: Connect when context activation is requested

2011-03-01 Thread Henri Bragge
+static void set_connected(struct network_info *info, + connman_bool_t connected); + static void set_active_reply(DBusPendingCall *call, void *user_data) { char const *path = user_data; @@ -435,7 +438,8 @@ static void set_active_reply(DBusPendingCall *call, v

[PATCH v2 1/3] Make __connman_network_get_connecting() available for plugins

2011-03-01 Thread Henri Bragge
--- include/network.h |1 + src/connman.h |1 - src/device.c |2 +- src/network.c |2 +- src/service.c |3 +-- 5 files changed, 4 insertions(+), 5 deletions(-) diff --git a/include/network.h b/include/network.h index d898531..a673703 100644 --- a/include/netwo

[PATCH v2 2/3] ofono: Do not connect autonomously activated contexts

2011-03-01 Thread Henri Bragge
When activated context is found, do not connect to it unless requested to do so. --- plugins/ofono.c | 11 +-- 1 files changed, 9 insertions(+), 2 deletions(-) diff --git a/plugins/ofono.c b/plugins/ofono.c index 3b76dcb..f7454e0 100644 --- a/plugins/ofono.c +++ b/plugins/ofono.c @@ -62

[PATCH 3/3] ofono: Connect when context activation is requested

2011-03-01 Thread Henri Bragge
ConnMan should connect the corresponding network/service after a successful response to context activation request. If the context was already active, connecting has to happen this way instead of waiting for active property going up (it already is up). In case the context was inactive before activ

[PATCH v2 0/3] Postpone cellular connections until needed

2011-03-01 Thread Henri Bragge
Hi, The v2 adapts the previous patches to element removal. Henri Bragge (3): Make __connman_network_get_connecting() available for plugins ofono: Do not connect autonomously activated contexts ofono: Connect when context activation is requested include/network.h |1 + plugins/ofono.c

[RFC v2 1/2] Update session documantion.

2011-03-01 Thread Daniel Wagner
From: Daniel Wagner Written by Marcel Holtmann. --- doc/manager-api.txt | 33 doc/session-api.txt | 239 +++ 2 files changed, 256 insertions(+), 16 deletions(-) create mode 100644 doc/session-api.txt diff --git a/doc/manager-api.txt b

[RFC v2 2/2] Refactor current Session API

2011-03-01 Thread Daniel Wagner
From: Daniel Wagner Instead of supporting only one Session, create a Session object per request. --- include/dbus.h|2 + src/connman-dbus.conf |1 + src/connman.h | 15 +- src/manager.c | 30 +-- src/service.c | 37 ++- src/session.c | 896 +

[RFC v2 0/2] Session API

2011-03-01 Thread Daniel Wagner
From: Daniel Wagner Hi, an another update on the Session API. It doesn't do much aside of trying to stay connected for selected service. So it does a bit more then the old Session API. I would like to get the current code in shape so it can be applied. The implemented algorithm is too simple

Re: [PATCH v1 5/6] Add rfkill functionality and get rid of rfkill cache.

2011-03-01 Thread alok barsode
Hi Samuel, Response inline. On Tue, Mar 1, 2011 at 2:13 AM, Samuel Ortiz wrote: > Hi Alok, > > On Sat, Feb 19, 2011 at 01:07:37AM +0200, Alok Barsode wrote: >> From: Alok Barsode >> >> There is no need to cache rfkill events, since Connman cannot keep track of >> individual devices anyway. A Te

Re: [PATCH v1 2/6] Redo EnableTechnology API logic.

2011-03-01 Thread alok barsode
Hi Samuel, Thanks for reviewing. Response inline. On Tue, Mar 1, 2011 at 2:13 AM, Samuel Ortiz wrote: > Hi Alok, > > On Sat, Feb 19, 2011 at 01:07:34AM +0200, Alok Barsode wrote: >> From: Alok Barsode >> >> EnableTechnology used to traverse the whole element tree enabling devices. >> Instead tr

Re: [PATCH v1 1/6] Remove __connman_device_[enable/disable]_persistent.

2011-03-01 Thread alok barsode
Hi Samuel, Thanks for your comments. My inline response. On Tue, Mar 1, 2011 at 2:12 AM, Samuel Ortiz wrote: > Hi Alok, > > On Sat, Feb 19, 2011 at 01:07:33AM +0200, Alok Barsode wrote: >> From: Alok Barsode >> >> Use __connman_device_[enable/disable] to store the peristent states >> of device