Re: [RFC v3 1/2] Update session documantion.

Hi Samuel, > > > > + array{string} AllowedBearers [readwrite] > > > > + > > > > + A list of bearers that can be used for this > > > > session. > > > > + In general this list should be empty to > > > > indicate that > > > > +

Re: [RFC v3 1/2] Update session documantion.

Hi Marcel, On Thu, Mar 17, 2011 at 09:44:30AM -0700, Marcel Holtmann wrote: > Hi Samuel, > > > > diff --git a/doc/session-api.txt b/doc/session-api.txt > > > new file mode 100644 > > > index 000..bede642 > > > --- /dev/null > > > +++ b/doc/session-api.txt > > > @@ -0,0 +1,240 @@ > > > +Servic

Re: [PATCH 6to4 v5 3/9] inet: Add routines to send IPv6 router solicitation message.

Hi Jukka, > >> diff --git a/src/inet.c b/src/inet.c > >> index 858d34c..40d8a8d 100644 > >> --- a/src/inet.c > >> +++ b/src/inet.c > >> @@ -4,6 +4,10 @@ > >> * > >> * Copyright (C) 2007-2010 Intel Corporation. All rights reserved. > >> * > >> + * Portions (IPv6 router solicitation handlin

Re: [PATCH v0 0/6] cppcheck fixes

Hi Daniel, On Thu, Mar 17, 2011 at 02:25:34PM +0100, Daniel Wagner wrote: > From: Daniel Wagner > > Hi, > > here a few one liners for fixing bugs reported by DJ Cozatt. All patches except patch #2 applied. Thanks a lot. Cheers, Samuel. -- Intel Open Source Technology Centre http://oss.intel.

Re: [RFC v3 1/2] Update session documantion.

Hi Samuel, > > diff --git a/doc/session-api.txt b/doc/session-api.txt > > new file mode 100644 > > index 000..bede642 > > --- /dev/null > > +++ b/doc/session-api.txt > > @@ -0,0 +1,240 @@ > > +Serviceunique name > > +Interface net.connman.Notification > I would prefer a more verbo

Re: [PATCH v0 2/6] tist: Fix initializing of variable

Hi Daniel, On Thu, Mar 17, 2011 at 02:25:36PM +0100, Daniel Wagner wrote: > From: Daniel Wagner > > Using sizeof for array given as function argument returns the size of > pointer > > Reported by: DJ Cozatt > --- > plugins/tist.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) >

Re: [RFC v3 1/2] Update session documantion.

Adding Marcel, with the right email address. On Thu, Mar 17, 2011 at 05:24:41PM +0100, Samuel Ortiz wrote: > Hi Daniel, > > On Thu, Mar 17, 2011 at 11:35:09AM +0100, Daniel Wagner wrote: > > From: Marcel Hotlmann > Holtmann ;) > > > diff --git a/doc/session-api.txt b/doc/session-api.txt > > new

Re: [RFC v3 2/2] session: Refactor Session API

Hi Daniel, On Thu, Mar 17, 2011 at 11:35:10AM +0100, Daniel Wagner wrote: > From: Daniel Wagner > > In order to enable session support there is a master switch > (EnableSessionMode) on the manager. If enabled all service will > disconnected and keept disconnected. > > Only services which are pa

Re: [RFC v3 1/2] Update session documantion.

Hi Daniel, On Thu, Mar 17, 2011 at 11:35:09AM +0100, Daniel Wagner wrote: > From: Marcel Hotlmann Holtmann ;) > diff --git a/doc/session-api.txt b/doc/session-api.txt > new file mode 100644 > index 000..bede642 > --- /dev/null > +++ b/doc/session-api.txt > @@ -0,0 +1,240 @@ > +Service

[PATCH v2 5/5] test: Add identity response support to simple-agent

Support also responding with arbitrary combination of parameters, instead of only one property at a time. --- test/simple-agent | 21 +++-- 1 files changed, 15 insertions(+), 6 deletions(-) diff --git a/test/simple-agent b/test/simple-agent index 5c73599..b0990de 100755 --- a/te

[PATCH v2 3/5] service: Add function to get phase2 method

--- src/connman.h |1 + src/service.c |8 2 files changed, 9 insertions(+), 0 deletions(-) diff --git a/src/connman.h b/src/connman.h index 8275559..ac81091 100644 --- a/src/connman.h +++ b/src/connman.h @@ -487,6 +487,7 @@ const char *__connman_service_get_path(struct connman_s

[PATCH v2 2/5] service: Add function to set identity

--- src/connman.h |2 ++ src/service.c | 15 +++ 2 files changed, 17 insertions(+), 0 deletions(-) diff --git a/src/connman.h b/src/connman.h index 42bf2e6..8275559 100644 --- a/src/connman.h +++ b/src/connman.h @@ -535,6 +535,8 @@ const char *__connman_service_get_nameserver(st

[PATCH v2 4/5] agent: Implement EAP identity and passphrase query

EAP credentials will be queried whenever connecting to an 802.1X network unless EAP-TLS is used OR if service is provisioned via .config file. Besides adding Identity field into the API, this patch also removes the restriction to receive value for only one field per response. Now both Identity and

[PATCH v2 0/5] EAP login support in Agent API

Hi, This is v2 of the EAP login support patchset. v2: - dropped "eap-" prefix from new Passphrase types, which now are "passphrase" and "response", for EAP passphrases and EAP challenge responses respectively Henri Bragge (5): doc: Add EAP login support in Agent API service: Add function

[PATCH v2 1/5] doc: Add EAP login support in Agent API

--- doc/agent-api.txt | 40 1 files changed, 36 insertions(+), 4 deletions(-) diff --git a/doc/agent-api.txt b/doc/agent-api.txt index 98499a3..c9a0b0f 100644 --- a/doc/agent-api.txt +++ b/doc/agent-api.txt @@ -61,10 +61,15 @@ Fields string

[PATCH v0 6/6] timeserver: Fix memory leak

From: Daniel Wagner Reported by: DJ Cozatt --- src/timeserver.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/src/timeserver.c b/src/timeserver.c index 584be26..3224f47 100644 --- a/src/timeserver.c +++ b/src/timeserver.c @@ -102,6 +102,8 @@ int connman_timeserver_ap

[PATCH v0 5/6] inet: Fix inconsistent use of strdup and g_free

From: Daniel Wagner Reported by: DJ Cozatt --- src/inet.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/inet.c b/src/inet.c index 2f287f6..fa768fb 100644 --- a/src/inet.c +++ b/src/inet.c @@ -459,7 +459,7 @@ struct connman_device *connman_inet_create_device(i

[PATCH v0 4/6] vpn: Fix fd leak

From: Daniel Wagner Reported by: DJ Cozatt --- plugins/vpn.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/plugins/vpn.c b/plugins/vpn.c index b75df05..e028b63 100644 --- a/plugins/vpn.c +++ b/plugins/vpn.c @@ -250,7 +250,9 @@ static int vpn_connect(struct connman_

[PATCH v0 3/6] vpn: Fix possible null pointer dereference

From: Daniel Wagner Reported by: DJ Cozatt --- plugins/vpn.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/plugins/vpn.c b/plugins/vpn.c index 4685b51..b75df05 100644 --- a/plugins/vpn.c +++ b/plugins/vpn.c @@ -106,14 +106,16 @@ void vpn_died(struct connman_task

[PATCH v0 2/6] tist: Fix initializing of variable

From: Daniel Wagner Using sizeof for array given as function argument returns the size of pointer Reported by: DJ Cozatt --- plugins/tist.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/plugins/tist.c b/plugins/tist.c index 28498b6..20a5f55 100644 --- a/plugins/tist

[PATCH v0 1/6] gresolv: Fix memory leak

From: Daniel Wagner Reported by: DJ Cozatt --- gweb/gresolv.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/gweb/gresolv.c b/gweb/gresolv.c index 938aa69..632f0c3 100644 --- a/gweb/gresolv.c +++ b/gweb/gresolv.c @@ -908,8 +908,10 @@ static gint add_query(struct res

[PATCH v0 0/6] cppcheck fixes

From: Daniel Wagner Hi, here a few one liners for fixing bugs reported by DJ Cozatt. The two things not fixed are: [./gsupplicant/supplicant.c:2539]: (error) Possible null pointer dereference: key [./tools/iptables-test.c:1183]: (error) Memory leak: table cheers, daniel Daniel Wagner (6):

[RFC v3 2/2] session: Refactor Session API

From: Daniel Wagner In order to enable session support there is a master switch (EnableSessionMode) on the manager. If enabled all service will disconnected and keept disconnected. Only services which are part of a session will be allowed to connect. The service layer registers itself at the se

[RFC v3 0/2] Session API

From: Daniel Wagner Hi, Another update on this series. cheers, daniel Daniel Wagner (1): session: Refactor Session API Marcel Hotlmann (1): Update session documantion. doc/manager-api.txt | 44 ++- doc/session-api.txt | 240 + include/dbus.h|2 + src/conn

[RFC v3 1/2] Update session documantion.

From: Marcel Hotlmann --- doc/manager-api.txt | 33 doc/session-api.txt | 240 +++ 2 files changed, 257 insertions(+), 16 deletions(-) create mode 100644 doc/session-api.txt diff --git a/doc/manager-api.txt b/doc/manager-api.txt index

Re: [PATCH 6to4 v5 3/9] inet: Add routines to send IPv6 router solicitation message.

Hi Marcel, On 17 March 2011 09:29, Marcel Holtmann wrote: > Hi Jukka, > >> diff --git a/src/inet.c b/src/inet.c >> index 858d34c..40d8a8d 100644 >> --- a/src/inet.c >> +++ b/src/inet.c >> @@ -4,6 +4,10 @@ >>   * >>   *  Copyright (C) 2007-2010  Intel Corporation. All rights reserved. >>   * >> +

Re: Memory Leaks When Using Statistics (was Re: [PATCH 1/1]: Fix Memory-map and Double-free Errors in Statistics Handling (was Re: Connman-0.67 Crashes and/or Hangs on Start-up))

Hi Grant, Finally, I found some time for debugging. 2) Keeping connman in the stack, but changing the mapping from MAP_PRIVATE back to MAP_SHARED such that stats_file_setup fails with -EINVAL (due to being backed by a JFFS2 file system). Okay, that tells us at least if stats.c is not involved

Re: [PATCH 6to4 v5 5/9] 6to4: Add 6to4 tunnel support.

Hi Jukka, > diff --git a/src/6to4.c b/src/6to4.c > new file mode 100644 > index 000..68472e6 > --- /dev/null > +++ b/src/6to4.c > @@ -0,0 +1,498 @@ > +/* > + * > + * Connection Manager > + * > + * Copyright (C) 2011 Nokia Corporation. All rights reserved. > + * > + * Portions copyright by

Re: [PATCH 6to4 v5 3/9] inet: Add routines to send IPv6 router solicitation message.

Hi Jukka, > diff --git a/src/inet.c b/src/inet.c > index 858d34c..40d8a8d 100644 > --- a/src/inet.c > +++ b/src/inet.c > @@ -4,6 +4,10 @@ > * > * Copyright (C) 2007-2010 Intel Corporation. All rights reserved. > * > + * Portions (IPv6 router solicitation handling from MIPL project) are >

[PATCH 6to4 v5 9/9] service: Return 6to4 tunnel status to dbus caller.

--- src/connman.h |3 ++- src/ipconfig.c |9 - src/service.c |3 ++- 3 files changed, 12 insertions(+), 3 deletions(-) diff --git a/src/connman.h b/src/connman.h index a4ebbbe..47f3c89 100644 --- a/src/connman.h +++ b/src/connman.h @@ -247,7 +247,8 @@ void __connman_ipconfig

[PATCH 6to4 v5 8/9] 6to4: Check if the 6to4 tunnel is active or not.

--- src/6to4.c| 20 src/connman.h |1 + 2 files changed, 21 insertions(+), 0 deletions(-) diff --git a/src/6to4.c b/src/6to4.c index 52a0c53..8593e71 100644 --- a/src/6to4.c +++ b/src/6to4.c @@ -541,3 +541,23 @@ void __connman_6to4_remove(struct connman_ipconfig *i

[PATCH 6to4 v5 7/9] service: Create/remove 6to4 tunnel.

--- src/dhcp.c|4 src/service.c |2 ++ 2 files changed, 6 insertions(+), 0 deletions(-) diff --git a/src/dhcp.c b/src/dhcp.c index 6fda67d..dd7c498 100644 --- a/src/dhcp.c +++ b/src/dhcp.c @@ -73,6 +73,8 @@ static void dhcp_invalid(struct connman_dhcp *dhcp) if (ipconfig

[PATCH 6to4 v5 4/9] gweb: Add support for connecting to IPv6 host.

--- gweb/gweb.c | 29 - 1 files changed, 20 insertions(+), 9 deletions(-) diff --git a/gweb/gweb.c b/gweb/gweb.c index f3c8a7e..1bb1c70 100644 --- a/gweb/gweb.c +++ b/gweb/gweb.c @@ -31,6 +31,7 @@ #include #include #include +#include #include "giognutls.h"

[PATCH 6to4 v5 6/9] 6to4: Check the connectivity via tunnel after creating it.

--- src/6to4.c | 47 ++- 1 files changed, 46 insertions(+), 1 deletions(-) diff --git a/src/6to4.c b/src/6to4.c index 68472e6..52a0c53 100644 --- a/src/6to4.c +++ b/src/6to4.c @@ -41,10 +41,15 @@ #include "connman.h" #include #include +#include "

[PATCH 6to4 v5 5/9] 6to4: Add 6to4 tunnel support.

--- Makefile.am |2 +- src/6to4.c| 498 + src/connman.h |3 + 3 files changed, 502 insertions(+), 1 deletions(-) create mode 100644 src/6to4.c diff --git a/Makefile.am b/Makefile.am index 3ad1ee9..95aefc7 100644 --- a/Makefil

[PATCH 6to4 v5 1/9] doc: Add description about 6to4 tunnelling.

--- doc/service-api.txt |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/doc/service-api.txt b/doc/service-api.txt index 65554a2..7e87e6e 100644 --- a/doc/service-api.txt +++ b/doc/service-api.txt @@ -347,12 +347,16 @@ Propertiesstring State [readonly]

[PATCH 6to4 v5 3/9] inet: Add routines to send IPv6 router solicitation message.

--- include/inet.h |8 ++ src/inet.c | 315 2 files changed, 323 insertions(+), 0 deletions(-) diff --git a/include/inet.h b/include/inet.h index 9a9411d..3ed19c4 100644 --- a/include/inet.h +++ b/include/inet.h @@ -25,6 +25,8 @@

[PATCH 6to4 v5 2/9] inet: MTU and tunnel setup functions added.

--- include/inet.h |3 ++ src/inet.c | 71 ++- 2 files changed, 72 insertions(+), 2 deletions(-) diff --git a/include/inet.h b/include/inet.h index 9ba7781..9a9411d 100644 --- a/include/inet.h +++ b/include/inet.h @@ -73,6 +73,9 @@ int

[PATCH 6to4 v5 0/9] 6to4 tunneling support

Hi, this v5 patch sets the IPv6.Method="6to4" if tunnel is active as requested by Marcel. v5: - the 6to4 tunnel status is returned via IPv6.Method (patch #9 reworked) - removed test script modifications (removed patch #10) - doc updated (patch #1 updated) v4: - 6to4 tunnel setting in service