Re: [PATCH 5/5] device: Add command queue.

Hi, samuel > > So we don't restrict the queue size, right? > After thinking about how deep the queue should be, and after reading > Zengguang's email, I realized that this command queue was adding more > complexity than anything else. > If we want to go for simplicity, we should probably just > r

Re: [PATCH] oFono : Fix connection which can't be called in ipv4

Hi Thierry, > I've noticed "connman_network_set_connected" is called at the end of > "set_connected" function, > however if method is ipv4, ipv6 is let to "unknown" and a "return" is done > before calling the function > which does the "ipconfig" of gsm IP address. > Please find the correction

Problem using wwan0 modem

Hi Michael, I have the same problem I guess. I use ofono 0.40 and connman since release 0.64 which was working well. after migration to connman 0.75 I've recently noticed on that ip address is not mounted anymore on my gsm interface after my modem is connected and I have equivalent ifconfig resu

[PATCH] oFono : Fix connection which can't be called in ipv4

Hi, I've noticed "connman_network_set_connected" is called at the end of "set_connected" function, however if method is ipv4, ipv6 is let to "unknown" and a "return" is done before calling the function which does the "ipconfig" of gsm IP address. Please find the correction I suggest as first

Re: [RFC v2] main: Use signalfd instead of plain signals

Hi Daniel, > It's unsafe to call syslog in the terminat signal handler > because syslog takes an lock. So when the signal handler > kicks in and we were already in syslog, we have a nice > deadlock. > --- > Hi, > > okay this is just a shot in the dark. I haven't really tried > to understand all t

Re: [PATCH v1 00/13] Refcounting simplified

Hi Daniel, On Mon, Jun 27, 2011 at 01:52:53PM +0200, Daniel Wagner wrote: > Hi Samuel, > > Thanks for taking the time to review these patches. > > > > The > > > connman_network_register/unregister is gone again. This is not needed > > > anymore because service is not allowed to take a reference

Re: [PATCH 5/5] device: Add command queue.

Hi Samuel, On Tue, Jun 28, 2011 at 3:59 PM, Samuel Ortiz wrote: > Hi Alok, > > On Mon, Jun 27, 2011 at 01:10:59PM +0300, alok barsode wrote: > > Hi Samuel, > > > > just a few things i wanted to clarify. My queries are inline. > > > > On Fri, Jun 24, 2011 at 2:59 AM, Samuel Ortiz > wrote: > > >

Re: [RFC v1] Fix triggering of identity/passphrase query from agent

On Tue, 2011-06-21 at 14:38 +0300, Henri Bragge wrote: > Query identity/passphrase if one of them is empty, rather than > depending on service immutability. Do not cache agent provided > credentials in service struct (ask them every time user wants to > connect). > --- > > Currently identity/passp

[PATCH_v3 2/2] private_network: Update APIs to be able to use multiple private networks

--- src/connman.h |2 +- src/manager.c | 11 src/tethering.c | 70 -- 3 files changed, 48 insertions(+), 35 deletions(-) diff --git a/src/connman.h b/src/connman.h index 0c6d6b1..e4c35da 100644 --- a/src/connman.h +++ b/src/

[PATCH_v3 0/2] Private network APIs update

Hi, Changelog from v2 is: - RequestPrivateNetwork D-Bus method returns oa{sv}h instead of oha{sv} to be more consistent with rest of the code. Thus fd handle is considered as an extra parameter Guillaume Zajac (2): doc: Update private network method prototypes priv

[PATCH_v3 1/2] doc: Update private network method prototypes

--- doc/manager-api.txt | 11 +-- 1 files changed, 5 insertions(+), 6 deletions(-) diff --git a/doc/manager-api.txt b/doc/manager-api.txt index cf26978..961c39b 100644 --- a/doc/manager-api.txt +++ b/doc/manager-api.txt @@ -195,21 +195,20 @@ Methods dict GetProperties()

Re: [PATCH 5/5] device: Add command queue.

Hi Alok, On Mon, Jun 27, 2011 at 01:10:59PM +0300, alok barsode wrote: > Hi Samuel, > > just a few things i wanted to clarify. My queries are inline. > > On Fri, Jun 24, 2011 at 2:59 AM, Samuel Ortiz wrote: > > > Hi Alok, > > > > On Mon, Jun 20, 2011 at 02:06:15PM +0300, Alok Barsode wrote: >

Re: [PATCH_v2 1/2] doc: Update private network method prototypes

Hi Marcel, On 27/06/2011 19:28, Marcel Holtmann wrote: Hi Guillaume, doc/manager-api.txt | 11 +-- 1 files changed, 5 insertions(+), 6 deletions(-) diff --git a/doc/manager-api.txt b/doc/manager-api.txt index cf26978..57b13c9 100644 --- a/doc/manager-api.txt +++ b/doc/manager-api

[RFC v2] main: Use signalfd instead of plain signals

It's unsafe to call syslog in the terminat signal handler because syslog takes an lock. So when the signal handler kicks in and we were already in syslog, we have a nice deadlock. --- Hi, okay this is just a shot in the dark. I haven't really tried to understand all the magic flags. So it's quite

Re: [PATCH 5/5] device: Add command queue.

Hi, sameo > So the main point of this command queue was to cleanly get rid of the > powered_pending stuff. And my idea was the following one: If > the queue is > empty, then we queue the command and we return the > driver->enable return > value. If the queue is not empty, then we just return >