Re: [PATCH v5 14/18] network: Fix double free in network_destruct()

2011-07-26 Thread Daniel Wagner
Hi Marcel, On 07/25/2011 10:45 PM, Marcel Holtmann wrote: Hi Daniel, src/network.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/src/network.c b/src/network.c index 220164a..be72b05 100644 --- a/src/network.c +++ b/src/network.c @@ -331,7 +331,6 @@ static

Re: [PATCH v5 05/18] device: Fix a inbalance of ref/unref of network objects

2011-07-26 Thread Daniel Wagner
Hi Marcel, On 07/26/2011 01:24 AM, Marcel Holtmann wrote: Hi Daniel, The destroy callback of the hash table (device-networks) will unref and unregister the network object. so patch 5-18 have been applied as well. Except patch 14 since that should be done properly. Thanks for taking care

Re: [PATCH v5 14/18] network: Fix double free in network_destruct()

2011-07-26 Thread Marcel Holtmann
Hi Daniel, src/network.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/src/network.c b/src/network.c index 220164a..be72b05 100644 --- a/src/network.c +++ b/src/network.c @@ -331,7 +331,6 @@ static void network_destruct(struct connman_network

[PATCH] network: Set driver pointer to NULL back if not ready

2011-07-26 Thread Daniel Wagner
From: Daniel Wagner daniel.wag...@bmw-carit.de The network_probe() function will be called several times until it creates successfuly the service object. In the case of the oFono plugin, the connman_device_add_network() is called after the driver has been registered to the network. Therefore the

[PATCH dhcp 1/4] service: Remember last DHCP IP address.

2011-07-26 Thread Jukka Rissanen
--- src/connman.h |3 +++ src/service.c | 36 2 files changed, 39 insertions(+), 0 deletions(-) diff --git a/src/connman.h b/src/connman.h index 408b809..e687502 100644 --- a/src/connman.h +++ b/src/connman.h @@ -552,6 +552,9 @@ void

[PATCH dhcp 0/4] Reuse last IP address.

2011-07-26 Thread Jukka Rissanen
Hi, the following patchset fixes the problem in bug #21068 https://bugs.meego.com/show_bug.cgi?id=21068 We suggest the DHCP server to give us the IP address we had last time. This is done by sending the DHCP REQUESTED IP option to server. Regards, Jukka Jukka Rissanen (4): service: Remember

[PATCH dhcp 3/4] tools: Add missing parameter.

2011-07-26 Thread Jukka Rissanen
--- tools/dhcp-test.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tools/dhcp-test.c b/tools/dhcp-test.c index 1fbf1f9..18527c8 100644 --- a/tools/dhcp-test.c +++ b/tools/dhcp-test.c @@ -170,7 +170,7 @@ int main(int argc, char *argv[]) timer = g_timer_new();

[PATCH dhcp 2/4] gdhcp: Enable DHCP REQUESTED IP address option when starting client.

2011-07-26 Thread Jukka Rissanen
--- gdhcp/client.c | 22 ++ gdhcp/gdhcp.h |2 +- 2 files changed, 19 insertions(+), 5 deletions(-) diff --git a/gdhcp/client.c b/gdhcp/client.c index 0cf39cd..9ac7752 100644 --- a/gdhcp/client.c +++ b/gdhcp/client.c @@ -109,6 +109,7 @@ struct _GDHCPClient {

[PATCH dhcp 4/4] dhcp: Try to reuse the IP address we had last time.

2011-07-26 Thread Jukka Rissanen
This fix sends the DHCP_REQUESTED_IP option to server. Fixes BMC #21068 --- src/dhcp.c | 21 - 1 files changed, 20 insertions(+), 1 deletions(-) diff --git a/src/dhcp.c b/src/dhcp.c index 20fc599..0f93b95 100644 --- a/src/dhcp.c +++ b/src/dhcp.c @@ -42,6 +42,7 @@ struct

Re: [PATCH dhcp 1/4] service: Remember last DHCP IP address.

2011-07-26 Thread Daniel Wagner
Hi Jukka On 07/26/2011 01:29 PM, Jukka Rissanen wrote: --- src/connman.h |3 +++ src/service.c | 36 2 files changed, 39 insertions(+), 0 deletions(-) diff --git a/src/connman.h b/src/connman.h index 408b809..e687502 100644 --- a/src/connman.h

Should Connman Receive All Supplicant State Changes?

2011-07-26 Thread Grant Erickson
Is it expected that connman should receive and process all supplicant state changes? If so, I am seeing cases where the supplicant fails to signal or connman misses GROUP_HANDSHAKE always and occasionally ASSOCIATED, 4WAY_HANDSHAKE, and DISCONNECTED as below: 2011-07-26 21:34:22.00