[PATCH v3 17/17] session: Free ifname

2011-08-05 Thread Daniel Wagner
From: Daniel Wagner connman_inet_ifname() returns strdup() string. --- src/session.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/session.c b/src/session.c index bd596f1..fde2799 100644 --- a/src/session.c +++ b/src/session.c @@ -67,7 +67,7 @@ struct service_

[PATCH v3 16/17] session: Insert service_entry into service_list

2011-08-05 Thread Daniel Wagner
From: Daniel Wagner --- src/session.c |7 ++- 1 files changed, 6 insertions(+), 1 deletions(-) diff --git a/src/session.c b/src/session.c index b8ab6a0..bd596f1 100644 --- a/src/session.c +++ b/src/session.c @@ -1574,6 +1574,7 @@ static void service_add(struct connman_service *service,

[PATCH v3 15/17] notify: Add additional parameters to service_add()

2011-08-05 Thread Daniel Wagner
From: Daniel Wagner --- include/notifier.h |4 +++- src/connman.h |4 +++- src/notifier.c |6 -- src/service.c |4 ++-- src/session.c |4 +++- 5 files changed, 15 insertions(+), 7 deletions(-) diff --git a/include/notifier.h b/include/notifier.h index

[PATCH v3 14/17] session: Fix invalid session_hash in cleanup path

2011-08-05 Thread Daniel Wagner
From: Daniel Wagner --- src/session.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/session.c b/src/session.c index 88b6e76..5a95e8d 100644 --- a/src/session.c +++ b/src/session.c @@ -1722,6 +1722,7 @@ void __connman_session_cleanup(void) g_hash_table_for

[PATCH v3 13/17] session: Service changed cleanup

2011-08-05 Thread Daniel Wagner
From: Daniel Wagner --- src/session.c |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/src/session.c b/src/session.c index d26d0a3..88b6e76 100644 --- a/src/session.c +++ b/src/session.c @@ -906,6 +906,14 @@ static void session_changed(struct connman_session *sess

[PATCH v3 12/17] session: Track reason on a session level

2011-08-05 Thread Daniel Wagner
From: Daniel Wagner We need to track the Connect()/Disconnect() on a global session level and not only in the info. This is needed when we were not able to select and connect to a matching service in the first place. It might happen that a valid service is added in time and then we want to use it

[PATCH v3 11/17] session: Disconnect on destroy if needed

2011-08-05 Thread Daniel Wagner
From: Daniel Wagner --- src/session.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/src/session.c b/src/session.c index 51fbbae..aa70208 100644 --- a/src/session.c +++ b/src/session.c @@ -1228,6 +1228,8 @@ static int session_disconnect(struct connman_session *session

[PATCH v3 10/17] session: Move code

2011-08-05 Thread Daniel Wagner
From: Daniel Wagner release_session(), session_disconnect(), owner_disconnect() and destroy_session() have been moved below session_changed. This is a preperation step for the next patch --- src/session.c | 118 1 files changed, 59 insert

[PATCH v3 09/17] session: Split test_and_disconnect()

2011-08-05 Thread Daniel Wagner
From: Daniel Wagner Do split the testing into its own function and also reset the entry member back before we call __connman_service_disconnect(). This is necessary because calling __connman_serivice_disconnect() we can end up beeing called session_changed() before we have updated the entry. ---

[PATCH v3 08/17] session: Change is_connected to is_online

2011-08-05 Thread Daniel Wagner
From: Daniel Wagner --- src/session.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/session.c b/src/session.c index c202997..149b2f2 100644 --- a/src/session.c +++ b/src/session.c @@ -734,7 +734,7 @@ static DBusMessage *destroy_session(DBusConnection *conn

[PATCH v3 07/17] session: Handle configure state

2011-08-05 Thread Daniel Wagner
From: Daniel Wagner --- src/session.c | 24 1 files changed, 24 insertions(+), 0 deletions(-) diff --git a/src/session.c b/src/session.c index f12f0fd..c202997 100644 --- a/src/session.c +++ b/src/session.c @@ -752,6 +752,25 @@ static connman_bool_t is_connected(enum

[PATCH v3 06/17] service: Extend debug message for session refcounting

2011-08-05 Thread Daniel Wagner
From: Daniel Wagner --- src/service.c | 16 +++- 1 files changed, 7 insertions(+), 9 deletions(-) diff --git a/src/service.c b/src/service.c index 3979b53..1b3211b 100644 --- a/src/service.c +++ b/src/service.c @@ -1608,23 +1608,21 @@ GSequence *__connman_service_get_list(struct

[PATCH v3 05/17] service: Wait for pending service disconnect

2011-08-05 Thread Daniel Wagner
From: Daniel Wagner We should only return from the __connman_session_set_mode() when all pending action (__connman_service_disconnect_all()) have been processed. It is not possible to 'know' from the client when the system is idle. --- src/connman.h |4 ++-- src/manager.c |9 ++--- s

[PATCH v3 04/17] unit: Fix connect disconnect test

2011-08-05 Thread Daniel Wagner
From: Daniel Wagner --- unit/test-session.c | 75 ++- 1 files changed, 62 insertions(+), 13 deletions(-) diff --git a/unit/test-session.c b/unit/test-session.c index 3431cea..47704da 100644 --- a/unit/test-session.c +++ b/unit/test-session.c @@

[PATCH v3 03/17] unit: Add manager state callback

2011-08-05 Thread Daniel Wagner
From: Daniel Wagner --- unit/test-connman.h |1 + unit/test-session.c | 33 ++--- unit/utils.c|3 +++ 3 files changed, 34 insertions(+), 3 deletions(-) diff --git a/unit/test-connman.h b/unit/test-connman.h index 0d9da93..5602daa 100644 --- a/unit/t

[PATCH v3 02/17] unit: Add PropertyChanged watch for Manager

2011-08-05 Thread Daniel Wagner
From: Daniel Wagner --- unit/manager-api.c | 73 +++ unit/test-connman.h | 11 +++- unit/utils.c| 61 ++ 3 files changed, 144 insertions(+), 1 deletions(-) diff --git a/unit/manager-api.c

[PATCH v3 01/17] unit: Use D-Bus watch for testing ConnMan running

2011-08-05 Thread Daniel Wagner
From: Daniel Wagner --- unit/test-connman.h |1 + unit/test-session.c | 30 -- unit/utils.c| 11 +++ 3 files changed, 12 insertions(+), 30 deletions(-) diff --git a/unit/test-connman.h b/unit/test-connman.h index f651444..fb9f957 100644 --- a/

[PATCH v3 00/17] Session Bugfixes

2011-08-05 Thread Daniel Wagner
From: Daniel Wagner Hi, this version does not even leak memory! When testing (*) with wifi you will hit bug 22377. With ethernet it works fine. cheers, daniel (*) while true; do ./test-session; done Daniel Wagner (17): unit: Use D-Bus watch for testing ConnMan running unit: Add PropertyC

Re: Query on ConnMan

2011-08-05 Thread Marcel Holtmann
Hi Daniel, > >>> connmand -n -d 2&> log.txt > >> > >> connmand -n -d "*" 2&> log.txt > > > > both -d and -d "*" are actually the same. We fixed that. So you can be > > nice and short ;) > > Are you sure? The first one gives me no DBG output. Only the second form > works for me. And yes, I'm usin

Re: [PATCH v2 00/16] Session Bugfixes

2011-08-05 Thread Daniel Wagner
There will be a v3. The session code leaks memory. ___ connman mailing list connman@connman.net http://lists.connman.net/listinfo/connman

Re: Query on ConnMan

2011-08-05 Thread Daniel Wagner
Hi Marcel, >>> connmand -n -d 2&> log.txt >> >> connmand -n -d "*" 2&> log.txt > > both -d and -d "*" are actually the same. We fixed that. So you can be > nice and short ;) Are you sure? The first one gives me no DBG output. Only the second form works for me. And yes, I'm using the HEAD :) che

[PATCH v2 16/16] session: Insert service_entry into service_list

2011-08-05 Thread Daniel Wagner
From: Daniel Wagner --- src/session.c |7 ++- 1 files changed, 6 insertions(+), 1 deletions(-) diff --git a/src/session.c b/src/session.c index b8ab6a0..bd596f1 100644 --- a/src/session.c +++ b/src/session.c @@ -1574,6 +1574,7 @@ static void service_add(struct connman_service *service,

[PATCH v2 15/16] notify: Add additional parameters to service_add()

2011-08-05 Thread Daniel Wagner
From: Daniel Wagner --- include/notifier.h |4 +++- src/connman.h |4 +++- src/notifier.c |6 -- src/service.c |4 ++-- src/session.c |4 +++- 5 files changed, 15 insertions(+), 7 deletions(-) diff --git a/include/notifier.h b/include/notifier.h index

[PATCH v2 14/16] session: Fix invalid session_hash in cleanup path

2011-08-05 Thread Daniel Wagner
From: Daniel Wagner --- src/session.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/session.c b/src/session.c index 88b6e76..5a95e8d 100644 --- a/src/session.c +++ b/src/session.c @@ -1722,6 +1722,7 @@ void __connman_session_cleanup(void) g_hash_table_for

[PATCH v2 13/16] session: Service changed cleanup

2011-08-05 Thread Daniel Wagner
From: Daniel Wagner --- src/session.c |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/src/session.c b/src/session.c index d26d0a3..88b6e76 100644 --- a/src/session.c +++ b/src/session.c @@ -906,6 +906,14 @@ static void session_changed(struct connman_session *sess

[PATCH v2 11/16] session: Disconnect on destroy if needed

2011-08-05 Thread Daniel Wagner
From: Daniel Wagner --- src/session.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/src/session.c b/src/session.c index 51fbbae..aa70208 100644 --- a/src/session.c +++ b/src/session.c @@ -1228,6 +1228,8 @@ static int session_disconnect(struct connman_session *session

[PATCH v2 12/16] session: Track reason on a session level

2011-08-05 Thread Daniel Wagner
From: Daniel Wagner We need to track the Connect()/Disconnect() on a global session level and not only in the info. This is needed when we were not able to select and connect to a matching service in the first place. It might happen that a valid service is added in time and then we want to use it

[PATCH v2 10/16] session: Move code

2011-08-05 Thread Daniel Wagner
From: Daniel Wagner release_session(), session_disconnect(), owner_disconnect() and destroy_session() have been moved below session_changed. This is a preperation step for the next patch --- src/session.c | 118 1 files changed, 59 insert

[PATCH v2 09/16] session: Split test_and_disconnect()

2011-08-05 Thread Daniel Wagner
From: Daniel Wagner Do split the testing into its own function and also reset the entry member back before we call __connman_service_disconnect(). This is necessary because calling __connman_serivice_disconnect() we can end up beeing called session_changed() before we have updated the entry. ---

[PATCH v2 08/16] session: Change is_connected to is_online

2011-08-05 Thread Daniel Wagner
From: Daniel Wagner --- src/session.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/session.c b/src/session.c index c202997..149b2f2 100644 --- a/src/session.c +++ b/src/session.c @@ -734,7 +734,7 @@ static DBusMessage *destroy_session(DBusConnection *conn

[PATCH v2 06/16] service: Extend debug message for session refcounting

2011-08-05 Thread Daniel Wagner
From: Daniel Wagner --- src/service.c | 16 +++- 1 files changed, 7 insertions(+), 9 deletions(-) diff --git a/src/service.c b/src/service.c index 3979b53..1b3211b 100644 --- a/src/service.c +++ b/src/service.c @@ -1608,23 +1608,21 @@ GSequence *__connman_service_get_list(struct

[PATCH v2 05/16] service: Wait for pending service disconnect

2011-08-05 Thread Daniel Wagner
From: Daniel Wagner We should only return from the __connman_session_set_mode() when all pending action (__connman_service_disconnect_all()) have been processed. It is not possible to 'know' from the client when the system is idle. --- src/connman.h |4 ++-- src/manager.c |9 ++--- s

[PATCH v2 07/16] session: Handle configure state

2011-08-05 Thread Daniel Wagner
From: Daniel Wagner --- src/session.c | 24 1 files changed, 24 insertions(+), 0 deletions(-) diff --git a/src/session.c b/src/session.c index f12f0fd..c202997 100644 --- a/src/session.c +++ b/src/session.c @@ -752,6 +752,25 @@ static connman_bool_t is_connected(enum

[PATCH v2 03/16] unit: Add manager state callback

2011-08-05 Thread Daniel Wagner
From: Daniel Wagner --- unit/test-connman.h |1 + unit/test-session.c | 33 ++--- unit/utils.c|3 +++ 3 files changed, 34 insertions(+), 3 deletions(-) diff --git a/unit/test-connman.h b/unit/test-connman.h index 0d9da93..5602daa 100644 --- a/unit/t

[PATCH v2 04/16] unit: Fix connect disconnect test

2011-08-05 Thread Daniel Wagner
From: Daniel Wagner --- unit/test-session.c | 75 ++- 1 files changed, 62 insertions(+), 13 deletions(-) diff --git a/unit/test-session.c b/unit/test-session.c index 3431cea..47704da 100644 --- a/unit/test-session.c +++ b/unit/test-session.c @@

[PATCH v2 02/16] unit: Add PropertyChanged watch for Manager

2011-08-05 Thread Daniel Wagner
From: Daniel Wagner --- unit/manager-api.c | 73 +++ unit/test-connman.h | 11 +++- unit/utils.c| 61 ++ 3 files changed, 144 insertions(+), 1 deletions(-) diff --git a/unit/manager-api.c

[PATCH v2 01/16] unit: Use D-Bus watch for testing ConnMan running

2011-08-05 Thread Daniel Wagner
From: Daniel Wagner --- unit/test-connman.h |1 + unit/test-session.c | 30 -- unit/utils.c| 11 +++ 3 files changed, 12 insertions(+), 30 deletions(-) diff --git a/unit/test-connman.h b/unit/test-connman.h index f651444..fb9f957 100644 --- a/

[PATCH v2 00/16] Session Bugfixes

2011-08-05 Thread Daniel Wagner
From: Daniel Wagner Hi, With "while true; do ./test-session; done" I found some additional bugs. With all bug fixes applied it is really stable. Though sometimes you might be hit by https://bugs.meego.com/show_bug.cgi?id=22377 cheers, daniel Daniel Wagner (16): unit: Use D-Bus watch for te

Re: Query on ConnMan

2011-08-05 Thread Marcel Holtmann
Hi Daniel, > > connmand -n -d 2&> log.txt > > connmand -n -d "*" 2&> log.txt both -d and -d "*" are actually the same. We fixed that. So you can be nice and short ;) Regards Marcel ___ connman mailing list connman@connman.net http://lists.connman.n

Re: Query on ConnMan

2011-08-05 Thread Daniel Wagner
> connmand -n -d 2&> log.txt connmand -n -d "*" 2&> log.txt ___ connman mailing list connman@connman.net http://lists.connman.net/listinfo/connman

Re: Query on ConnMan

2011-08-05 Thread Daniel Wagner
Hi Somisetty, On 08/05/2011 10:52 AM, Somisetty Sreegowri wrote: > Sorry for the late reply. No worries. > We tested wifi on connman-0.76, but wifi > did not come up. We also tried different versions of the connman > still not able to get the wifi up. That sounds strange. > We somehow suspect

Re: [PATCH_v5] ofono: manage CDMA device into plugin

2011-08-05 Thread Marcel Holtmann
Hi Guillaume, > >> Change log from v4: > >>- Check if modem name is sent by oFono > >>- CDMA modem name is used as network name > >>- Change modem_data property from is_cdma into has_cdma > >> > >> plugins/ofono.c | 156 > >> +-- >

Re: Query on ConnMan

2011-08-05 Thread Somisetty Sreegowri
Hi Somisetty, On 07/28/2011 07:01 AM, Stephan Raue wrote: > Am 28.07.2011 06:57, schrieb M Prema: >> After installing wpa_supplicant-0.7.2(in config file CONFIG_DRIVER_WEXT=y >> is set,after this make and make install is done.wpa_supplicant installed >> successfully) along with connman-0.75, I a

[PATCH] ofono: Improve coding style

2011-08-05 Thread Guillaume Zajac
--- plugins/ofono.c |6 ++ 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/plugins/ofono.c b/plugins/ofono.c index 2bf777d..060cd8e 100644 --- a/plugins/ofono.c +++ b/plugins/ofono.c @@ -1881,10 +1881,8 @@ static gboolean context_changed(DBusConnection *connection,

Re: [PATCH_v5] ofono: manage CDMA device into plugin

2011-08-05 Thread Guillaume Zajac
Hi Marcel, On 04/08/2011 18:46, Marcel Holtmann wrote: Hi Guillaume, Change log from v4: - Check if modem name is sent by oFono - CDMA modem name is used as network name - Change modem_data property from is_cdma into has_cdma plugins/ofono.c | 156 ++