reduce the scope of 'cnt' in plugins/iwmxsdk.c

I suppose I should have all my ducks in a row and be counting these as I have seen others do...will try to implement if these actually get merged. variable-cnt-scope2.patch David J Cozatt 8/8/2011 --- plugins/iwmxsdk.orig +++ plugins/iwmxsdk.c @@ -915,7 +915,6 @@ static void iwmx_sdk_addremo

reduce the scope of 'err' in plugins/loopback.c

More of the same- variable 'err' scope reduced David J Cozatt 8/8/2011 --- plugins/loopback.orig +++ plugins/loopback.c @@ -303,12 +303,12 @@ static int loopback_set_hostname(const char *hostname) { - int err; if (g_strcmp0(hostname,

reduce the scope of 'cnt' in plugins/iwmx.c

This actually worked as intended variable-cnt-scope1.patch David J Cozatt 8/8/2011 --- plugins/iwmx.orig +++ plugins/iwmx.c @@ -125,7 +125,6 @@ struct connman_network *nw = NULL; struct connman_device *dev = wmxsdk->dev; char group[3 * strlen(station_name) + 1]; -

reduce scope of variable 'i' in gsupplicant/supplicant.c

due to PBKAC re-sending after verification that they actually are doing what is intended and one at a time. patches/variable-i-scope.patch reduce the scope of 'i' David J Cozatt 8/8/2011 --- gsupplicant/supplicant.orig +++ gsupplicant/supplicant.c @@ -95

RE: [PATCH v1 00/22] Offline mode patchset

Hi Alok, Below is my understanding, am I correct? + There is only one OfflineMode, which is in Manager interface + When user sets OfflineMode, all technology state are offline + When OfflineMode is true, some technologies can be enabled/connected meanwhile OfflineMode does not chan

reduce variables scope

the following patches are meant to reduce variable scope as suggested by static analysis via cppcheck-1.4.8 because my silly client is word wrapping I will also attach as a squashed plain-text file There are a few more but will see if these are worth adding before doing the other two or three

Re: [PATCH 0/3] Agent API fixes for service.c

Hi Patrik, On Mon, Aug 08, 2011 at 01:43:55PM +0300, patrik.fl...@linux.intel.com wrote: > From: Patrik Flykt > >Hi, > > Noticed that the Agent API does not work as intended, here are three > patches to correct its behavior in service.c. I have one coding style comment about patch #1, t

Re: [PATCH 1/3] service: Correctly set 8021X, WEP and PSK passphrases

Hi Patrik, On Mon, Aug 08, 2011 at 01:43:56PM +0300, patrik.fl...@linux.intel.com wrote: > From: Patrik Flykt > > When returning a passphrase from the Agent API RequestInput method, check > the service security type and set the passphrase accordingly. For WEP and > PSK use __connman_service_set_

Re: [PATCH v3 16/17] session: Insert service_entry into service_list

Hi Daniel, On Fri, Aug 05, 2011 at 06:40:07PM +0200, Daniel Wagner wrote: > From: Daniel Wagner Here as well I think it would make sense to explain why the service pointer is not going to be enough any more. Cheers, Samuel. -- Intel Open Source Technology Centre http://oss.intel.com/ _

Re: [PATCH v3 15/17] notify: Add additional parameters to service_add()

Hi Daniel, On Fri, Aug 05, 2011 at 06:40:06PM +0200, Daniel Wagner wrote: > From: Daniel Wagner > > --- > include/notifier.h |4 +++- > src/connman.h |4 +++- > src/notifier.c |6 -- > src/service.c |4 ++-- > src/session.c |4 +++- > 5 files changed,

Re: [PATCH v3 13/17] session: Service changed cleanup

Hi Daniel, On Fri, Aug 05, 2011 at 06:40:04PM +0200, Daniel Wagner wrote: > From: Daniel Wagner > > --- > src/session.c |8 > 1 files changed, 8 insertions(+), 0 deletions(-) > > diff --git a/src/session.c b/src/session.c > index d26d0a3..88b6e76 100644 > --- a/src/session.c > +++

Re: [PATCH v3 08/17] session: Change is_connected to is_online

Hi Daniel, On Fri, Aug 05, 2011 at 06:39:59PM +0200, Daniel Wagner wrote: > @@ -760,10 +760,10 @@ static connman_bool_t is_connecting(enum > connman_service_state state) > break; > case CONNMAN_SERVICE_STATE_ASSOCIATION: > case CONNMAN_SERVICE_STATE_CONFIGURATION: > +

Re: [PATCH v3 07/17] session: Handle configure state

Hi Daniel, On Fri, Aug 05, 2011 at 06:39:58PM +0200, Daniel Wagner wrote: > From: Daniel Wagner Some additional change logs would be appreciated here. It would be worth explaining why we're returning from session_changed when the service is connecting. Cheers, Samuel. > --- > src/session.c |

Re: [PATCH v3 05/17] service: Wait for pending service disconnect

Hi Daniel, On Fri, Aug 05, 2011 at 06:39:56PM +0200, Daniel Wagner wrote: > From: Daniel Wagner > > We should only return from the __connman_session_set_mode() when > all pending action (__connman_service_disconnect_all()) have been > processed. It is not possible to 'know' from the client when

Re: [PATCH] TODO: EAP-GTC support done, EAP-FAST not making progress

Hi Henri, On Mon, Aug 01, 2011 at 10:42:51AM +0300, Henri Bragge wrote: > --- > > EAP-GTC can now be configured as a phase2-method and responses > (passphrases) can be provided via agent API. > > EAP-FAST is not supported by MeeGo wpa_supplicant (though it's only > one .config change away), and

Re: Query on ConnMan

Hi Somisetty, On 08/05/2011 10:52 AM, Somisetty Sreegowri wrote: > Sorry for the late reply. No worries. > We tested wifi on connman-0.76, but wifi > did not come up. We also tried different versions of the connman > still not able to get the wifi up. That sounds strange. > We somehow suspect

[PATCH v1 22/22] storage: remove storage module framework.

From: Alok Barsode --- Makefile.am |3 +- include/storage.h | 58 -- src/connman.h |8 - src/main.c|2 - src/storage.c | 89 - 5 files changed, 1 insertions(+), 159 delet

[PATCH v1 20/22] storage: Remove technology state load/save methods from storage module.

From: Alok Barsode --- include/storage.h |2 - src/connman.h |2 - src/storage.c | 36 -- src/technology.c | 133 + 4 files changed, 62 insertions(+), 111 deletions(-) diff --git a/include/storage.h b/include/st

[PATCH v1 21/22] service: Directly use service load/save functions.

From: Alok Barsode --- src/service.c | 798 - 1 files changed, 393 insertions(+), 405 deletions(-) diff --git a/src/service.c b/src/service.c index cb6715e..90e11e8 100644 --- a/src/service.c +++ b/src/service.c @@ -297,6 +297,384 @@ stat

[PATCH v1 19/22] test: Change path for services.

From: Alok Barsode Since profile support was removed, the service path changes from /profile/default to /net/connman/service/. --- test/set-domains |2 +- test/set-ipv4-method |2 +- test/set-ipv6-method |2 +- test/set-nameservers |2 +- test/set-proxy |2 +- test/

[PATCH v1 18/22] test: Remove profile tests.

From: Alok Barsode --- test/list-profiles | 34 - test/test-profile | 102 2 files changed, 0 insertions(+), 136 deletions(-) delete mode 100755 test/list-profiles delete mode 100755 test/test-profile diff --git a/test/l

[PATCH v1 06/22] technology: Remove the global device hash.

From: Alok Barsode There is a device list per technology. Hence removing the global device hash. --- src/technology.c | 19 +-- 1 files changed, 1 insertions(+), 18 deletions(-) diff --git a/src/technology.c b/src/technology.c index daf0eb3..8ece871 100644 --- a/src/technology

[PATCH v1 17/22] profile: Remove profile.c and profile.h.

From: Alok Barsode --- Makefile.am |4 +- include/profile.h | 41 -- include/storage.h |4 - src/connman.h | 21 - src/main.c|4 - src/profile.c | 218 - src/service.c | 16 ++--- src/sto

[PATCH v1 16/22] service: Add services changed signal.

From: Alok Barsode Move the services changed dbus signal handling from profile. --- src/notifier.c |2 -- src/profile.c | 39 --- src/service.c | 51 --- 3 files changed, 44 insertions(+), 48 deletions(

[PATCH v1 14/22] device: Remove device persistent code.

From: Alok Barsode Connman now stores technology states persistently. Hence there is no reason to store device states persistently. --- include/storage.h |3 -- src/connman.h |4 -- src/device.c | 99 + src/storage.c |

[PATCH v1 15/22] technology: Save/Load offlinemode.

From: Alok Barsode Load/Save offlinemode in technology.c instead of profile.c. --- src/connman.h|1 + src/manager.c| 13 + src/technology.c | 78 +++-- 3 files changed, 65 insertions(+), 27 deletions(-) diff --git a/src/con

[PATCH v1 13/22] device: remove caching of offlinemode in device structure.

From: Alok Barsode --- src/device.c |6 -- 1 files changed, 0 insertions(+), 6 deletions(-) diff --git a/src/device.c b/src/device.c index 5d11ee0..313c129 100644 --- a/src/device.c +++ b/src/device.c @@ -43,7 +43,6 @@ struct connman_device { enum connman_device_type type;

[PATCH v1 12/22] technology/device: remove blocked variables and associated functions.

From: Alok Barsode Rely on global offline status instead of caching them in technology and device structs. --- src/connman.h|5 -- src/device.c | 65 ++ src/profile.c|9 src/technology.c | 135 ---

[PATCH v1 11/22] rfkill: Add technology soft blocking API.

From: Alok Barsode --- src/connman.h | 11 ++- src/rfkill.c | 56 2 files changed, 62 insertions(+), 5 deletions(-) diff --git a/src/connman.h b/src/connman.h index 1a5f70a..2730f72 100644 --- a/src/connman.h +++ b/src/connma

[PATCH v1 10/22] technology: Fix enable notifier to be invoked just once.

From: Alok Barsode When there are multiple devices, the technology enable notifier was invoked multiple times. But when disabling the technology, the disable notifier was invoked just once, hence there was a mismatch in the technology states. --- src/technology.c |3 +-- 1 files changed, 1 i

[PATCH v1 09/22] technology: Remove 'available' state.

From: Alok Barsode The connman technology state machine is simplified. It now has 3 states: Offline: Technology is disabled. Enabled: Technology is enabled. Connected: Technology is connected. --- doc/technology-api.txt |3 +-- src/technology.c | 21 + 2 files cha

[PATCH v1 08/22] technology: Redo offlinemode logic.

From: Alok Barsode Traverse the list of technologies and enable/disable each instead of traversing the device list. --- src/connman.h|5 ++--- src/device.c | 43 --- src/manager.c|4 +--- src/profile.c|6 +- src/technology

[PATCH v1 07/22] technology: save state persistently.

From: Alok Barsode Save the technology state persistently. This will help in resuming the technology state after offlinemode or during startup. This patch just saves the states. --- include/storage.h |3 ++ src/connman.h |2 + src/storage.c | 36 + src/techn

[PATCH v1 05/22] technology: Remove global rfkill table.

From: Alok Barsode Remove the global rfkill_table and maintain a per technology rfkill table. --- src/connman.h|4 +++- src/rfkill.c |9 + src/technology.c | 16 +--- 3 files changed, 13 insertions(+), 16 deletions(-) diff --git a/src/connman.h b/src/connma

[PATCH v1 03/22] device: redo pending power request logic.

From: Alok Barsode Use 3 values(None/Enable/Disable) for the power_pending. It helps keep track of the ongoing pending request. Add a pending timeout. If the daemon handling the device fails to send a response then we need to reset the power_pending flag. --- src/device.c | 151

[PATCH v1 04/22] technology: Modify technology enable/disable APIs.

From: Alok Barsode Add the pending dbus message per technology. Also move the pending timeout from manager to technology. --- src/connman.h|4 +- src/manager.c| 94 +- src/technology.c | 121 --

[PATCH v1 02/22] device: update profile in enable_persistent callback.

From: Alok Barsode --- src/device.c | 14 +- src/technology.c |5 + 2 files changed, 6 insertions(+), 13 deletions(-) diff --git a/src/device.c b/src/device.c index e4603cc..61945d4 100644 --- a/src/device.c +++ b/src/device.c @@ -740,25 +740,13 @@ int __connman_device

[PATCH v1 00/22] Offline mode patchset

From: Alok Barsode The following set of patches implement the offlinemode along with some core changes. The "available" state for technology is removed. I now maintain technology states rather than per device states. The support for profile is completely removed and offline is now integrated in t

[PATCH v1 01/22] technology: Refactor enable/disable APIs.

From: Alok Barsode connman_technology_enable: Enable a technology. Enables all the devices in the device_list of the technology. connman_technology_enabled: Callback for connman_technology_enable. Changes the state of the technology to ENABLED. Ditto for connman_technology_disable/connman_technol

[PATCH 3/3] service: Fix calling Agent API request input function

From: Patrik Flykt Requesting passphrases from the user has been done only when the ConnectService D-Bus method has been called. As user input may be needed every time a service is connected, input requesting moved to __connman_service_connect() instead. Also to note is that the same service can

[PATCH 2/3] service: When indicating error, also indicate IPv6 state as failed

From: Patrik Flykt Set IPv6 ipconfig state to failure in __connman_service_indicate_error(). The return value of the function isn't used for any practical purposes, therefore always return 0. --- src/service.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/src/serv

[PATCH 0/3] Agent API fixes for service.c

From: Patrik Flykt Hi, Noticed that the Agent API does not work as intended, here are three patches to correct its behavior in service.c. Interaction with Agent API should go like this: 1) test/connect-service "wrong password" psk 2) receive 'ReportError', reply with retry 3) receive

[PATCH 1/3] service: Correctly set 8021X, WEP and PSK passphrases

From: Patrik Flykt When returning a passphrase from the Agent API RequestInput method, check the service security type and set the passphrase accordingly. For WEP and PSK use __connman_service_set_passphrase() and for 8021X use __connman_service_set_agent_passphrase(). Print a debug message if th

[PATCH] Bug fixing: fix reconnect hidden wifi service failed issue

From: Zhang Zhengguang --- src/network.c | 13 + src/service.c |7 --- 2 files changed, 5 insertions(+), 15 deletions(-) diff --git a/src/network.c b/src/network.c index b2177db..7690112 100644 --- a/src/network.c +++ b/src/network.c @@ -30,7 +30,6 @@ static GSList *net

Re: [PATCH] Bug fixing: fix reconnect hidden wifi service failed issue

Hi, Daniel > > I am not sure if this is what you want to do. In > connman_network_create > we do following: > > struct connman_network *connman_network_create(const char *identifier, > enum > connman_network_type type) > { > [...] > if (identi

Re:Query on connman

Hi Somisetty, On 08/05/2011 10:52 AM, Somisetty Sreegowri wrote: > Sorry for the late reply. No worries. > We tested wifi on connman-0.76, but wifi > did not come up. We also tried different versions of the connman > still not able to get the wifi up. That sounds strange. > We somehow suspec