Re: [PATCH service move 6/6] connection: Default gateway is changed when reorganizing services.

On Thu, 2011-08-18 at 11:21 +0300, Jukka Rissanen wrote: + if (active_gateway active_gateway != default_gateway) { updated = TRUE; + if (active_gateway) { This latter check is unnecessary, it's already checked above. Cheers, Patrik

Re: [PATCH service move 4/6] service: Prefer online state over ready when comparing services.

On Thu, 2011-08-18 at 11:21 +0300, Jukka Rissanen wrote: + gboolean a_connected = is_connected(service_a), + b_connected = is_connected(service_b); I don't know what the coding style says, but I'd prefer 'gboolean b_connected' instead of the comma. Cheers,

[PATCH 0/3] Manual addresses bug #17738 fixes

From: Patrik Flykt patrik.fl...@linux.intel.com Hi, Here's a fix for bug #17738. The bug was that after disconnecting a service with static IP addresses was never able to be reconnected again. Two things causing this was found: - When disconnecting, the ipconfig information is zeroed out.

[PATCH 1/3] service: Factor out reading ipconfigs from create functions

From: Patrik Flykt patrik.fl...@linux.intel.com Create new read functions for IPv4 and IPv6 from the code in __connman_service_create_ip*config functions. --- src/connman.h |3 ++- src/service.c | 54 +- 2 files changed, 35 insertions(+),

[PATCH 2/3] network: Re-read ipconfig from service when setting manual addresses

From: Patrik Flykt patrik.fl...@linux.intel.com When a service was disconnected, its ipconfig data was cleared. Re-read service ipconfig data before setting manual addresses. --- src/network.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/src/network.c

[PATCH 3/3] service: Save ipconfig in states where ipconfig is set up

From: Patrik Flykt patrik.fl...@linux.intel.com Service states unknown, idle and association do not have valid ipconfig data configured. Do not save it in these states. --- src/service.c | 27 --- 1 files changed, 20 insertions(+), 7 deletions(-) diff --git

Testing of Sessions for connman version 0.76

Hello all, Issue : Testing of Sessions using python script test-session for Connman version 0.76. Environment : 1. Fedora14,kernel version:2.6.35 2. dbus-daemon-1.4.0 While running the ./test-session script, i got the output as : [root@localhost test]# ./test-session Usage: ./test-session

Re: Testing of Sessions for connman version 0.76

Hi Hemant, On 08/22/2011 02:09 PM, Hemant Chauhan wrote: [root@localhost test]# ./test-session disable [root@localhost test]# ifconfig eth0 Link encap:Ethernet HWaddr 00:14:22:45:BD:5B inet6 addr: fe80::214:22ff:fe45:bd5b/64 Scope:Link UP BROADCAST RUNNING

[PATCH v0 0/9] Session Bugfixes

From: Daniel Wagner daniel.wag...@bmw-carit.de Hi, While preparing a demo for the LinuxCon talk I had to fix a few bugs. For this demo I have written a simple PyQt application[1]. As it turned out, I saw several things going wrong with this UI. The attached patches fixed the major ones. But

[PATCH v0 1/9] session: Initialize service hash correctly

From: Daniel Wagner daniel.wag...@bmw-carit.de --- src/session.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/session.c b/src/session.c index 9fecf81..3086b2f 100644 --- a/src/session.c +++ b/src/session.c @@ -1435,7 +1435,7 @@ int

[PATCH v0 4/9] session: Handle service trigger according the reason code.

From: Daniel Wagner daniel.wag...@bmw-carit.de Instead of trying to figure out what we are supposed to do we just rely on the reason code. --- src/session.c | 54 +++--- 1 files changed, 27 insertions(+), 27 deletions(-) diff --git

[PATCH v0 5/9] session: Don't change ref count if reason code is set.

From: Daniel Wagner daniel.wag...@bmw-carit.de If the reason code has been set the proper action has been executed already. --- src/session.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/src/session.c b/src/session.c index 1baf059..f0b6a20 100644 ---

[PATCH v0 8/9] session: Update reason code on disconnect

From: Daniel Wagner daniel.wag...@bmw-carit.de --- src/session.c | 14 +- 1 files changed, 9 insertions(+), 5 deletions(-) diff --git a/src/session.c b/src/session.c index 07d4ef3..7037cec 100644 --- a/src/session.c +++ b/src/session.c @@ -756,26 +756,30 @@ static connman_bool_t

[PATCH v0 9/9] session: Defer connect/disconnect calls

From: Daniel Wagner daniel.wag...@bmw-carit.de When we call connect and disconnect a service we might reenter the session state machine. So we should defer these calls and finishing up the state change first. --- src/session.c | 39 --- 1 files changed, 28