[PATCH 0/2] device and wifi cleanup

2011-08-24 Thread Jukka Rissanen
Hi, attached patches do minor cleanup for device.c and wifi.c Regards, Jukka Jukka Rissanen (2): device: Device scan function made private. wifi: Remove not used code. plugins/wifi.c | 14 -- src/connman.h |1 - src/device.c |4 ++-- 3 files changed, 2 insertions(

[PATCH 1/2] device: Device scan function made private.

2011-08-24 Thread Jukka Rissanen
The __connman_device_scan() is now static as it is only called from device.c --- src/connman.h |1 - src/device.c |4 ++-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/src/connman.h b/src/connman.h index 17add6d..9ed9d24 100644 --- a/src/connman.h +++ b/src/connman.h @@

[PATCH 2/2] wifi: Remove not used code.

2011-08-24 Thread Jukka Rissanen
--- plugins/wifi.c | 14 -- 1 files changed, 0 insertions(+), 14 deletions(-) diff --git a/plugins/wifi.c b/plugins/wifi.c index 469ec67..f3ea836 100644 --- a/plugins/wifi.c +++ b/plugins/wifi.c @@ -764,26 +764,12 @@ static void interface_removed(GSupplicantInterface *interface)

[PATCH service move v2 1/6] service: Ignore ipconfig that is not active when moving service.

2011-08-24 Thread Jukka Rissanen
--- src/service.c | 49 + 1 files changed, 45 insertions(+), 4 deletions(-) diff --git a/src/service.c b/src/service.c index fc90934..b8f1c70 100644 --- a/src/service.c +++ b/src/service.c @@ -2920,6 +2920,8 @@ static DBusMessage *move_service(DBu

[PATCH service move v2 0/6] Fix moving services

2011-08-24 Thread Jukka Rissanen
Hi, This v2 fixes style issue in service.c (patch #4) and unnecessary pointer check in connection.c (patch #6). This patchset fixes the https://bugs.meego.com/show_bug.cgi?id=22540 and allows connected services to be moved around. When moving connected services, the default route is also properly

[PATCH service move v2 3/6] service: Allow state downgrade from online to ready.

2011-08-24 Thread Jukka Rissanen
--- src/connman.h |1 + src/service.c | 19 +++ 2 files changed, 20 insertions(+), 0 deletions(-) diff --git a/src/connman.h b/src/connman.h index 17add6d..d74e653 100644 --- a/src/connman.h +++ b/src/connman.h @@ -560,6 +560,7 @@ void __connman_service_notify(struct connman

[PATCH service move v2 4/6] service: Prefer online state over ready when comparing services.

2011-08-24 Thread Jukka Rissanen
--- src/service.c | 16 ++-- 1 files changed, 14 insertions(+), 2 deletions(-) diff --git a/src/service.c b/src/service.c index 0380dbe..4ab3750 100644 --- a/src/service.c +++ b/src/service.c @@ -3297,9 +3297,21 @@ static gint service_compare(gconstpointer a, gconstpointer b,

[PATCH service move v2 5/6] test: Script for testing service.MoveBefore interface.

2011-08-24 Thread Jukka Rissanen
--- test/service-move-before | 27 +++ 1 files changed, 27 insertions(+), 0 deletions(-) create mode 100755 test/service-move-before diff --git a/test/service-move-before b/test/service-move-before new file mode 100755 index 000..f1fddd1 --- /dev/null +++ b/test/ser

[PATCH service move v2 2/6] service: Allow ready service to be moved before online one.

2011-08-24 Thread Jukka Rissanen
--- src/service.c | 28 1 files changed, 24 insertions(+), 4 deletions(-) diff --git a/src/service.c b/src/service.c index b8f1c70..2819d51 100644 --- a/src/service.c +++ b/src/service.c @@ -2912,6 +2912,22 @@ static DBusMessage *remove_service(DBusConnection *conn,

[PATCH service move v2 6/6] connection: Default gateway is changed when reorganizing services.

2011-08-24 Thread Jukka Rissanen
Fixes BMC#22540 --- src/connection.c | 90 - 1 files changed, 88 insertions(+), 2 deletions(-) diff --git a/src/connection.c b/src/connection.c index 84e3ab4..3a6a116 100644 --- a/src/connection.c +++ b/src/connection.c @@ -326,6 +326,70 @@ do

Re: [PATCH service move v2 0/6] Fix moving services

2011-08-24 Thread Samuel Ortiz
Hi Jukka, On Wed, Aug 24, 2011 at 11:36:37AM +0300, Jukka Rissanen wrote: > Hi, > > This v2 fixes style issue in service.c (patch #4) and > unnecessary pointer check in connection.c (patch #6). > > This patchset fixes the https://bugs.meego.com/show_bug.cgi?id=22540 > and allows connected servic

Re: [PATCH] pacrunner: libproxy: supports various SOCKS proxies

2011-08-24 Thread Alban Crequy
Le Tue, 23 Aug 2011 18:32:20 +0200, Samuel Ortiz a écrit : > Hi Alban, > > On Wed, Aug 17, 2011 at 04:41:38PM +0100, Alban Crequy wrote: > > @@ -77,12 +77,12 @@ static char **extract_result(const char *str) > > result[0] = NULL; > > result[1] = NULL; > > > > - if (strcmp(str, "DIRECT

[PATCH] pacrunner: libproxy: supports SOCKS proxies

2011-08-24 Thread Alban Crequy
--- libproxy/proxy.c |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/libproxy/proxy.c b/libproxy/proxy.c index 641e791..62da824 100644 --- a/libproxy/proxy.c +++ b/libproxy/proxy.c @@ -90,6 +90,14 @@ static char **extract_result(const char *str) retu

Re: [PATCH] pacrunner: libproxy: supports various SOCKS proxies

2011-08-24 Thread Samuel Ortiz
Hi Alban, On Wed, Aug 24, 2011 at 01:15:15PM +0100, Alban Crequy wrote: > Le Tue, 23 Aug 2011 18:32:20 +0200, > Samuel Ortiz a écrit : > > > Hi Alban, > > > > On Wed, Aug 17, 2011 at 04:41:38PM +0100, Alban Crequy wrote: > > > @@ -77,12 +77,12 @@ static char **extract_result(const char *str) >

[PATCH v2 01/24] technology: Refactor enable/disable APIs.

2011-08-24 Thread Alok Barsode
From: Alok Barsode connman_technology_enable: Enable a technology. Enables all the devices in the device_list of the technology. connman_technology_enabled: Callback for connman_technology_enable. Changes the state of the technology to ENABLED. Ditto for connman_technology_disable/connman_technol

[PATCH v2 02/24] device: update profile in enable_persistent callback.

2011-08-24 Thread Alok Barsode
From: Alok Barsode --- src/device.c | 14 +- src/technology.c |5 + 2 files changed, 6 insertions(+), 13 deletions(-) diff --git a/src/device.c b/src/device.c index e4603cc..61945d4 100644 --- a/src/device.c +++ b/src/device.c @@ -740,25 +740,13 @@ int __connman_device

[PATCH v2 04/24] technology: Modify technology enable/disable APIs.

2011-08-24 Thread Alok Barsode
From: Alok Barsode Add the pending dbus message per technology. Also move the pending timeout from manager to technology. --- src/connman.h|4 +- src/manager.c| 88 ++ src/technology.c | 113 +++---

[PATCH v2 03/24] device: redo pending power request logic.

2011-08-24 Thread Alok Barsode
From: Alok Barsode Use 3 values(None/Enable/Disable) for the power_pending. It helps keep track of the ongoing pending request. Add a pending timeout. If the daemon handling the device fails to send a response then we need to reset the power_pending flag. --- src/device.c | 149

[PATCH v2 05/24] technology: Remove global rfkill table.

2011-08-24 Thread Alok Barsode
From: Alok Barsode Remove the global rfkill_table and maintain a per technology rfkill table. --- src/connman.h|4 +++- src/rfkill.c |9 + src/technology.c | 16 +--- 3 files changed, 13 insertions(+), 16 deletions(-) diff --git a/src/connman.h b/src/connma

[PATCH v2 06/24] technology: Remove the global device hash.

2011-08-24 Thread Alok Barsode
From: Alok Barsode There is a device list per technology. Hence removing the global device hash. --- src/technology.c | 19 +-- 1 files changed, 1 insertions(+), 18 deletions(-) diff --git a/src/technology.c b/src/technology.c index 849d72a..eee4981 100644 --- a/src/technology

[PATCH v2 07/24] technology: save state persistently.

2011-08-24 Thread Alok Barsode
From: Alok Barsode Save the technology state persistently. This will help in resuming the technology state after offlinemode or during startup. This patch just saves the states. --- include/storage.h |3 ++ src/connman.h |2 + src/storage.c | 36 + src/techn

[PATCH v2 09/24] technology: Remove 'available' state.

2011-08-24 Thread Alok Barsode
From: Alok Barsode The connman technology state machine is simplified. It now has 3 states: Offline: Technology is disabled. Enabled: Technology is enabled. Connected: Technology is connected. --- doc/technology-api.txt |3 +-- src/technology.c | 21 + 2 files cha

[PATCH v2 08/24] technology: Redo offlinemode logic.

2011-08-24 Thread Alok Barsode
From: Alok Barsode Traverse the list of technologies and enable/disable each instead of traversing the device list. --- src/connman.h|5 ++--- src/device.c | 43 --- src/manager.c|4 +--- src/profile.c|6 +- src/technology

[PATCH v2 11/24] rfkill: Add technology soft blocking API.

2011-08-24 Thread Alok Barsode
From: Alok Barsode --- src/connman.h | 11 ++- src/rfkill.c | 56 2 files changed, 62 insertions(+), 5 deletions(-) diff --git a/src/connman.h b/src/connman.h index 884463e..5e4db20 100644 --- a/src/connman.h +++ b/src/connma

[PATCH v2 10/24] technology: Fix enable notifier to be invoked just once.

2011-08-24 Thread Alok Barsode
From: Alok Barsode When there are multiple devices, the technology enable notifier was invoked multiple times. But when disabling the technology, the disable notifier was invoked just once, hence there was a mismatch in the technology states. --- src/technology.c |3 +-- 1 files changed, 1 i

[PATCH v2 12/24] technology/device: remove blocked variables and associated functions.

2011-08-24 Thread Alok Barsode
From: Alok Barsode Rely on global offline status instead of caching them in technology and device structs. --- src/connman.h|5 -- src/device.c | 65 ++ src/profile.c|9 src/technology.c | 135 ---

[PATCH v2 14/24] device: Remove device persistent code.

2011-08-24 Thread Alok Barsode
From: Alok Barsode Connman now stores technology states persistently. Hence there is no reason to store device states persistently. --- include/storage.h |3 -- src/connman.h |4 -- src/device.c | 99 + src/storage.c |

[PATCH v2 13/24] device: remove caching of offlinemode in device structure.

2011-08-24 Thread Alok Barsode
From: Alok Barsode --- src/device.c |6 -- 1 files changed, 0 insertions(+), 6 deletions(-) diff --git a/src/device.c b/src/device.c index 92341d4..12ebfa8 100644 --- a/src/device.c +++ b/src/device.c @@ -43,7 +43,6 @@ struct connman_device { enum connman_device_type type;

[PATCH v2 17/24] profile: Remove profile.c and profile.h.

2011-08-24 Thread Alok Barsode
From: Alok Barsode --- Makefile.am |4 +- include/profile.h | 41 -- include/storage.h |4 - src/connman.h | 21 - src/main.c|4 - src/profile.c | 218 - src/service.c | 16 ++--- src/sto

[PATCH v2 15/24] technology: Save/Load offlinemode.

2011-08-24 Thread Alok Barsode
From: Alok Barsode Load/Save offlinemode in technology.c instead of profile.c. --- src/connman.h|1 + src/manager.c| 13 + src/technology.c | 78 +++-- 3 files changed, 65 insertions(+), 27 deletions(-) diff --git a/src/con

[PATCH v2 16/24] service: Add services changed signal.

2011-08-24 Thread Alok Barsode
From: Alok Barsode Move the services changed dbus signal handling from profile. --- src/notifier.c |2 -- src/profile.c | 39 --- src/service.c | 51 --- 3 files changed, 44 insertions(+), 48 deletions(

[PATCH v2 18/24] test: Change path for services.

2011-08-24 Thread Alok Barsode
From: Alok Barsode Since profile support was removed, the service path changes from /profile/default to /net/connman/service/. --- test/set-domains |2 +- test/set-ipv4-method |2 +- test/set-ipv6-method |2 +- test/set-nameservers |2 +- test/set-proxy |2 +- test/

[PATCH v2 21/24] storage: remove storage module framework.

2011-08-24 Thread Alok Barsode
From: Alok Barsode --- Makefile.am |3 +- include/storage.h | 58 -- src/connman.h |8 - src/main.c|2 - src/storage.c | 89 - 5 files changed, 1 insertions(+), 159 delet

[PATCH v2 19/24] storage: Remove technology state load/save methods from storage module.

2011-08-24 Thread Alok Barsode
From: Alok Barsode --- include/storage.h |2 - src/connman.h |2 - src/storage.c | 36 -- src/technology.c | 133 + 4 files changed, 62 insertions(+), 111 deletions(-) diff --git a/include/storage.h b/include/st

[PATCH v2 20/24] service: Directly use service load/save functions.

2011-08-24 Thread Alok Barsode
From: Alok Barsode --- src/service.c | 823 +++-- 1 files changed, 395 insertions(+), 428 deletions(-) diff --git a/src/service.c b/src/service.c index ba0a2d9..0a890d9 100644 --- a/src/service.c +++ b/src/service.c @@ -297,6 +297,384 @@ stat

[PATCH fast connect 0/9] Fast connect resend

2011-08-24 Thread Jukka Rissanen
Hi, here is the fast connect patches sent again. The patches consists of Mohamed's original patches + some fixes to make the fast connect work properly. The patches also require supplicant changes (patch sent to supplicant mailing list 23 Aug). Jukka Jukka Rissanen (4): gsupplicant: Fix the s

[PATCH fast connect 1/9] service: Add frequency support to service.

2011-08-24 Thread Jukka Rissanen
From: Mohamed Abbas Get the frequncy of gsupplicant network on connman network creation, and always save the frequency of the wifi service. --- gsupplicant/gsupplicant.h |1 + gsupplicant/supplicant.c | 10 ++ plugins/wifi.c|3 +++ src/service.c |5

[PATCH fast connect 3/9] gsupplicant: Add support to append char ** entries to dbus dict.

2011-08-24 Thread Jukka Rissanen
From: Mohamed Abbas --- gsupplicant/dbus.c | 29 + gsupplicant/dbus.h | 20 2 files changed, 49 insertions(+), 0 deletions(-) diff --git a/gsupplicant/dbus.c b/gsupplicant/dbus.c index e014265..e48343c 100644 --- a/gsupplicant/dbus.c +++ b/gs

[PATCH fast connect 2/9] wifi: Add support to multi scan type.

2011-08-24 Thread Jukka Rissanen
From: Mohamed Abbas Allow multi scan type for fast connect. --- include/device.h |1 + plugins/wifi.c | 21 - src/device.c |4 +++- 3 files changed, 24 insertions(+), 2 deletions(-) diff --git a/include/device.h b/include/device.h index d4f54ec..3749a20 10064

[PATCH fast connect 4/9] gsupplicant: Get the number of scan ssids from supplicant.

2011-08-24 Thread Jukka Rissanen
From: Mohamed Abbas --- gsupplicant/gsupplicant.h |2 ++ gsupplicant/supplicant.c | 18 +- 2 files changed, 19 insertions(+), 1 deletions(-) diff --git a/gsupplicant/gsupplicant.h b/gsupplicant/gsupplicant.h index a634141..5f7adc0 100644 --- a/gsupplicant/gsupplicant.h ++

[PATCH fast connect 6/9] gsupplicant: Fix the ssid array.

2011-08-24 Thread Jukka Rissanen
--- gsupplicant/gsupplicant.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/gsupplicant/gsupplicant.h b/gsupplicant/gsupplicant.h index 059837f..93e1c8e 100644 --- a/gsupplicant/gsupplicant.h +++ b/gsupplicant/gsupplicant.h @@ -135,7 +135,7 @@ typedef struct _GSupplican

[PATCH fast connect 5/9] wifi: Add SSIDs and frequencies to wpa_supplicant scan for fast scan.

2011-08-24 Thread Jukka Rissanen
From: Mohamed Abbas --- gsupplicant/gsupplicant.h | 16 gsupplicant/supplicant.c | 134 ++-- plugins/wifi.c| 217 - 3 files changed, 357 insertions(+), 10 deletions(-) diff --git a/gsupplicant/gsupplicant.

[PATCH fast connect 8/9] device: Make debug print more useful.

2011-08-24 Thread Jukka Rissanen
--- src/device.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/device.c b/src/device.c index 6b8e873..6e84bc4 100644 --- a/src/device.c +++ b/src/device.c @@ -106,7 +106,7 @@ static void reset_scan_trigger(struct connman_device *device) } else

[PATCH fast connect 7/9] wifi: Removed extra scan request call.

2011-08-24 Thread Jukka Rissanen
The wifi_scan_fast() is already called in connman_device_set_powered() so no need to call it again immediately. --- plugins/wifi.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/plugins/wifi.c b/plugins/wifi.c index b9e30db..c0607f5 100644 --- a/plugins/wifi.c +++ b/plug

[PATCH fast connect 9/9] wifi: Fallback to normal scan if fast scan is not supported.

2011-08-24 Thread Jukka Rissanen
--- plugins/wifi.c |9 ++--- 1 files changed, 6 insertions(+), 3 deletions(-) diff --git a/plugins/wifi.c b/plugins/wifi.c index c0607f5..410095d 100644 --- a/plugins/wifi.c +++ b/plugins/wifi.c @@ -506,13 +506,16 @@ static int wifi_scan_fast(struct connman_device *device) if (wif

[PATCH v1 0/3] New storage structure.

2011-08-24 Thread Alok Barsode
From: Alok Barsode Hi Marcel/Samuel, According to our discussion on IRC here is the patch set (version 1) for the storage changes. I have moved the global settings, which include offlinemode and technology states to STORAGEDIR/settings. I am migrating these from the older default.profile file f

[PATCH v1 1/3] storage: switch to settings file.

2011-08-24 Thread Alok Barsode
From: Alok Barsode All the global settings would reside in /var/lib/connman/settings. We also migrate global keys from /var/lib/connman/default.profile to /var/lib/connman/settings for a smooth transition. --- src/config.c | 19 + src/connman.h| 21 ++--- src/main.c |1

[PATCH v1 3/3] stats: Move stat files to respective service identifier directory.

2011-08-24 Thread Alok Barsode
From: Alok Barsode --- src/main.c |6 -- src/stats.c | 29 + 2 files changed, 25 insertions(+), 10 deletions(-) diff --git a/src/main.c b/src/main.c index dd67cb9..283b10a 100644 --- a/src/main.c +++ b/src/main.c @@ -293,12 +293,6 @@ int main(int argc, cha

[PATCH v1 2/3] storage: switch to directories.

2011-08-24 Thread Alok Barsode
From: Alok Barsode Service settings would now reside in /var/lib/connman/service_id/settings. we fallback on /var/lib/connman/default.profile for a smooth transition. --- src/connman.h |4 +++ src/service.c | 66 ++- src/storage.c | 79

[PATCH misc 02/14] vpn: Set authentication failure error code properly in provider.

2011-08-24 Thread Jukka Rissanen
This patch is needed so that we can catch the authentication error from vpn driver and inform the failure to user. --- plugins/vpn.c |5 + plugins/vpn.h |1 + 2 files changed, 6 insertions(+), 0 deletions(-) diff --git a/plugins/vpn.c b/plugins/vpn.c index e028b63..efeb959 100644 ---

[PATCH misc 00/14] Misc fixes

2011-08-24 Thread Jukka Rissanen
Hi, I sent this patchset earlier and it contains mainly issues that I discovered when porting L2TP/PPTP patches to head. I renamed this patchset as it is not really related to L2TP, the patchset is the same as "pre-l2tp/pptp v2" named series, I just ported it to current head (0.77). Description o

[PATCH misc 03/14] service: Add function to get the ipconfig state.

2011-08-24 Thread Jukka Rissanen
--- src/connman.h |3 +++ src/service.c | 13 + 2 files changed, 16 insertions(+), 0 deletions(-) diff --git a/src/connman.h b/src/connman.h index 17add6d..6b2216a 100644 --- a/src/connman.h +++ b/src/connman.h @@ -502,6 +502,9 @@ void __connman_service_set_string(struct connman

[PATCH misc 01/14] provider: NULL pointer check.

2011-08-24 Thread Jukka Rissanen
--- src/provider.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/src/provider.c b/src/provider.c index 9ae62cd..633ca40 100644 --- a/src/provider.c +++ b/src/provider.c @@ -879,6 +879,9 @@ int connman_provider_append_route(struct connman_provider *provider, const c

[PATCH misc 04/14] network: Change the service disconnect state when necessary.

2011-08-24 Thread Jukka Rissanen
If we are in idle or failure states, then we should not change to disconnect state when the service is disconnected. This is because we were not connected in the first place. --- src/network.c | 18 -- 1 files changed, 16 insertions(+), 2 deletions(-) diff --git a/src/network.c

[PATCH misc 05/14] service: Set the user connect status correctly for VPN.

2011-08-24 Thread Jukka Rissanen
If the userconnect is not set, then informatation about authentication errors cannot be reported by agent API. --- src/service.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/service.c b/src/service.c index 60c5ccc..1ff99e4 100644 --- a/src/service.c +++ b/src/servic

[PATCH misc 08/14] service: Fix state combining.

2011-08-24 Thread Jukka Rissanen
If we have IPv6 state as DISCONNECT and IPv4 state as ONLINE or READY then we are not disconnected. --- src/service.c | 64 ++-- 1 files changed, 16 insertions(+), 48 deletions(-) diff --git a/src/service.c b/src/service.c index 089a715..2aebf

[PATCH misc 07/14] service: Change the debug print location to be more useful.

2011-08-24 Thread Jukka Rissanen
--- src/service.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/service.c b/src/service.c index 7ec4a30..089a715 100644 --- a/src/service.c +++ b/src/service.c @@ -3501,9 +3501,6 @@ static int service_indicate_state(struct connman_service *service) old_

[PATCH misc 06/14] service: Fix function name as it is static.

2011-08-24 Thread Jukka Rissanen
--- src/service.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/service.c b/src/service.c index 1ff99e4..7ec4a30 100644 --- a/src/service.c +++ b/src/service.c @@ -3490,7 +3490,7 @@ static void report_error_cb(struct connman_service *service, } } -stat

[PATCH misc 09/14] service: Set the service state to IDLE if method is off or unknown.

2011-08-24 Thread Jukka Rissanen
--- src/service.c | 28 +++- 1 files changed, 27 insertions(+), 1 deletions(-) diff --git a/src/service.c b/src/service.c index 2aebff2..a081b79 100644 --- a/src/service.c +++ b/src/service.c @@ -3711,6 +3711,7 @@ int __connman_service_ipconfig_indicate_state(struct con

[PATCH misc 10/14] provider: Add ref counting debug.

2011-08-24 Thread Jukka Rissanen
--- src/provider.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/provider.c b/src/provider.c index 633ca40..bbd462e 100644 --- a/src/provider.c +++ b/src/provider.c @@ -143,7 +143,7 @@ static void provider_unregister(struct connman_provider *provider) struct c

[PATCH misc 13/14] network: Add NULL check.

2011-08-24 Thread Jukka Rissanen
--- src/network.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/src/network.c b/src/network.c index 31e7eaa..b8175a5 100644 --- a/src/network.c +++ b/src/network.c @@ -1330,6 +1330,9 @@ int __connman_network_set_ipconfig(struct connman_network *network, enum c

[PATCH misc 11/14] provider: Return existing service path if already connected.

2011-08-24 Thread Jukka Rissanen
--- src/provider.c |9 + 1 files changed, 5 insertions(+), 4 deletions(-) diff --git a/src/provider.c b/src/provider.c index bbd462e..8f1862e 100644 --- a/src/provider.c +++ b/src/provider.c @@ -571,11 +571,12 @@ int __connman_provider_create_and_connect(DBusMessage *msg)

[PATCH misc 14/14] service: Add NULL check.

2011-08-24 Thread Jukka Rissanen
--- src/service.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/src/service.c b/src/service.c index a081b79..3a676f8 100644 --- a/src/service.c +++ b/src/service.c @@ -4710,6 +4710,9 @@ struct connman_service *__connman_service_lookup_from_network(struct connman_ne

[PATCH misc 12/14] connection: Service was not ref counted properly.

2011-08-24 Thread Jukka Rissanen
The reference counting problems were clearly seen with VPN service. --- src/connection.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/connection.c b/src/connection.c index 84e3ab4..6323401 100644 --- a/src/connection.c +++ b/src/connection.c @@ -229,6 +229,7 @@

Re: [systemd-devel] net stats per app

2011-08-24 Thread Gustavo Sverzut Barbieri
On Wed, Aug 24, 2011 at 10:42 AM, Lennart Poettering wrote: > On Tue, 02.08.11 15:51, Daniel Wagner (w...@monom.org) wrote: > >> So my thinking is, instead of using the uid driver trick, I could use >> cgroups for collecting the network traffic. At least from the sub module >> description it seems

Re: [PATCH 0/2] device and wifi cleanup

2011-08-24 Thread Samuel Ortiz
Hi Jukka, On Wed, Aug 24, 2011 at 10:00:20AM +0300, Jukka Rissanen wrote: > Hi, > > attached patches do minor cleanup for device.c and wifi.c Thanks, both of them applied now. Cheers, Samuel. -- Intel Open Source Technology Centre http://oss.intel.com/ _

[PATCH 1/2] pacrunner: libproxy: don't be case sensitive with the strings returned by PAC files

2011-08-24 Thread Alban Crequy
Be compatible with existing PAC files which return something like "proxy server:port". They work on Windows but they would not work if pacrunner was case-sensitive. --- libproxy/proxy.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/libproxy/proxy.c b/libproxy/proxy.c

[PATCH 2/2] pacrunner: libproxy: supports various SOCKS proxies

2011-08-24 Thread Alban Crequy
--- libproxy/proxy.c | 24 1 files changed, 24 insertions(+), 0 deletions(-) diff --git a/libproxy/proxy.c b/libproxy/proxy.c index 6dfbfd2..ae53a7a 100644 --- a/libproxy/proxy.c +++ b/libproxy/proxy.c @@ -90,6 +90,30 @@ static char **extract_result(const char *str)

Re: [systemd-devel] net stats per app

2011-08-24 Thread Daniel Wagner
Hi Lennart, On 08/24/2011 03:42 PM, Lennart Poettering wrote: On Tue, 02.08.11 15:51, Daniel Wagner (w...@monom.org) wrote: So my thinking is, instead of using the uid driver trick, I could use cgroups for collecting the network traffic. At least from the sub module description it seems to be

Re: [systemd-devel] net stats per app

2011-08-24 Thread Daniel Wagner
On 08/24/2011 04:19 PM, Gustavo Sverzut Barbieri wrote: A open question is how I get the whole thing persistent. So not each time when an application starts the counters begin at 0. My guts feeling systemd should take of this but I don't know if that is the right direction. Hmm, you could simpl

Re: [PATCH fast connect 1/9] service: Add frequency support to service.

2011-08-24 Thread Samuel Ortiz
Hi Jukka, On Wed, Aug 24, 2011 at 04:48:06PM +0300, Jukka Rissanen wrote: > +dbus_int16_t g_supplicant_network_get_frequency(GSupplicantNetwork *network) We should return a dbus_uint16_t here. > @@ -5293,6 +5293,7 @@ static int service_save(struct connman_service *service) > gchar *pathname

Re: [PATCH fast connect 3/9] gsupplicant: Add support to append char ** entries to dbus dict.

2011-08-24 Thread Samuel Ortiz
Hi Jukka, On Wed, Aug 24, 2011 at 04:48:08PM +0300, Jukka Rissanen wrote: > From: Mohamed Abbas > > --- > gsupplicant/dbus.c | 29 + > gsupplicant/dbus.h | 20 > 2 files changed, 49 insertions(+), 0 deletions(-) > > diff --git a/gsupplicant

Re: [PATCH fast connect 5/9] wifi: Add SSIDs and frequencies to wpa_supplicant scan for fast scan.

2011-08-24 Thread Samuel Ortiz
Hi Jukka, On Wed, Aug 24, 2011 at 04:48:10PM +0300, Jukka Rissanen wrote: > +static void supplicant_add_scan_frequency(DBusMessageIter *dict, > + const char *key, supplicant_dbus_array_function function, The key argument is not needed here, as we know it will always be "Channels". >

Re: [PATCH fast connect 6/9] gsupplicant: Fix the ssid array.

2011-08-24 Thread Samuel Ortiz
Hi Jukka, On Wed, Aug 24, 2011 at 04:48:11PM +0300, Jukka Rissanen wrote: > --- > gsupplicant/gsupplicant.h |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/gsupplicant/gsupplicant.h b/gsupplicant/gsupplicant.h > index 059837f..93e1c8e 100644 > --- a/gsupplicant/gsu

Re: [PATCH fast connect 7/9] wifi: Removed extra scan request call.

2011-08-24 Thread Samuel Ortiz
Hi Jukka, On Wed, Aug 24, 2011 at 04:48:12PM +0300, Jukka Rissanen wrote: > The wifi_scan_fast() is already called in connman_device_set_powered() > so no need to call it again immediately. > --- > plugins/wifi.c |2 -- > 1 files changed, 0 insertions(+), 2 deletions(-) > > diff --git a/plug

Re: [PATCH 1/2] pacrunner: libproxy: don't be case sensitive with the strings returned by PAC files

2011-08-24 Thread Samuel Ortiz
Hi Alban, On Wed, Aug 24, 2011 at 04:01:05PM +0100, Alban Crequy wrote: > Be compatible with existing PAC files which return something like "proxy > server:port". They work on Windows but they would not work if pacrunner was > case-sensitive. Patch applied, thanks a lot. Cheers, Samuel. -- Inte

Re: [PATCH 2/2] pacrunner: libproxy: supports various SOCKS proxies

2011-08-24 Thread Samuel Ortiz
Hi Alban, On Wed, Aug 24, 2011 at 04:01:06PM +0100, Alban Crequy wrote: > --- > libproxy/proxy.c | 24 > 1 files changed, 24 insertions(+), 0 deletions(-) Patch applied as well, thanks. Cheers, Samuel. -- Intel Open Source Technology Centre http://oss.intel.com/

Re: [PATCH v2 01/24] technology: Refactor enable/disable APIs.

2011-08-24 Thread Samuel Ortiz
Hi Alok, On Wed, Aug 24, 2011 at 04:44:07PM +0300, Alok Barsode wrote: > From: Alok Barsode I'm still waiting for patches 22, 23 and 24 from this serie. Cheers, Samuel. -- Intel Open Source Technology Centre http://oss.intel.com/ ___ connman mailing

Re: [PATCH v2 01/24] technology: Refactor enable/disable APIs.

2011-08-24 Thread Samuel Ortiz
Hi Alok, On Wed, Aug 24, 2011 at 04:44:07PM +0300, Alok Barsode wrote: > From: Alok Barsode > > connman_technology_enable: Enable a technology. Enables all the > devices in the device_list of the technology. > connman_technology_enabled: Callback for connman_technology_enable. > Changes the stat