RE: multiple interfaces and routing problem

2011-09-23 Thread VanCutsem, Geoffroy
Hi, I see the same problem too (have seen it with both Connman 0.69.6-4.2 and 0.69.4-1.5 actually). I can very consistently reproduce this by doing the following: - Boot your machine (whatever it is), in my case running MeeGo 1.2 with Ethernet cable plugged in - Checked the connection with ./li

Re: multiple interfaces and routing problem

2011-09-23 Thread Jukka Rissanen
Hi Geoffroy, On 09/23/2011 12:52 PM, VanCutsem, Geoffroy wrote: Hi, I see the same problem too (have seen it with both Connman 0.69.6-4.2 and 0.69.4-1.5 actually). I can very consistently reproduce this by doing the following: - Boot your machine (whatever it is), in my case running MeeGo 1.2

[PATCH 00/16] iptables improvments

2011-09-23 Thread Tomasz Bursztyka
Hi, Since the iptables-test improvments were accepted I am posting the same improvments to core's iptables API. You will find the same patches minus "in/out/src/dest" one (this feature is already present into the core), and I added also a small fix for iptables-test tool (found the issue when

[PATCH 02/16] iptables: added helper function to remove table entry

2011-09-23 Thread Tomasz Bursztyka
--- src/iptables.c | 24 +--- 1 files changed, 17 insertions(+), 7 deletions(-) diff --git a/src/iptables.c b/src/iptables.c index 45c71cd..fec4fb8 100644 --- a/src/iptables.c +++ b/src/iptables.c @@ -335,6 +335,22 @@ static int iptables_add_entry(struct connman_iptables *t

[PATCH 01/16] iptables: find_chain_head/find_chain_tail code factorization

2011-09-23 Thread Tomasz Bursztyka
--- src/iptables.c | 28 +++- 1 files changed, 3 insertions(+), 25 deletions(-) diff --git a/src/iptables.c b/src/iptables.c index e852e01..45c71cd 100644 --- a/src/iptables.c +++ b/src/iptables.c @@ -242,38 +242,16 @@ static GList *find_chain_head(struct connman_iptable

[PATCH 03/16] iptables: adding capability to delete user-defined chains

2011-09-23 Thread Tomasz Bursztyka
--- src/iptables.c | 52 +--- 1 files changed, 49 insertions(+), 3 deletions(-) diff --git a/src/iptables.c b/src/iptables.c index fec4fb8..cb30cf5 100644 --- a/src/iptables.c +++ b/src/iptables.c @@ -483,6 +483,39 @@ err_head: return -ENO

[PATCH 04/16] iptables: small indentation fix

2011-09-23 Thread Tomasz Bursztyka
--- src/iptables.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/iptables.c b/src/iptables.c index cb30cf5..78ad210 100644 --- a/src/iptables.c +++ b/src/iptables.c @@ -1047,8 +1047,8 @@ static int iptables_command(int argc, char *argv[]) optind = 0; -

[PATCH 05/16] iptables: fix memory leak

2011-09-23 Thread Tomasz Bursztyka
--- src/iptables.c |8 ++-- 1 files changed, 6 insertions(+), 2 deletions(-) diff --git a/src/iptables.c b/src/iptables.c index 78ad210..a8167ee 100644 --- a/src/iptables.c +++ b/src/iptables.c @@ -633,7 +633,7 @@ iptables_add_rule(struct connman_iptables *table, GList *chain_tail

[PATCH 06/16] iptables: code factorization for rule inclusion

2011-09-23 Thread Tomasz Bursztyka
--- src/iptables.c | 47 +-- 1 files changed, 33 insertions(+), 14 deletions(-) diff --git a/src/iptables.c b/src/iptables.c index a8167ee..b5cfec7 100644 --- a/src/iptables.c +++ b/src/iptables.c @@ -624,32 +624,27 @@ static void update_hooks(struct

[PATCH 07/16] iptables: adding capability to insert a rule

2011-09-23 Thread Tomasz Bursztyka
--- src/iptables.c | 64 +-- 1 files changed, 57 insertions(+), 7 deletions(-) diff --git a/src/iptables.c b/src/iptables.c index b5cfec7..4a4a9bf 100644 --- a/src/iptables.c +++ b/src/iptables.c @@ -692,6 +692,31 @@ iptables_add_rule(struct c

[PATCH 08/16] iptables: renaming add into append

2011-09-23 Thread Tomasz Bursztyka
--- src/iptables.c |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/src/iptables.c b/src/iptables.c index 4a4a9bf..3f1a92a 100644 --- a/src/iptables.c +++ b/src/iptables.c @@ -664,8 +664,7 @@ static struct ipt_entry *prepare_rule_inclusion(struct connman_iptables *tabl

[PATCH 10/16] iptables: refactoring how jumps are handled

2011-09-23 Thread Tomasz Bursztyka
--- src/iptables.c | 147 +++- 1 files changed, 82 insertions(+), 65 deletions(-) diff --git a/src/iptables.c b/src/iptables.c index 2a2bc2a..48d7214 100644 --- a/src/iptables.c +++ b/src/iptables.c @@ -517,13 +517,12 @@ static int iptables_del

[PATCH 09/16] iptables: fixing target reference update

2011-09-23 Thread Tomasz Bursztyka
--- src/iptables.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/iptables.c b/src/iptables.c index 3f1a92a..2a2bc2a 100644 --- a/src/iptables.c +++ b/src/iptables.c @@ -315,10 +315,10 @@ static int iptables_add_entry(struct connman_iptables *table, entr

[PATCH 11/16] iptables: factorization of target reference update

2011-09-23 Thread Tomasz Bursztyka
--- src/iptables.c | 37 +++-- 1 files changed, 23 insertions(+), 14 deletions(-) diff --git a/src/iptables.c b/src/iptables.c index 48d7214..59c483e 100644 --- a/src/iptables.c +++ b/src/iptables.c @@ -284,13 +284,32 @@ static void update_offsets(struct connman_

[PATCH 12/16] iptables: rule deletion capability added

2011-09-23 Thread Tomasz Bursztyka
--- src/iptables.c | 211 ++-- 1 files changed, 206 insertions(+), 5 deletions(-) diff --git a/src/iptables.c b/src/iptables.c index 59c483e..d97efea 100644 --- a/src/iptables.c +++ b/src/iptables.c @@ -286,11 +286,15 @@ static void update_offs

[PATCH 13/16] iptables: adding capability to load necessary modules

2011-09-23 Thread Tomasz Bursztyka
--- src/iptables.c | 17 - 1 files changed, 16 insertions(+), 1 deletions(-) diff --git a/src/iptables.c b/src/iptables.c index d97efea..142d277 100644 --- a/src/iptables.c +++ b/src/iptables.c @@ -1138,11 +1138,25 @@ static void table_cleanup(struct connman_iptables *table)

[PATCH 14/16] iptables: tiny indentation fix

2011-09-23 Thread Tomasz Bursztyka
--- src/iptables.c | 10 -- 1 files changed, 4 insertions(+), 6 deletions(-) diff --git a/src/iptables.c b/src/iptables.c index 142d277..accbc9c 100644 --- a/src/iptables.c +++ b/src/iptables.c @@ -59,7 +59,7 @@ static const char *hooknames[] = { type *__entry;

[PATCH 15/16] iptables: copyright year update

2011-09-23 Thread Tomasz Bursztyka
--- src/iptables.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/iptables.c b/src/iptables.c index accbc9c..0440cdf 100644 --- a/src/iptables.c +++ b/src/iptables.c @@ -2,7 +2,7 @@ * * Connection Manager * - * Copyright (C) 2007-2010 Intel Corporation. All

[PATCH 16/16] tools: fixed double-free error possibility into iptables-test

2011-09-23 Thread Tomasz Bursztyka
--- tools/iptables-test.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/tools/iptables-test.c b/tools/iptables-test.c index c3cf671..35c6300 100644 --- a/tools/iptables-test.c +++ b/tools/iptables-test.c @@ -1149,6 +1149,7 @@ static struct connman_iptables *connman_ipta

RE: multiple interfaces and routing problem

2011-09-23 Thread VanCutsem, Geoffroy
Hi Jukka, > -Original Message- > From: Jukka Rissanen [mailto:jukka.rissa...@linux.intel.com] > Sent: Friday, September 23, 2011 12:15 PM > To: connman@connman.net > Cc: VanCutsem, Geoffroy > Subject: Re: multiple interfaces and routing problem > > Hi Geoffroy, > > On 09/23/2011 12:52 PM

Re: multiple interfaces and routing problem

2011-09-23 Thread Jukka Rissanen
On 09/23/2011 02:48 PM, VanCutsem, Geoffroy wrote: Sounds like you have two default routes. Check with "netstat -rn", if you have two default routes then that is is the culprit. You could upgrade to newer connman which should fix the issue. Any recommendation in terms of version to use or shou

Re: multiple interfaces and routing problem

2011-09-23 Thread Julien Massot
Hi Geoffroy, I think you don't have the same issue, my problem is for incoming packets, i have no problems to go outside. Sorry to not post the resolution of this issue on the mailling list, here there is no spoon, there is no bug, just a kernel protection against IP spoofing. There is 2 way to f

[PATCH 0/4] multi-path and routing issue for incoming packets

2011-09-23 Thread Julien Massot
These patchs are just for helping people who have problems with multiple interfaces and incomming packets. Some part of these patchs better looks like "hacks", like the index2tid function. Some parts are not implemented like the settings of route with static IP, or IPv6 stuff. A table is create

[PATCH 1/4] inet: add function to add/del rule

2011-09-23 Thread Julien Massot
--- include/inet.h |2 + src/inet.c | 144 2 files changed, 146 insertions(+), 0 deletions(-) diff --git a/include/inet.h b/include/inet.h index 1aa23ea..ecc95b2 100644 --- a/include/inet.h +++ b/include/inet.h @@ -46,6 +46,8 @@ co

[PATCH 2/4] inet: add IPV4 route with nlmsg

2011-09-23 Thread Julien Massot
This patch make __connman_inet_add_network_route able to add a route to a specific routing table. --- include/inet.h |5 ++ src/inet.c | 192 2 files changed, 130 insertions(+), 67 deletions(-) diff --git a/include/inet.h b/includ

[PATCH 4/4] dump every route to the corresponding table matching interface

2011-09-23 Thread Julien Massot
--- include/ipconfig.h |3 ++- src/connection.c |8 +++- src/dhcp.c | 13 ++--- src/inet.c |2 ++ src/ipconfig.c | 17 + src/provider.c |9 - 6 files changed, 46 insertions(+), 6 deletions(-) diff --git a/include/ip

[PATCH 3/4] inet: add function to add a route to a specific table

2011-09-23 Thread Julien Massot
--- include/inet.h |4 src/inet.c | 20 2 files changed, 24 insertions(+), 0 deletions(-) diff --git a/include/inet.h b/include/inet.h index 54cebdb..e030483 100644 --- a/include/inet.h +++ b/include/inet.h @@ -52,10 +52,14 @@ int connman_inet_add_host_route(in

Re: [PATCH 0/4] multi-path and routing issue for incoming packets

2011-09-23 Thread Jukka Rissanen
Hi Julien, On 09/23/2011 04:17 PM, Julien Massot wrote: These patchs are just for helping people who have problems with multiple interfaces and incomming packets. Some part of these patchs better looks like "hacks", like the index2tid function. Some parts are not implemented like the settings