Re: [PATCH] gdhcp: Make sure we have the message before accessing it

2012-05-11 Thread Patrik Flykt
On Thu, 2012-05-10 at 16:31 +0300, Jukka Rissanen wrote: Patch applied, thanks a lot! Patrik ___ connman mailing list connman@connman.net http://lists.connman.net/listinfo/connman

[PATCH] README: Add comment on OpenVPN version to use

2012-05-11 Thread Daniel Wagner
From: Daniel Wagner daniel.wag...@bmw-carit.de --- README | 10 ++ 1 file changed, 10 insertions(+) diff --git a/README b/README index 11d40ff..086d562 100644 --- a/README +++ b/README @@ -67,6 +67,16 @@ To run pptp you will need Both l2tp and pptp also need pppd. +OpenVPN

Re: Wifi won't connect

2012-05-11 Thread Patrik Flykt
Hi, On Thu, 2012-05-10 at 16:06 +0200, Julien Pichon wrote: Adding a global section seems to change nothing. [global] Reading the code in src/config.c, load_config() reveals that the [global] section was not mandatory to have. [service_dunasyswifi] Type=wifi SSID=MY_WIFI

Re: [PATCH] README: Add comment on OpenVPN version to use

2012-05-11 Thread Marcel Holtmann
Hi Daniel, --- README | 10 ++ 1 file changed, 10 insertions(+) diff --git a/README b/README index 11d40ff..086d562 100644 --- a/README +++ b/README @@ -67,6 +67,16 @@ To run pptp you will need Both l2tp and pptp also need pppd. +OpenVPN +=== + +Up to version

Re: Wifi won't connect

2012-05-11 Thread Marcel Holtmann
Hi Patrik, Adding a global section seems to change nothing. [global] Reading the code in src/config.c, load_config() reveals that the [global] section was not mandatory to have. [service_dunasyswifi] Type=wifi SSID=MY_WIFI Passphrase=secret In the same file, load_service()

Re: Wifi won't connect

2012-05-11 Thread Patrik Flykt
On Fri, 2012-05-11 at 01:56 -0700, Marcel Holtmann wrote: in which way is it buggy? It just said the SSID can be in hex or plain string, the plain string part wasn't implemented at all. Do you want a fix for the documentation or the code? And also, 'Name' wasn't documented although it was used

Re: Wifi won't connect

2012-05-11 Thread Marcel Holtmann
Hi Patrik, in which way is it buggy? It just said the SSID can be in hex or plain string, the plain string part wasn't implemented at all. Do you want a fix for the documentation or the code? And also, 'Name' wasn't documented although it was used in the examples. In the code 'Name' is

[PATCH v1 2/2] README: Add comment on OpenVPN version to use

2012-05-11 Thread Daniel Wagner
From: Daniel Wagner daniel.wag...@bmw-carit.de --- README | 10 ++ 1 file changed, 10 insertions(+) diff --git a/README b/README index 93e6461..dfb87f8 100644 --- a/README +++ b/README @@ -179,3 +179,13 @@ To run pptp you will need - pptp client,

[PATCH v1 1/2] README: Move the VPN entry down

2012-05-11 Thread Daniel Wagner
From: Daniel Wagner daniel.wag...@bmw-carit.de So it is under the Configuration and options section. --- README | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/README b/README index 11d40ff..93e6461 100644 --- a/README +++ b/README @@ -52,21

Re: [PATCH v1 1/2] README: Move the VPN entry down

2012-05-11 Thread Marcel Holtmann
Hi Daniel, So it is under the Configuration and options section. --- README | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) patch has been applied. Regards Marcel ___ connman mailing list

Re: [PATCH v1 2/2] README: Add comment on OpenVPN version to use

2012-05-11 Thread Marcel Holtmann
Hi Daniel, --- README | 10 ++ 1 file changed, 10 insertions(+) patch has been applied. Regards Marcel ___ connman mailing list connman@connman.net http://lists.connman.net/listinfo/connman

Re: Wifi won't connect

2012-05-11 Thread Julien Pichon
On Fri, May 11, 2012 at 12:22:37PM +0300, Patrik Flykt wrote: On Fri, 2012-05-11 at 01:56 -0700, Marcel Holtmann wrote: in which way is it buggy? It just said the SSID can be in hex or plain string, the plain string part wasn't implemented at all. Do you want a fix for the documentation or

Re: Wifi won't connect

2012-05-11 Thread Marcel Holtmann
Hi Julien, in which way is it buggy? It just said the SSID can be in hex or plain string, the plain string part wasn't implemented at all. Do you want a fix for the documentation or the code? And also, 'Name' wasn't documented although it was used in the examples. In the code 'Name'

[PATCH] doc: SSID field is hexadecimal only, document Name field

2012-05-11 Thread patrik . flykt
From: Patrik Flykt patrik.fl...@linux.intel.com --- doc/config-format.txt |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/doc/config-format.txt b/doc/config-format.txt index cf89c09..a9c560f 100644 --- a/doc/config-format.txt +++ b/doc/config-format.txt @@ -31,7 +31,9

Re: Wifi won't connect

2012-05-11 Thread Patrik Flykt
On Fri, 2012-05-11 at 02:40 -0700, Marcel Holtmann wrote: you should only need either Name or SSID, but not both. In this case yes. Here SSID will take precedence. Now I just started to wonder what the pretty-print service name will be if it's not set... Cheers, Patrik

Re: [PATCH] doc: SSID field is hexadecimal only, document Name field

2012-05-11 Thread Patrik Flykt
On Fri, 2012-05-11 at 12:42 +0300, patrik.fl...@linux.intel.com wrote: From: Patrik Flykt patrik.fl...@linux.intel.com Patch applied. Patrik ___ connman mailing list connman@connman.net http://lists.connman.net/listinfo/connman

Re: Wifi won't connect

2012-05-11 Thread Marcel Holtmann
Hi Patrik, you should only need either Name or SSID, but not both. In this case yes. Here SSID will take precedence. Now I just started to wonder what the pretty-print service name will be if it's not set... it should be the SSID converted to a UTF-8 string if possible. Same as we do with

[RFC] gweb's statical analysis review

2012-05-11 Thread Tomasz Bursztyka
Hi, Just to pin-point what was the guilty line: +++ b/gweb/gweb.c @@ -611,8 +611,7 @@ static void start_request(struct web_session *session) g_string_append_printf(buf, %zx\r\n, length); g_string_append_len(buf, (char *) body, length);

[PATCH] Send RS before RDNSS lifetime expires

2012-05-11 Thread Elena Tebesoi
Implemented feature from RFC 6106 section '5.1. Recursive DNS Server Option': Lifetime 32-bit unsigned integer. ... Hosts MAY send a Router Solicitation to ensure the RDNSS information is fresh before the interval expires. Host will send RS when a certain

Re: Static analysis errors [fixed]

2012-05-11 Thread Henrique Dante
Hello, I've just updated static analysis results at: http://people.profusion.mobi/~hdante/connman/index.html On Tue, May 8, 2012 at 3:06 PM, Henrique Dante hda...@profusion.mobi wrote: Hello, I'm sending the error reports here, as suggested in #connman. There were 8 issues, 1 of them already

Re: connman Digest, Vol 40, Issue 25

2012-05-11 Thread Grant Erickson
On May 11, 2012, at 2:42 AM, connman-requ...@connman.net wrote: From: Marcel Holtmann mar...@holtmann.org Subject: Re: Wifi won't connect Date: May 11, 2012 1:56:04 AM PDT Hi Patrik, Adding a global section seems to change nothing. [global] Reading the code in src/config.c,