[PATCH] gsupplicant: Avoid critical errors

2012-05-15 Thread Jukka Rissanen
wpa_supplicant sends error if wlan interface cannot be created. Do not treat this error as critical because after calling g_critical() the program logging will be disabled. --- gsupplicant/supplicant.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/gsupplicant/supplicant

[PATCH] gsupplicant: fix "raw" PSK support

2012-05-15 Thread Grant Erickson
This fixes "raw" PSK support by first converting the "raw" PSK from a 64-character hexadecimal string to 32-byte array before appending it to the network dictionary. --- gsupplicant/supplicant.c | 42 -- 1 file changed, 36 insertions(+), 6 deletions(-) d

[PATCH v2] gsupplicant: fix "raw" PSK support

2012-05-15 Thread Grant Erickson
This fixes "raw" PSK support by first converting the "raw" PSK from a 64-character hexadecimal string to 32-byte array before appending it to the network dictionary. --- v1: Initial submission. v2: Fixed white space. gsupplicant/supplicant.c | 42 -- 1

Re: [PATCH v2] gsupplicant: fix "raw" PSK support

2012-05-15 Thread Patrik Flykt
On Tue, 2012-05-15 at 01:51 -0700, Grant Erickson wrote: > This fixes "raw" PSK support by first converting the "raw" PSK from > a 64-character hexadecimal string to 32-byte array before appending > it to the network dictionary. Patch applied, thanks a lot! Patrik ___

Re: [PATCH] Send RS before RDNSS lifetime expires

2012-05-15 Thread Elena Tebesoi
Hi Jukka, Thank you for the quick review and please find my answers inline. A new version of the patch is due, taking into account your suggestions. Regards, Elena On Mon, May 14, 2012 at 2:21 PM, Jukka Rissanen < jukka.rissa...@linux.intel.com> wrote: > Hi Elena, > > > On 05/11/2012 02:56 PM,

Re: [PATCH 0/4] Handle DNSSL RA option properly

2012-05-15 Thread Patrik Flykt
On Mon, 2012-05-14 at 13:33 +0300, Jukka Rissanen wrote: > Hi, > > according to RFC 6106, the DNS search list option can be > present in router advertisement without any resursive > DNS server option (RDNSS). This is fixed by patch #4. > The patch cannot be fully tested atm because no kernel > fro

Re: [PATCH 0/2] Minor service provisioning fixes

2012-05-15 Thread Patrik Flykt
On Mon, 2012-05-14 at 15:20 +0300, patrik.fl...@linux.intel.com wrote: > Added checks that the SSID in a service .config file is correct and updated > documentation about the service section identification and 'Name' entry. > SSID is used always used as the pretty-print name for a service. Patches

Re: [PATCH] gsupplicant: Avoid critical errors

2012-05-15 Thread Patrik Flykt
On Tue, 2012-05-15 at 10:59 +0300, Jukka Rissanen wrote: > wpa_supplicant sends error if wlan interface cannot be created. > Do not treat this error as critical because after calling > g_critical() the program logging will be disabled. Patch applied, thanks a lot! Patrik ___

Re: [PATCH] Send RS before RDNSS lifetime expires

2012-05-15 Thread Jukka Rissanen
Hi Elena, On 05/15/2012 03:37 PM, Elena Tebesoi wrote: Hi Jukka, Thank you for the quick review and please find my answers inline. A new version of the patch is due, taking into account your suggestions. Regards, Elena On Mon, May 14, 2012 at 2:21 PM, Jukka Rissanen mailto:jukka.rissa...@linu

Re: [PATCH] Send RS before RDNSS lifetime expires

2012-05-15 Thread Elena Tebesoi
Hi Jukka, On Tue, May 15, 2012 at 3:45 PM, Jukka Rissanen < jukka.rissa...@linux.intel.com> wrote: > Hi Elena, > > > On 05/15/2012 03:37 PM, Elena Tebesoi wrote: > >> Hi Jukka, >> >> Thank you for the quick review and please find my answers inline. >> A new version of the patch is due, taking int

Re: [PATCH v2] gsupplicant: fix "raw" PSK support

2012-05-15 Thread Marcel Holtmann
Hi Grant, > This fixes "raw" PSK support by first converting the "raw" PSK from > a 64-character hexadecimal string to 32-byte array before appending > it to the network dictionary. > > --- > v1: Initial submission. > v2: Fixed white space. > > gsupplicant/supplicant.c | 42

Re: [PATCH v2] gsupplicant: fix "raw" PSK support

2012-05-15 Thread Grant Erickson
On May 15, 2012, at 8:09 AM, Marcel Holtmann wrote: >> This fixes "raw" PSK support by first converting the "raw" PSK from >> a 64-character hexadecimal string to 32-byte array before appending >> it to the network dictionary. >> >> --- >> v1: Initial submission. >> v2: Fixed white space. >> >> g

[PATCH v2] gsupplicant: fix "raw" PSK support

2012-05-15 Thread Grant Erickson
This fixes "raw" PSK support by first converting the "raw" PSK from a 64-character hexadecimal string to 32-byte array before appending it to the network dictionary. --- v1: Initial submission. v2: Fixed white space. gsupplicant/supplicant.c | 42 -- 1

[PATCH] gsupplicant: coding style clean-up

2012-05-15 Thread Grant Erickson
This resolves several post-commit review coding style comments for raw PSK support. --- gsupplicant/supplicant.c | 26 ++ 1 file changed, 14 insertions(+), 12 deletions(-) diff --git a/gsupplicant/supplicant.c b/gsupplicant/supplicant.c index 829ceb7..0ae5540 100644 ---