Re: [PATCH 2/2] agent: Use InputRequestTimeout and BrowserLaunchTimeout values

2012-05-29 Thread Marcel Holtmann
Hi Patrik, > --- > src/agent.c | 18 -- > 1 file changed, 12 insertions(+), 6 deletions(-) > > diff --git a/src/agent.c b/src/agent.c > index 82dc46d..1f920ee 100644 > --- a/src/agent.c > +++ b/src/agent.c > @@ -31,8 +31,6 @@ > > #include "connman.h" > > -#define REQUEST_T

Re: [PATCH 1/2] main: Add InputRequestTimeout and BrowserLaunchTimeout variables

2012-05-29 Thread Marcel Holtmann
Hi Patrik, > Add InputRequestTimeout and BrowserLaunchTimeout main.conf variable > handling and connman_setting_get_int() for fetching their value. > --- > include/setting.h |1 + > src/main.c| 30 ++ > 2 files changed, 31 insertions(+) > > diff --git a/

Re: [PATCH 2/2] agent: Use InputRequestTimeout and BrowserLaunchTimeout values

2012-05-29 Thread Patrik Flykt
On Tue, 2012-05-29 at 12:36 +0200, Marcel Holtmann wrote: > instead of doing this over and over again, don't you think it makes > sense to just do it once at __connman_agent_init() call and store it > as a global variable. True. I can do that. Cheers, Patrik ___

[PATCH] gdbus: add macro for methods marked as NOREPLY

2012-05-29 Thread Lucas De Marchi
--- This is not used by ConnMan, but it's in other projects using gdbus. gdbus/gdbus.h |7 +++ 1 file changed, 7 insertions(+) diff --git a/gdbus/gdbus.h b/gdbus/gdbus.h index e2e160d..0a8a27c 100644 --- a/gdbus/gdbus.h +++ b/gdbus/gdbus.h @@ -144,6 +144,13 @@ typedef struct { .

[PATCH v2 2/2] agent: Use input request and browser launch timeouts

2012-05-29 Thread patrik . flykt
From: Patrik Flykt --- src/agent.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/src/agent.c b/src/agent.c index 82dc46d..581f977 100644 --- a/src/agent.c +++ b/src/agent.c @@ -31,8 +31,6 @@ #include "connman.h" -#define REQUEST_TIMEOUT (120 * 1000)

[PATCH v2 1/2] main: Add InputRequestTimeout and BrowserLaunchTimeout variables

2012-05-29 Thread patrik . flykt
From: Patrik Flykt Add InputRequestTimeout and BrowserLaunchTimeout main.conf variable handling and functions for fetching their values. --- include/setting.h |3 +++ src/main.c| 27 +++ 2 files changed, 30 insertions(+) diff --git a/include/setting.h b/inc

[PATCH v2 0/2] Implementation of InputRequestTimeout and BrowserLaunchTimeout

2012-05-29 Thread patrik . flykt
From: Patrik Flykt Hi, Let's redo this patch set. Create two dedicated functions for timeout values and leave the function optimization for the compiler. A variable would have been nice, but this way it cannot be accidentally assigned to either. And I can always make a new version when n

[PATCH v3 0/2] Implementation of InputRequestTimeout and BrowserLaunchTimeout

2012-05-29 Thread patrik . flykt
From: Patrik Flykt Hi, v3, added #defines for the timeout defaults. Cheers, Patrik Patrik Flykt (2): main: Add InputRequestTimeout and BrowserLaunchTimeout variables agent: Use input request and browser launch timeouts include/setting.h |3 +++ src/agent.c |

[PATCH v3 2/2] agent: Use input request and browser launch timeouts

2012-05-29 Thread patrik . flykt
From: Patrik Flykt --- src/agent.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/src/agent.c b/src/agent.c index 82dc46d..581f977 100644 --- a/src/agent.c +++ b/src/agent.c @@ -31,8 +31,6 @@ #include "connman.h" -#define REQUEST_TIMEOUT (120 * 1000)

[PATCH v3 1/2] main: Add InputRequestTimeout and BrowserLaunchTimeout variables

2012-05-29 Thread patrik . flykt
From: Patrik Flykt Add InputRequestTimeout and BrowserLaunchTimeout main.conf variable handling and functions for fetching their values. --- include/setting.h |3 +++ src/main.c| 30 ++ 2 files changed, 33 insertions(+) diff --git a/include/setting.h b/

[PATCH] dnsproxy: possible memory leak when querying the dns via UDP and the answer lies in the cache

2012-05-29 Thread Paulo Pizarro
If the answer is in the cache, the request is not appended in the request_list and is released. --- src/dnsproxy.c | 26 -- 1 file changed, 12 insertions(+), 14 deletions(-) diff --git a/src/dnsproxy.c b/src/dnsproxy.c index 5c4099b..97f8add 100644 --- a/src/dnsproxy.c

Service.GetProperties deprecated

2012-05-29 Thread Bach, Pascal
Hello I have a question concerning the Service API. In the documentation service-api.txt it is stated that the Service.GetProperties is deprecated and it's use is discouraged. Further it says that one should use Manager.GetServices instead. Now my question is why is GetProperties deprecated? An

connmand and legacy WiFi support :net.connman.Error.NotRegistered

2012-05-29 Thread alfred steele
Hi All, I have a driver which just supports wext and does not support nl80211 driver. When i invoke connmand (connmand -n -d 'plugins/*' ), i get the following errors while trying to test dbus api's : .# dbus-send --system --dest=net.connman --print-reply / net.connman.Manager.EnableTechnology