Re: [PATCH 0/2] gsupplicant: Wi-Fi security updates.

Hi, On Sun, 2012-06-03 at 17:39 +0900, Danny Jeongseok Seo wrote: > 1. Wi-Fi security change from WPA to OPEN and from EAP to OPEN. Which versions of ConnMan and wpa_supplicant are you using here? Do notice that this was fixed in commit 8796333af04b7d96dff3c4dbc5b57f5152a8b454, which sa

Re: [PATCH] Only one copy of the relevant buffers will be made to a TCP request.

Hi Paulo, patch looks good, but there are some nitpicks. On 06/04/2012 07:52 AM, Paulo Pizarro wrote: Upon receiving a TCP request, the dnsproxy scans the list of nameservers and for each (UDP) nameserver a TCP server is created and starts its connection. Since the connection was not done yet

RE: [PATCH 0/2] gsupplicant: Wi-Fi security updates.

Hi Patrik, This patch is based on ConnMan 1.1 upstream, the latest, and wpa_supplicant 0.8.x. For the bug 21332, below commit that you mentioned is correct and fixed. But that fix does not update from WPA to OPEN and from EAP to OPEN. Please check my patch that will enhance below commit. If you

Re: [PATCH v4 09/14] dundee: Monitor Device.PropertyChanged signal

On Fri, 2012-06-01 at 16:11 +0200, Daniel Wagner wrote: > +static gboolean device_changed(DBusConnection *connection, > + DBusMessage *message, > + void *user_data) > +{ > + const char *path = dbus_message_get_path(message); > +

Re: [PATCH v4 09/14] dundee: Monitor Device.PropertyChanged signal

On Mon, 2012-06-04 at 11:27 +0300, Patrik Flykt wrote: > Extra whitespace at the end of the line. ...nothing I can't fix myself. No need for a new patch. Patrik ___ connman mailing list connman@connman.net http://lists.connman.net/listinfo/conn

[PATCH 0/5] IP address checking factorization

From: Patrik Flykt Hi, I noticed this kind of functionality was used in various places in ConnMan and decided to refactor it into one place. Cheers, Patrik Patrik Flykt (5): inet: Create helper function for IP address checking service: Check that the supplied namese

[PATCH 2/5] service: Check that the supplied nameserver is in numeric format

From: Patrik Flykt Check that the supplied nameserver is in numeric format when set with 'Nameservers.Configuration' service property. --- src/service.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/service.c b/src/service.c index de28264..6f02ed7 100644 --

[PATCH 1/5] inet: Create helper function for IP address checking

From: Patrik Flykt Create a helper function that checks if a given hostname is an IPv4 or IPv6 address. If it is, AF_INET or AF_INET6 is returned. On error the negative error value from getaddrinfo is returned. --- include/inet.h |1 + src/inet.c | 20 2 files chan

[PATCH 5/5] timeserver: Simplify timeserver IP address checking

From: Patrik Flykt --- src/timeserver.c | 12 +--- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/src/timeserver.c b/src/timeserver.c index 2601d36..e218fe2 100644 --- a/src/timeserver.c +++ b/src/timeserver.c @@ -115,9 +115,6 @@ static void resolv_result(GResolvResultSt

[PATCH 3/5] service: Simplify nameserver route adding and removing

From: Patrik Flykt --- src/service.c | 36 ++-- 1 file changed, 6 insertions(+), 30 deletions(-) diff --git a/src/service.c b/src/service.c index 6f02ed7..4597912 100644 --- a/src/service.c +++ b/src/service.c @@ -1131,48 +1131,26 @@ static void add_nameserver_

[PATCH 4/5] main: Simplify fallback nameserver parsing

From: Patrik Flykt --- src/main.c |9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/src/main.c b/src/main.c index 48a956c..a8ce8bb 100644 --- a/src/main.c +++ b/src/main.c @@ -106,8 +106,6 @@ static char **parse_fallback_nameservers(char **nameservers, gsize len) {

[PATCH] dnsproxy: Do not print too many info messages

Convert connman_info() into DBG() in order to avoid excessive logging when debug prints are disabled. --- src/dnsproxy.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/dnsproxy.c b/src/dnsproxy.c index ea7a122..d7ef63b 100644 --- a/src/dnsproxy.c +++ b/src/

[PATCH v2] Only one copy of the relevant buffers will be made to a TCP request.

Upon receiving a TCP request, the dnsproxy scans the list of nameservers and for each (UDP) nameserver a TCP server is created and starts its connection. Since the connection was not done yet (socket is nonblocking) then the relevant buffers are copied. If the list has more than one (UDP) namese

[PATCH] dnsproxy: Avoiding duplication of domains in the list of domains of the TCP server

The domain list is created in the tcp_server_event function at connection time (G_IO_OUT event), so it is not necessary to create it here. --- src/dnsproxy.c | 16 ++-- 1 file changed, 2 insertions(+), 14 deletions(-) diff --git a/src/dnsproxy.c b/src/dnsproxy.c index 00c5eb3..ea96

[PATCH v2] dnsproxy: Only one copy of the relevant buffers will be made to a TCP request.

Upon receiving a TCP request, the dnsproxy scans the list of nameservers and for each (UDP) nameserver a TCP server is created and starts its connection. Since the connection was not done yet (socket is nonblocking) then the relevant buffers are copied. If the list has more than one (UDP) nameser

Re: [PATCH 02/17] storage: Add function to remove a specific service

Hi, On Mon, 2012-05-28 at 10:44 +0300, Jukka Rissanen wrote: > All known files from service directory are removed and > if successfull then the service directory is also removed. > --- > src/connman.h |1 + > src/storage.c | 81 > +++

Re: [PATCH 04/17] config: Remove service if config file is removed

Hi, On Mon, 2012-05-28 at 10:44 +0300, Jukka Rissanen wrote: > static void unregister_service(gpointer data) > { > - struct connman_config_service *service = data; > - > - connman_info("Removing service configuration %s", service->ident); > - > - protected_services = g_slist

Re: [PATCH] dnsproxy: Avoiding duplication of domains in the list of domains of the TCP server

Just ignore only this patch. Sorry. 2012/6/4 Paulo Pizarro : > The domain list is created in the tcp_server_event function at connection > time (G_IO_OUT event), so it is not necessary to create it here. > --- >  src/dnsproxy.c |   16 ++-- >  1 file changed, 2 insertions(+), 14 delet

Re: [PATCH 15/17] config: No service removal on cleanup

Hi, On Mon, 2012-05-28 at 10:44 +0300, Jukka Rissanen wrote: > We must not remove the services when connman is stopped. > --- > src/config.c |9 + > 1 files changed, 9 insertions(+), 0 deletions(-) > > diff --git a/src/config.c b/src/config.c > index 7f0abf1..683a0ef 100644

Re: [PATCH v2] dnsproxy: Only one copy of the relevant buffers will be made to a TCP request.

Just ignore this patch. Sorry. 2012/6/4 Paulo Pizarro : > Upon receiving a TCP request, the dnsproxy scans the list of nameservers and > for each (UDP) nameserver a TCP server is created and starts its connection. > Since the connection was not done yet (socket is nonblocking) then the > releva

[PATCH v3 1/2] dnsproxy: Only one copy of the relevant buffers will be made to a TCP request.

Upon receiving a TCP request, the dnsproxy scans the list of nameservers and for each (UDP) nameserver a TCP server is created and starts its connection. Since the connection was not done yet (socket is nonblocking) then the relevant buffers are copied. If the list has more than one (UDP) nameser

[PATCH v3 2/2] dnsproxy: Avoiding duplication of domains in the list of domains of the TCP server

The domain list is created in the tcp_server_event function at connection time (G_IO_OUT event), so it is not necessary to create it here. --- src/dnsproxy.c | 16 ++-- 1 file changed, 2 insertions(+), 14 deletions(-) diff --git a/src/dnsproxy.c b/src/dnsproxy.c index 00c5eb3..ea96

Re: [PATCH v4 00/14] DUN Support

On Fri, 2012-06-01 at 16:11 +0200, Daniel Wagner wrote: > From: Daniel Wagner > > Hi, > > This version address Patrik's comments on v3. > > cheers, > daniel All 14 patches pushed. Many thanks. Patrik ___ connman mailing list connman@connma

[PATCH v4 1/2] dnsproxy: Only one copy of the relevant buffers will be made to a TCP request.

Upon receiving a TCP request, the dnsproxy scans the list of nameservers and for each (UDP) nameserver a TCP server is created and starts its connection. Since the connection was not done yet (socket is nonblocking) then the relevant buffers are copied. If the list has more than one (UDP) namese

[PATCH v4 2/2] dnsproxy: Avoiding duplication of domains in the list of domains of the TCP server

The domain list is created in the tcp_server_event function at connection time (G_IO_OUT event), so it is not necessary to create it here. --- src/dnsproxy.c | 17 ++--- 1 file changed, 2 insertions(+), 15 deletions(-) diff --git a/src/dnsproxy.c b/src/dnsproxy.c index 00c5eb3..bdb

Connman 1.x Regression / Issue List

Over the weekend I identified a few add'l regressions in functionality in connman-1.x relative to connman-0.7x that I am going to be diving into today: 1) Connman does not automatically reconnect to idle services following a technology powered or offline mode assertion / deassertion cycl

Re: [PATCH 1/3] dnsproxy: Check overlapping memcpy

Hi Jukka On Fri, Jun 1, 2012 at 9:02 AM, Jukka Rissanen wrote: > The problem was seen with valgrind. We tried to get hostname > without domain part and if server returns an error, we could > end up in situation where domain_len == 0 even if append_domain > is set to TRUE. So check that if domain_

Re: [PATCH 2/3] dnsproxy: Use memmove() when discarding domain name

Hi Jukka, On Fri, Jun 1, 2012 at 9:02 AM, Jukka Rissanen wrote: > The memory areas can overlap so memmove() must be used. > --- >  src/dnsproxy.c |    6 +- >  1 files changed, 5 insertions(+), 1 deletions(-) > > diff --git a/src/dnsproxy.c b/src/dnsproxy.c > index f56c30c..49651a2 100644 > --