Re: [PATCH] TODO: Add --nobacktrace removal task

2012-09-27 Thread Patrik Flykt
Applied, Patrik ___ connman mailing list connman@connman.net http://lists.connman.net/listinfo/connman

Re: [PATCH v4] log: Disable stack trace from command line

2012-09-27 Thread Patrik Flykt
On Wed, 2012-09-26 at 16:01 +0300, patrik.fl...@linux.intel.com wrote: > From: Patrik Flykt > > Add a '--nobacktrace' command line switch to let the system > handle stack traces. The default is to let ConnMan handle them > as before Patch has been applied. Patrik _

Re: [PATCH] test: Fix PrefixLength setting in set-ipv6-method

2012-09-27 Thread Patrik Flykt
On Wed, 2012-09-26 at 13:11 +0300, Tomasz Bursztyka wrote: > --- > test/set-ipv6-method | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) Patch has been applied, thanks! Patrik ___ connman mailing list connman@connman.net http://lis

Re: [PATCH] ipconfig: Fix IPv6.Configuration parsing

2012-09-27 Thread Patrik Flykt
On Mon, 2012-09-24 at 15:04 +0300, Tomasz Bursztyka wrote: > PrefixLength is exposed as a byte in the API, but code was waiting for a > string > when setting a new value. Patch has been applied, thanks! Patrik ___ connman mailing list connman@

Auto time updates even TimeUpdates is not auto.

2012-09-27 Thread Danny Jeongseok Seo
Dears, I have tested NTP with Clock.Timeservers. When I switched Clock.TimeUpdates as "manual", however, ConnMan always updates system time automatically. Regardless of TimeUpdates which is either manual or auto. Is there any correct way to turn the "automatic time update" on and off? Many Th

Re: [RFC v0 1/4] session: Update sessions on config updates

2012-09-27 Thread Daniel Wagner
On 27.09.2012 16:46, Daniel Wagner wrote: From: Daniel Wagner Give the policy plugin a way to inform the session core that some of the config values have changed. This could be done in a more clever way, e.g. figure out only to update the necessary info entries. It is not expected that there

[RFC v0 4/4] session_policy: Retrieve SELinux context

2012-09-27 Thread Daniel Wagner
From: Daniel Wagner --- plugins/session_policy.c | 85 ++-- 1 file changed, 75 insertions(+), 10 deletions(-) diff --git a/plugins/session_policy.c b/plugins/session_policy.c index e0c1887..3f530bd 100644 --- a/plugins/session_policy.c +++ b/plugins/s

[RFC v0 3/4] session: Add connman_session_get_owner()

2012-09-27 Thread Daniel Wagner
From: Daniel Wagner --- include/session.h | 2 ++ src/session.c | 5 + 2 files changed, 7 insertions(+) diff --git a/include/session.h b/include/session.h index f178bb4..7bd8ce7 100644 --- a/include/session.h +++ b/include/session.h @@ -86,6 +86,8 @@ void connman_session_config_update(s

[RFC v0 2/4] gdbus: Add GetConnectionSELinuxSecurityContext

2012-09-27 Thread Daniel Wagner
From: Daniel Wagner --- Makefile.am | 2 +- gdbus/gdbus.h | 9 +++ gdbus/selinux.c | 169 3 files changed, 179 insertions(+), 1 deletion(-) create mode 100644 gdbus/selinux.c diff --git a/Makefile.am b/Makefile.am index 8693752

[RFC v0 0/4] Session: Identify with SELinux

2012-09-27 Thread Daniel Wagner
From: Daniel Wagner Hi, This is just work in progres. If you have an idea how we could find out at runtime how two destinguish between a policy->create() call which should just return a default config and one which will use the SELinux part and then read a config from the disk, then please tell

[RFC v0 1/4] session: Update sessions on config updates

2012-09-27 Thread Daniel Wagner
From: Daniel Wagner Give the policy plugin a way to inform the session core that some of the config values have changed. This could be done in a more clever way, e.g. figure out only to update the necessary info entries. It is not expected that there are many updates so let's keep it simple for

[PATCH v1 6/6] session: Register session after policy plugin return config

2012-09-27 Thread Daniel Wagner
From: Daniel Wagner Move the configuration part of __connman_session_create() into session_create_cb(). With this change the policy plugin is able to do async work to retrieve a configuration. --- src/session.c | 185 -- 1 file changed, 101

[PATCH v1 5/6] manager: Allow async CreateSession method call

2012-09-27 Thread Daniel Wagner
From: Daniel Wagner The creation of a new session might be deferred. This happens in the case where a policy plugin has to do some work async. For example the plugin might have to ask a D-Bus config daemon. --- src/manager.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --g

[PATCH v1 4/6] session: Factor out memore release part of cleanup_session

2012-09-27 Thread Daniel Wagner
From: Daniel Wagner We want to use this code snippet for the error case in __connman_session_create() too. --- src/session.c | 23 ++- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/src/session.c b/src/session.c index f5d3a6d..314a51d 100644 --- a/src/session.

[PATCH v1 3/6] session: Factor out user settings in __connman_session_create()

2012-09-27 Thread Daniel Wagner
From: Daniel Wagner --- src/session.c | 50 ++ 1 file changed, 34 insertions(+), 16 deletions(-) diff --git a/src/session.c b/src/session.c index 8957c71..f5d3a6d 100644 --- a/src/session.c +++ b/src/session.c @@ -1543,6 +1543,14 @@ static const G

[PATCH v1 2/6] session: Add callback to policy create()

2012-09-27 Thread Daniel Wagner
From: Daniel Wagner Instead returning directly a config when create() is called in policy plugin, use a callback function for handing over a valid configuration from the plugin to the session core. This prepars support for asynchronize create call. --- include/session.h| 9 +++-- pl

[PATCH v1 0/6] Decouple session create and config call

2012-09-27 Thread Daniel Wagner
From: Daniel Wagner Hi, This version will even work asynchronosly :) I'll have tested this with my SELinux patches which I'll send next. cheers, daniel Daniel Wagner (6): session: Handle destruction of policy during shutdown session: Add callback to policy create() session: Factor out u

[PATCH v1 1/6] session: Handle destruction of policy during shutdown

2012-09-27 Thread Daniel Wagner
From: Daniel Wagner During shutdown, e.g. ctrl-c was issued by the user, pugins are removed first. The policy plugin will destroy the associated policy config, therefore there is no need to do it later. Accessing the session->policy NULL pointer later is not a good idea anyway. --- src/session.

Re: [PATCH v0 5/5] session: Split __connman_session_create()

2012-09-27 Thread Daniel Wagner
This patch has two issues: - Error handling for invalid D-Bus arguments is not correct - Need to take the ref on the D-Bus message I do some more testing, maybe there is even more hidden. ___ connman mailing list connman@connman.net http

[PATCH v0 5/5] session: Split __connman_session_create()

2012-09-27 Thread Daniel Wagner
From: Daniel Wagner Move the configuration part of __connman_session_create() into session_create_cb(). With this change the policy plugin is able to do async work to retrieve a configuration. --- src/session.c | 166 ++ 1 file changed, 87

[PATCH v0 4/5] session: Factor out memore release part of cleanup_session

2012-09-27 Thread Daniel Wagner
From: Daniel Wagner We want to use this code snippet for the error case in __connman_session_create() too. --- src/session.c | 23 ++- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/src/session.c b/src/session.c index f5d3a6d..314a51d 100644 --- a/src/session.

[PATCH v0 3/5] session: Factor out user settings in __connman_session_create()

2012-09-27 Thread Daniel Wagner
From: Daniel Wagner --- src/session.c | 50 ++ 1 file changed, 34 insertions(+), 16 deletions(-) diff --git a/src/session.c b/src/session.c index 8957c71..f5d3a6d 100644 --- a/src/session.c +++ b/src/session.c @@ -1543,6 +1543,14 @@ static const G

[PATCH v0 2/5] session: Add callback to policy create()

2012-09-27 Thread Daniel Wagner
From: Daniel Wagner Instead returning directly a config when create() is called in policy plugin, use a callback function for handing over a valid configuration from the plugin to the session core. This prepars support for asynchronize create call. --- include/session.h| 9 +++-- pl

[PATCH v0 1/5] session: Handle destruction of policy during shutdown

2012-09-27 Thread Daniel Wagner
From: Daniel Wagner During shutdown, e.g. ctrl-c was issued by the user, pugins are removed first. The policy plugin will destroy the associated policy config, therefore there is no need to do it later. Accessing the session->policy NULL pointer later is not a good idea anyway. --- src/session.

[PATCH v0 0/5] Decouple session config call

2012-09-27 Thread Daniel Wagner
From: Daniel Wagner Hi, The policy plugin create call gets a callback which contains then the valid configuration. For this __connman_session_create() is splitted into two halfs. The first one allocated the necessary data structures and then ask for the configuration. The plugin can then do so

[PATCH 3/3] gdbus: Refactor filter_data_find()

2012-09-27 Thread Lucas De Marchi
Now this function is only used for searching the listeners of a connection and the other parameters are not needed anymore. --- gdbus/watch.c | 43 +-- 1 file changed, 5 insertions(+), 38 deletions(-) diff --git a/gdbus/watch.c b/gdbus/watch.c index 2661928

[PATCH 2/3] gdbus: Fix wrong signal handler match

2012-09-27 Thread Lucas De Marchi
When we add a signal handler with g_dbus_add_signal_watch(), this function tries to multiplex the matches added in libdbus by checking if there's a previous filter_data with the same fields. However, if the field is NULL it accepts as being the same. The result is that the following watches will us

[PATCH 1/3] gdbus: Fix crash when getting disconnected from the bus

2012-09-27 Thread Lucas De Marchi
From: Johan Hedberg When getting disconnected from the bus sometimes (maybe always?) dbus_watch_handle() can cause the "info" context to be free'd meaning that we should not try to access it after the call. The only member we need access to is the connection pointer and as the code already has a

[PATCH 0/3] gdbus patches

2012-09-27 Thread Lucas De Marchi
These patches were applied to BlueZ repository. Please, have a look and apply them on other projects. Johan Hedberg (1): gdbus: Fix crash when getting disconnected from the bus Lucas De Marchi (2): gdbus: Fix wrong signal handler match gdbus: Refactor filter_data_find() gdbus/mainloop.c |

Re: [PATCH v2 00/34] Session Policy Plugin

2012-09-27 Thread Daniel Wagner
An updated version with all small issues fixed is pushed. Time for new patches :) ___ connman mailing list connman@connman.net http://lists.connman.net/listinfo/connman

Connman upstream test result_20120927

2012-09-27 Thread Li, XiaX
Hi all, This is test report for connman-1.7.7.gf6b4a7c-1.1.i586. In this testing,we ran 113 cases. 111 cases passed and 2 cases failed because of known bugs. The pass rate is 98%. We found 1 new bug, reopen 0 bug and verify 2 bugs. In this commit we found the bug that there is error message after

Re: [PATCH v2 12/34] session: Move get config calls after basic session initialization

2012-09-27 Thread Patrik Flykt
On Wed, 2012-09-26 at 14:10 +0200, Daniel Wagner wrote: > owner ship Extra space in between. Patrik ___ connman mailing list connman@connman.net http://lists.connman.net/listinfo/connman

Re: [PATCH v2 09/34] session_policy: Set plugin priority to low

2012-09-27 Thread Patrik Flykt
On Wed, 2012-09-26 at 14:10 +0200, Daniel Wagner wrote: > From: Daniel Wagner > > --- > plugins/session_policy.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/plugins/session_policy.c b/plugins/session_policy.c > index b001ea8..acbf154 100644 > --- a/plugins/session_policy.c > +++ b/

Re: [PATCH v2 08/34] session: Add plugin priority

2012-09-27 Thread Patrik Flykt
On Wed, 2012-09-26 at 14:10 +0200, Daniel Wagner wrote: > In order to Nitpick: Just say "Support serveral..." Patrik ___ connman mailing list connman@connman.net http://lists.connman.net/listinfo/connman

Re: [PATCH v2 10/34] session: Remove global configuration plugin

2012-09-27 Thread Patrik Flykt
On Wed, 2012-09-26 at 14:10 +0200, Daniel Wagner wrote: > And support per session configuration plugin. Nitpick: Expand the "And" here with e.g. "Implement support for per session..." or someghing so it's obvious what is happening. Patrik ___