Re: [PATCH] gdhcp: Returned IP is already in host byte order

2012-10-15 Thread Patrik Flykt
On fre, 2012-10-12 at 20:13 +0300, Jukka Rissanen wrote: --- gdhcp/ipv4ll.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Applied, thanks! Patrik ___ connman mailing list connman@connman.net

[PATCH 1/2] gresolv: Avoid accessing already freed memory

2012-10-15 Thread Jukka Rissanen
We must remove the lookup from lookup queue and query from query queue before calling user callback. The callback might unref the GResolv which in turn would remove the lookup/query what we are trying to access after the callback is returned. So it is enough to remove the lookup or query entry

[PATCH 0/2] gresolv fixes

2012-10-15 Thread Jukka Rissanen
Hi, the commit 9f0fc7962603344d071f5f34caf9e4efb8707940 exposed more problems in gresolv.c that this patchset is trying to fix. In patch #1 we remove the lookup or query from queue before calling result callback. This is needed as the callback might remove the gresolv object which would also

[PATCH 2/2] gresolv: Remove all pending lookups when resolver is removed

2012-10-15 Thread Jukka Rissanen
Remove all lookups found in queue when GResolv object is removed. --- gweb/gresolv.c | 4 1 file changed, 4 insertions(+) diff --git a/gweb/gresolv.c b/gweb/gresolv.c index 440f43c..fd4cf10 100644 --- a/gweb/gresolv.c +++ b/gweb/gresolv.c @@ -866,6 +866,7 @@ GResolv *g_resolv_ref(GResolv

[PATCH - v3 00/11] Technology: Handle fully and properly rfkill events

2012-10-15 Thread Tomasz Bursztyka
Hi, Here is a 3rd version. Almost same as before: Fixed patch 2 so it checks hardblocked status if only rfkill_driven is true. Tested by Alok against cellular, which was not rfkill driven, and it works. Tomasz Bursztyka (11): technology: Refactor how technology is set to enable or disable

[PATCH - v3 01/11] technology: Refactor how technology is set to enable or disable

2012-10-15 Thread Tomasz Bursztyka
Factorize how a device list is enabled/disabled: this will be useful for coming patches. Simplify also the code, and remove useless gotos. --- src/technology.c | 66 1 file changed, 28 insertions(+), 38 deletions(-) diff --git

[PATCH - v3 02/11] technology: Add a marker to know if a technology is rfkill driven

2012-10-15 Thread Tomasz Bursztyka
Useful for coming patches: enabling/disabling technologies will be done differently whether technology is rfkill driven or not: - if rfkill driven - enabled will rely on rfkill states - if not - enabled will rely on driver/devices states --- src/technology.c | 13 ++--- 1 file changed, 10

[PATCH - v3 03/11] technology: Add and handle a marker for softblock status

2012-10-15 Thread Tomasz Bursztyka
--- src/technology.c | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/src/technology.c b/src/technology.c index 11bf0c0..16324c9 100644 --- a/src/technology.c +++ b/src/technology.c @@ -74,6 +74,7 @@ struct connman_technology { GSList *scan_pending;

[PATCH - v3 04/11] technology: Refactor rfkill event handling according to soft/hard block

2012-10-15 Thread Tomasz Bursztyka
No need to proceed with softblocked if technology is already hardblocked. Apply offlinemode and persistant state according to softblocked state. (saner logic and helped to cleanup code from style point of view too) --- src/technology.c | 57 ++--

[PATCH - v3 05/11] technology: Refactor and split functions setting enabled state

2012-10-15 Thread Tomasz Bursztyka
--- src/technology.c | 54 +- 1 file changed, 29 insertions(+), 25 deletions(-) diff --git a/src/technology.c b/src/technology.c index 8c736ea..345dcab 100644 --- a/src/technology.c +++ b/src/technology.c @@ -1200,41 +1200,37 @@ static void

[PATCH - v3 06/11] technology: Change enabled as a boolean and refactor accordingly

2012-10-15 Thread Tomasz Bursztyka
--- src/technology.c | 45 - 1 file changed, 20 insertions(+), 25 deletions(-) diff --git a/src/technology.c b/src/technology.c index 345dcab..d2c074e 100644 --- a/src/technology.c +++ b/src/technology.c @@ -55,7 +55,7 @@ struct connman_technology {

[PATCH - v3 07/11] technology: Use the right method to enable or disable

2012-10-15 Thread Tomasz Bursztyka
If rfkill driven, it will use rfkill soft block/unblock. If not it will request the device to get enabled or disabled. --- src/technology.c | 49 +++-- 1 file changed, 27 insertions(+), 22 deletions(-) diff --git a/src/technology.c b/src/technology.c

[PATCH - v3 08/11] device: Add a getter for powered property

2012-10-15 Thread Tomasz Bursztyka
--- include/device.h | 1 + src/device.c | 5 + 2 files changed, 6 insertions(+) diff --git a/include/device.h b/include/device.h index 5339e98..470059b 100644 --- a/include/device.h +++ b/include/device.h @@ -80,6 +80,7 @@ const char *connman_device_get_ident(struct connman_device

[PATCH - v3 09/11] technology: Handle fully and properly rfkill driven state

2012-10-15 Thread Tomasz Bursztyka
--- src/technology.c | 52 +++- 1 file changed, 43 insertions(+), 9 deletions(-) diff --git a/src/technology.c b/src/technology.c index 4ae5b86..44eeb13 100644 --- a/src/technology.c +++ b/src/technology.c @@ -1198,6 +1198,9 @@ int

[PATCH - v3 10/11] technology: Recompute hardblocked state on rfkill remove event

2012-10-15 Thread Tomasz Bursztyka
This fixes the case of cascading rfkill switches: if enabled, hard rfkilling such technology might generate contradictory events. 1 - first all switches are hardblocked 2 - then one of these switch (usually: device's switch) gets fully unblocked 3 - then this same switch gets removed Step 2 is

[PATCH - v3 11/11] technology: Fix hardblocked state on non hw rfkillable switch added

2012-10-15 Thread Tomasz Bursztyka
If harblocked and a new device is inserted and detected as not hardblocked, then it will be possible to enable/disable it (soft rfkill) independantly to the main hw rfkill switch. --- src/technology.c | 30 +- 1 file changed, 17 insertions(+), 13 deletions(-) diff

[PATCH - v2 0/2] Interface readiness, scan and device refcount issue

2012-10-15 Thread Tomasz Bursztyka
Hi, Same patch set as before but rewritten so we remove the superfluous call to g_supplicant_interface_get_ready() While testing further the issue fixed by my previous patch: [PATCH v2] gsupplicant: Adding a new state according to 'interface_disabled' I figured out that, if the interface

[PATCH - v2 2/2] wifi: Do not start autoscan if interface cannot do anything

2012-10-15 Thread Tomasz Bursztyka
--- plugins/wifi.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/plugins/wifi.c b/plugins/wifi.c index 2984de0..631d0cc 100644 --- a/plugins/wifi.c +++ b/plugins/wifi.c @@ -516,7 +516,10 @@ static void scan_callback(int result, GSupplicantInterface *interface,

[PATCH - v2 1/2] gsupplicant: Interpret unreadiness as an error on scan result

2012-10-15 Thread Tomasz Bursztyka
--- gsupplicant/supplicant.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/gsupplicant/supplicant.c b/gsupplicant/supplicant.c index 477106b..cd1225e 100644 --- a/gsupplicant/supplicant.c +++ b/gsupplicant/supplicant.c @@ -2700,12 +2700,20 @@ static void