[PATCH v3 0/3] Start tethering automatically

2013-04-24 Thread Jukka Rissanen
Hi, v3: - changed the name of the main.conf variable in patch 1 and 2 - fixed the tethering status when enabling and disabling technology v2: this v2 version adds main.conf option for starting tethering automatically. By default the tethering is not auto started. Cheers, Jukka Jukka

[PATCH v3 1/3] conf: Add description of PersistentTetheringMode

2013-04-24 Thread Jukka Rissanen
--- src/main.conf | 5 + 1 file changed, 5 insertions(+) diff --git a/src/main.conf b/src/main.conf index a0608d4..7e509f7 100644 --- a/src/main.conf +++ b/src/main.conf @@ -85,3 +85,8 @@ # This is a dangerous setting so the default value is false. # Do not activate this unless you really

[PATCH v3 2/3] main: Add support for PersistentTetheringMode configuration variable

2013-04-24 Thread Jukka Rissanen
--- src/main.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/src/main.c b/src/main.c index 016e52d..5e738cf 100644 --- a/src/main.c +++ b/src/main.c @@ -71,6 +71,7 @@ static struct { connman_bool_t allow_hostname_updates; connman_bool_t single_tech;

[PATCH v3 3/3] technology: Auto start tethering if enabled and configured

2013-04-24 Thread Jukka Rissanen
If the user has enabled persistent tethering mode in main.conf, then try to activate tethering when technology is re-enabled, or we are returning from offline mode, or after the device has rebooted. --- src/technology.c | 185 +++ 1 file

Re: [PATCH v3 3/3] technology: Auto start tethering if enabled and configured

2013-04-24 Thread Daniel Wagner
Hi Jukka, On 04/24/2013 12:31 PM, Jukka Rissanen wrote: If the user has enabled persistent tethering mode in main.conf, then try to activate tethering when technology is re-enabled, or we are returning from offline mode, or after the device has rebooted. --- src/technology.c | 185

Re: [PATCH v3 3/3] technology: Auto start tethering if enabled and configured

2013-04-24 Thread Jukka Rissanen
Hi Daniel, On 24.04.2013 15:05, Daniel Wagner wrote: Hi Jukka, On 04/24/2013 12:31 PM, Jukka Rissanen wrote: If the user has enabled persistent tethering mode in main.conf, then try to activate tethering when technology is re-enabled, or we are returning from offline mode, or after the device

[PATCH v2 0/6] Add support for ethernet tethering

2013-04-24 Thread Jukka Rissanen
Hi, v2: - Removed patch 1, the proper fix for the issue in in patch 4. Thanks to Patrik for pointing this out. v1: this patchset adds support for ethernet tethering. By default user is not allowed to tether ethernet as it can cause havoc in the network. In ethernet tethering ConnMan starts a

[PATCH v2 1/6] conf: Add description of AllowEthernetTethering

2013-04-24 Thread Jukka Rissanen
--- src/main.conf | 9 + 1 file changed, 9 insertions(+) diff --git a/src/main.conf b/src/main.conf index 2985613..a0608d4 100644 --- a/src/main.conf +++ b/src/main.conf @@ -76,3 +76,12 @@ # setting enabled applications will notice more network breaks than # normal. Default value is

[PATCH v2 2/6] main: Add support for AllowEthernetTethering configuration variable

2013-04-24 Thread Jukka Rissanen
--- src/main.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/src/main.c b/src/main.c index a76ec3b..016e52d 100644 --- a/src/main.c +++ b/src/main.c @@ -70,6 +70,7 @@ static struct { char **blacklisted_interfaces; connman_bool_t allow_hostname_updates;

[PATCH v2 3/6] device: Add support functions needed by ethernet tethering

2013-04-24 Thread Jukka Rissanen
--- include/device.h | 3 +++ src/device.c | 43 +++ 2 files changed, 46 insertions(+) diff --git a/include/device.h b/include/device.h index b372821..3382575 100644 --- a/include/device.h +++ b/include/device.h @@ -113,6 +113,9 @@ int

[PATCH v2 4/6] rtnl: Interface was added to technology too early

2013-04-24 Thread Jukka Rissanen
The __connman_technology_add_interface() needs to be called after we have created the technology which is done by rtnl-newlink() callback. If this is done the old way, the ethernet devices will not get their interfaces set properly. --- src/rtnl.c | 14 -- 1 file changed, 12

Re: [PATCH][connman-gnome] icons: fix icons which have subtle compresion problems

2013-04-24 Thread Patrik Flykt
On Fri, 2013-04-19 at 11:51 +0100, Ross Burton wrote: These icons appear to have been compressed with a broken tool that results in an IDAT that claims it needs a 512 byte window, but reaches backwards 1500 bytes in the stream. libpng 1.6 is fine with this as zlib can still reach that

[PATCH v2 5/6] ethernet: Add tethering support

2013-04-24 Thread Jukka Rissanen
--- plugins/ethernet.c | 101 - 1 file changed, 100 insertions(+), 1 deletion(-) diff --git a/plugins/ethernet.c b/plugins/ethernet.c index 6a20eb2..ac5033f 100644 --- a/plugins/ethernet.c +++ b/plugins/ethernet.c @@ -39,6 +39,9 @@ #include

[PATCH v2 6/6] technology: Check if ethernet tethering is allowed

2013-04-24 Thread Jukka Rissanen
Return EOPNOTSUPP if user tries to activate ethernet tethering and AllowEthernetTethering variable is not set in main.conf --- src/technology.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/technology.c b/src/technology.c index f15fbd9..62950e7 100644 --- a/src/technology.c +++

Re: [PATCH v1 0/9] Add UID/GID support to session policies

2013-04-24 Thread Daniel Wagner
All patches also available here: https://github.com/bmwcarit/connman/tree/secmark-v5 FWIW, I have now splited out the last big patch in v5 into smaller pieces. Also I cleanup a bit more in the patches which go on top of this series. The result can be seen here:

[PATCH 0/2] Manual pages into dist tar ball

2013-04-24 Thread Jukka Rissanen
Hi, this patchset install connmand and connman.conf manual pages into dist tar ball. The connmanctl man pages is still left out as its syntax is still fluctuating a bit. Also updated the connman.conf with the latest additions in main.conf file. Cheers, Jukka Jukka Rissanen (2): man: Update

[PATCH 1/2] man: Update connman.conf.5 manual page

2013-04-24 Thread Jukka Rissanen
Updated PreferredTechnologies description. Added SingleConnectedTechnology, AllowEthernetTethering and PersistentTetheringMode descriptions. --- doc/connman.conf.5 | 39 +-- 1 file changed, 33 insertions(+), 6 deletions(-) diff --git a/doc/connman.conf.5

[PATCH 2/2] build: Install connmand and connman.conf manual pages

2013-04-24 Thread Jukka Rissanen
--- Makefile.am | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile.am b/Makefile.am index cb532a3..4680b8e 100644 --- a/Makefile.am +++ b/Makefile.am @@ -226,7 +226,7 @@ include Makefile.plugins if CLIENT noinst_PROGRAMS += client/connmanctl -MANUAL_PAGES +=

Re: [PATCH v2 1/6] conf: Add description of AllowEthernetTethering

2013-04-24 Thread Marcel Holtmann
Hi Jukka, --- src/main.conf | 9 + 1 file changed, 9 insertions(+) diff --git a/src/main.conf b/src/main.conf index 2985613..a0608d4 100644 --- a/src/main.conf +++ b/src/main.conf @@ -76,3 +76,12 @@ # setting enabled applications will notice more network breaks than # normal.

Re: [PATCH v3 1/3] conf: Add description of PersistentTetheringMode

2013-04-24 Thread Marcel Holtmann
Hi Jukka, src/main.conf | 5 + 1 file changed, 5 insertions(+) diff --git a/src/main.conf b/src/main.conf index a0608d4..7e509f7 100644 --- a/src/main.conf +++ b/src/main.conf @@ -85,3 +85,8 @@ # This is a dangerous setting so the default value is false. # Do not activate this

Re: [PATCH v3 1/3] conf: Add description of PersistentTetheringMode

2013-04-24 Thread Patrik Flykt
On Wed, 2013-04-24 at 07:12 -0700, Marcel Holtmann wrote: +# PersistentTetheringMode = false is ..Mode the right name here? I was just making a proposal for the general direction. Should this be PersistentTetheringStatus or something similar. Any thoughts from others? I think

Re: [PATCH v1 2/9] session_policy_local: Refactor SELinux context parser

2013-04-24 Thread Patrik Flykt
On Tue, 2013-04-23 at 14:23 +0200, Daniel Wagner wrote: From: Daniel Wagner daniel.wag...@bmw-carit.de g_strplit() will eventually strdup the tokens so no need to strdup() 'context'. But we an ugly cast (from 'const unsigned char *' to 'const char *') is needed for g_strsplit() to make the

Re: [PATCH v2 1/6] conf: Add description of AllowEthernetTethering

2013-04-24 Thread Jukka Rissanen
Hi Marcel, On 24 April 2013 17:11, Marcel Holtmann mar...@holtmann.org wrote: the name of this setting is in general fine with me. However we might want to think about if we don't want to have generic list of allowed tethering technologies. I do want to keep the main.conf options to a

Re: DHCPv6 client compliance to RFCs.

2013-04-24 Thread harshal patel
Hi, While verifying conformance, I found following Violation of RFC 3315. As per Section RFC 3315 15.1 Use of Transaction IDs: A client MUST leave the transaction ID unchanged in retransmissions of a message. However, in my case when ConnMan starts sending Info-Req, it changes Transaction ID