Re: [RFC v4 00/15] Session autoconnect

2013-09-02 Thread Daniel Wagner
Hi Patrik, On 08/30/2013 01:00 PM, Patrik Flykt wrote: Hi, The first patch is a cleanup for the current autoconnect behavior. It makes the code more readable and does not change any functionality nor is it needed for the rest of the code. The second patch is a fix for the test case wher

Re: [PATCH 0/5] Boolean length issue

2013-09-02 Thread Daniel Wagner
On 09/02/2013 12:14 PM, Patrik Flykt wrote: On Mon, 2013-09-02 at 09:47 +0300, Tomasz Bursztyka wrote: Here are my findings about boolean length issues. Patrik has some also to come. Applied all patches, thanks! Thanks for taking care. I am pretty sure at one point in the series I had those

Re: [RFC v4 06/15] service: Reorganize service autoconnect function

2013-09-02 Thread Daniel Wagner
Hi Patrik, On 08/30/2013 01:00 PM, Patrik Flykt wrote: Reorganize the service autoconnect function so that adding session support becomes easier. Move service connecting functionality inside the for loop and replace the goto and the break with a continue and a return. Could you move that patch

Re: [RFC v4 05/15] session: Indicate service types used by a connected session

2013-09-02 Thread Daniel Wagner
Hi Patrik, just a nitpick below. On 08/30/2013 01:00 PM, Patrik Flykt wrote: Add or remove bearers when a session is to be connected or disconnected. Sessions just passively listening to connections will not affect service autoconnection. --- src/session.c | 31 +

Re: [PATCH] config: Allow omitting gateway from IPv4 and IPv6 setting

2013-09-02 Thread Patrik Flykt
On Fri, 2013-08-30 at 15:16 +0300, Jukka Rissanen wrote: > --- > doc/config-format.txt | 8 ++-- > src/config.c | 24 +++- > 2 files changed, 17 insertions(+), 15 deletions(-) Applied, thanks. Patrik ___ connma

Re: [PATCH 0/7] Misc service and ipconfig fixes

2013-09-02 Thread Patrik Flykt
On Fri, 2013-08-30 at 14:52 +0300, Jukka Rissanen wrote: > Hi, > > while fixing ethernet .config IP address provisioning, > I noticed some crashes when ethernet was provisioned. > The issues are timing sensitive so they are not happening > always. All patches applied, thanks! Patrik

Re: [PATCH v2] bluetooth: Use dbus_bool_t when accessing a D-Bus boolean

2013-09-02 Thread Patrik Flykt
On Mon, 2013-09-02 at 12:49 +0300, Patrik Flykt wrote: > --- > v2: Shorter and nicer Applied. Patrik ___ connman mailing list connman@connman.net https://lists.connman.net/mailman/listinfo/connman

Re: [PATCH] vpn-provider: ProtocolFamily is an int32

2013-09-02 Thread Patrik Flykt
On Mon, 2013-09-02 at 10:14 +0300, Patrik Flykt wrote: > --- > vpn/vpn-provider.c |7 +-- > 1 file changed, 5 insertions(+), 2 deletions(-) Applied. Patrik ___ connman mailing list connman@connman.net https://lists.connman.net/mailman/l

Re: [PATCH 0/5] Boolean length issue

2013-09-02 Thread Patrik Flykt
On Mon, 2013-09-02 at 09:47 +0300, Tomasz Bursztyka wrote: > Here are my findings about boolean length issues. > Patrik has some also to come. Applied all patches, thanks! Patrik ___ connman mailing list connman@connman.net https://lists.connman

Re: [PATCH] ofono: Remove unused struct variable

2013-09-02 Thread Patrik Flykt
On Mon, 2013-09-02 at 10:14 +0300, Patrik Flykt wrote: > --- > plugins/ofono.c |1 - > 1 file changed, 1 deletion(-) Applied. Patrik ___ connman mailing list connman@connman.net https://lists.connman.net/mailman/listinfo/connman

[PATCH v2] bluetooth: Use dbus_bool_t when accessing a D-Bus boolean

2013-09-02 Thread Patrik Flykt
--- v2: Shorter and nicer plugins/bluetooth.c |5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/plugins/bluetooth.c b/plugins/bluetooth.c index 0df83f9..0d027e9 100644 --- a/plugins/bluetooth.c +++ b/plugins/bluetooth.c @@ -297,6 +297,7 @@ static void btnetwork_property_c

[PATCH] vpn-provider: ProtocolFamily is an int32

2013-09-02 Thread Patrik Flykt
--- vpn/vpn-provider.c |7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/vpn/vpn-provider.c b/vpn/vpn-provider.c index 7b53f71..1769e53 100644 --- a/vpn/vpn-provider.c +++ b/vpn/vpn-provider.c @@ -211,10 +211,13 @@ static GSList *read_route_dict(GSList *routes, DBusMes

[PATCH] ofono: Remove unused struct variable

2013-09-02 Thread Patrik Flykt
--- plugins/ofono.c |1 - 1 file changed, 1 deletion(-) diff --git a/plugins/ofono.c b/plugins/ofono.c index 939cd7f..1036a38 100644 --- a/plugins/ofono.c +++ b/plugins/ofono.c @@ -169,7 +169,6 @@ struct modem_data { /* ConnectionContext Interface */ bool active; - boo

[PATCH] bluetooth: Use dbus_bool_t when accessing a D-Bus boolean

2013-09-02 Thread Patrik Flykt
--- plugins/bluetooth.c |8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/plugins/bluetooth.c b/plugins/bluetooth.c index 0df83f9..dc48aaa 100644 --- a/plugins/bluetooth.c +++ b/plugins/bluetooth.c @@ -297,6 +297,7 @@ static void btnetwork_property_change(GDBusProxy *pr