[PATCH] service: Reply to disconnection from association and configuration states

A D-Bus reply to the client calling Connect() has been properly sent when entering ready and failure states and a also on a proper disconnect when calling __connman_service_disconnect(). But when a service enters disconnect state from either association or configuration states, sending of the

[PATCH v2] service: Reply to disconnection from association and configuration states

A D-Bus reply to the client calling Connect() has been properly sent when entering ready and failure states and a also on a proper disconnect when calling __connman_service_disconnect(). But when a service enters disconnect state from either association or configuration states, sending of the

Re: [PATCH v2] device: Make sure the device is up and running before enabling it

Hi Pasi, connmand[2510]: src/device.c:__connman_device_enable() device 0x1cc9d10 connmand[2510]: src/device.c:__connman_device_enable() device 0x1cc9d10, err -19 Can you print also the device index to see it's value? Tomasz ___ connman mailing list

Re: [PATCH v2] service: Reply to disconnection from association and configuration states

On Fri, 2014-08-15 at 11:06 +0300, Patrik Flykt wrote: A D-Bus reply to the client calling Connect() has been properly sent when entering ready and failure states and a also on a proper disconnect when calling __connman_service_disconnect(). But when a service enters disconnect state from

Re: [PATCH 2/2] wifi: Start P2P find if there's no ongoing discovery

Hi Eduardo, Just to avoid an amount of p2p_call, if another is already taking place. --- gsupplicant/gsupplicant.h | 2 ++ gsupplicant/supplicant.c | 8 plugins/wifi.c| 8 +++- 3 files changed, 17 insertions(+), 1 deletion(-) Can you split this patch in 2? first

[PATCH] dhcp: Check that network is not NULL before unreferencing

--- src/dhcp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/dhcp.c b/src/dhcp.c index 6839d1f..4436164 100644 --- a/src/dhcp.c +++ b/src/dhcp.c @@ -622,7 +622,8 @@ int __connman_dhcp_start(struct connman_ipconfig *ipconfig, err = dhcp_initialize(dhcp);

[PATCH 2/3] config: Netmask length cannot be zero

--- src/config.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/config.c b/src/config.c index 330ae81..9aa7da5 100644 --- a/src/config.c +++ b/src/config.c @@ -399,7 +399,7 @@ static bool load_service_generic(GKeyFile *keyfile, char *ptr;

[PATCH 0/3] Three Coverity fixes

Hi, Three fixes for Wagi's Coverity check round. The rand(om) ones need some more thought, and not checking the return value should be ok unless I missed something. The first patch was sent to the list by itself already, but I decided to collect it here also/instead. Cheers,

[PATCH 3/3] plugins: Netmask length cannot be zero

--- plugins/vpn.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/vpn.c b/plugins/vpn.c index 25711d7..e6e4c8e 100644 --- a/plugins/vpn.c +++ b/plugins/vpn.c @@ -1078,7 +1078,7 @@ static struct vpn_route *parse_user_route(const char *user_route)

[PATCH 1/3] dhcp: Check that network is not NULL before unreferencing

--- src/dhcp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/dhcp.c b/src/dhcp.c index 6839d1f..4436164 100644 --- a/src/dhcp.c +++ b/src/dhcp.c @@ -622,7 +622,8 @@ int __connman_dhcp_start(struct connman_ipconfig *ipconfig, err = dhcp_initialize(dhcp);

RE: [PATCH v2] device: Make sure the device is up and running before enabling it

Hi Tomasz, connmand[2510]: src/device.c:__connman_device_enable() device 0x1cc9d10 connmand[2510]: src/device.c:__connman_device_enable() device 0x1cc9d10, err -19 Can you print also the device index to see it's value? connmand[21072]: src/device.c:__connman_device_enable() device 0x1326e98,

[PATCH 0/3] Some improvement in p2p find

Hi, Patchset v2 with Tomasz's recommendation. The following patchset tries to improve the peer discovery, by antecipating p2p find start, if requested, despite a wifi scan running. Furthermore, detects if there's an ongoing p2p find and returns earlier. Thanks for feedback from Tomasz

[PATCH 2/3] supplicant: Added a function to detect if p2p is finding

Just a getter for p2p_finding status. --- gsupplicant/gsupplicant.h | 1 + gsupplicant/supplicant.c | 8 2 files changed, 9 insertions(+) diff --git a/gsupplicant/gsupplicant.h b/gsupplicant/gsupplicant.h index 207e281..28cfe10 100644 --- a/gsupplicant/gsupplicant.h +++

[PATCH 3/3] wifi: Start P2P find if there's no ongoing discovery

Just to avoid an amount of p2p_call, if another is already taking place. --- plugins/wifi.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/plugins/wifi.c b/plugins/wifi.c index f741bec..f5af702 100644 --- a/plugins/wifi.c +++ b/plugins/wifi.c @@ -1376,7 +1376,7 @@

Re: [PATCH v2] device: Make sure the device is up and running before enabling it

Hi Pasi, connmand[2510]: src/device.c:__connman_device_enable() device 0x1cc9d10 connmand[2510]: src/device.c:__connman_device_enable() device 0x1cc9d10, err -19 Can you print also the device index to see it's value? connmand[21072]: src/device.c:__connman_device_enable() device 0x1326e98,

[PATCH] device: Do not try to bring up an invalid device index

In certain case, the device structure exists but is not related to any device index. This fixes this issue: connmand[2510]: plugins/ofono.c:modem_probe() /ril_0 device 0x1cc9d10 connmand[2510]: src/technology.c:__connman_technology_add_device() device 0x1cc9d10 type Cellular connmand[2510]:

Re: [PATCH 0/3] Some improvement in p2p find

Thanks Eduardo, ACK on this patch-set. Tomasz ___ connman mailing list connman@connman.net https://lists.connman.net/mailman/listinfo/connman

Re: [PATCH 2/3] supplicant: Added a function to detect if p2p is finding

Very minor nitpick here: supplicant: Added a function to detect if p2p is finding -- gsupplicant: Add a function to detect if p2p is finding ___ connman mailing list connman@connman.net https://lists.connman.net/mailman/listinfo/connman

Re: [PATCH 2/3] supplicant: Added a function to detect if p2p is finding

Oh, sorry, Tomasz. Should I resend the patchet? On Fri, Aug 15, 2014 at 7:15 AM, Tomasz Bursztyka tomasz.burszt...@linux.intel.com wrote: Very minor nitpick here: supplicant: Added a function to detect if p2p is finding -- gsupplicant: Add a function to detect if p2p is finding

Re: [PATCH 2/3] supplicant: Added a function to detect if p2p is finding

On Fri, 2014-08-15 at 07:29 -0400, Eduardo Abinader wrote: Should I resend the patchet? I'll fix in when applying. Cheers, Patrik ___ connman mailing list connman@connman.net https://lists.connman.net/mailman/listinfo/connman

Re: [PATCH 2/3] supplicant: Added a function to detect if p2p is finding

Thanks, Patrik. On Aug 15, 2014 7:31 AM, Patrik Flykt patrik.fl...@linux.intel.com wrote: On Fri, 2014-08-15 at 07:29 -0400, Eduardo Abinader wrote: Should I resend the patchet? I'll fix in when applying. Cheers, Patrik ___ connman

Re: [PATCH 0/3] Three Coverity fixes

On Fri, 2014-08-15 at 13:29 +0300, Patrik Flykt wrote: Hi, Three fixes for Wagi's Coverity check round. The rand(om) ones need some more thought, and not checking the return value should be ok unless I missed something. The first patch was sent to the list by itself already, but I

Re: [PATCH] device: Do not try to bring up an invalid device index

On Fri, 2014-08-15 at 14:13 +0300, Tomasz Bursztyka wrote: In certain case, the device structure exists but is not related to any device index. Applied, thanks! Patrik ___ connman mailing list connman@connman.net

Re: [PATCH 0/3] Some improvement in p2p find

On Fri, 2014-08-15 at 07:07 -0400, Eduardo Abinader wrote: Hi, Patchset v2 with Tomasz's recommendation. The following patchset tries to improve the peer discovery, by antecipating p2p find start, if requested, despite a wifi scan running. Furthermore, detects if there's an ongoing p2p

[PATCH] peer: Make sure to disconnect relevandly on idle state transition

In case of cancelling the connection, idle will be set, but we might be in the middle of a connection so ensuring it properly cleans via calling disconnect. --- src/peer.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/peer.c b/src/peer.c index 33364e2..55531ce 100644 --- a/src/peer.c

Re: [PATCH] peer: Make sure to disconnect relevandly on idle state transition

On Fri, 2014-08-15 at 15:08 +0300, Tomasz Bursztyka wrote: In case of cancelling the connection, idle will be set, but we might be in the middle of a connection so ensuring it properly cleans via calling disconnect. Applied, thanks! Patrik