Re: question: settings and profiles for connman

2014-09-02 Thread Patrik Flykt
Hi, On Fri, 2014-08-29 at 15:01 +0200, Benjamin Block wrote: I just wanted to ask, if it is possible to configure connman in a way that I can switch to specific settings depending on the location I am at (no problem if I have to trigger this switch) and maybe fall back to dhcpcd or

Re: [PATCH] ipconfig: Do not pass a NULL pointer to D-Bus

2014-09-02 Thread Patrik Flykt
On Fri, 2014-08-29 at 10:00 +0300, Hannu Mallat wrote: connman_inet_ifname() may return a NULL pointer e.g. if the interface does not exist in the kernel anymore but connman isn't yet aware of that. Passing a NULL pointer to D-Bus may result in an abort, so check the return value. Applied,

Re: [PATCH] peer: Add debug msg for peer state

2014-09-02 Thread Patrik Flykt
On Thu, 2014-08-28 at 23:41 -0400, Eduardo Abinader wrote: In order to ease the debug task of peer state changes, inserted this old state/new state track. Applied, thanks! Patrik ___ connman mailing list connman@connman.net

Re: [PATCH] service: Change service state before changing manager state

2014-09-02 Thread Patrik Flykt
Hi, On Thu, 2014-08-28 at 15:44 +0800, Chengyi Zhao wrote: The manager state is a global connection state of the system, and it is a result of evaluating various notification states. In order to ensure the consistency of data, ConnMan should change the service state before

[PATCH 0/2] Clean group interface and mapping

2014-09-02 Thread Eduardo Abinader
When a p2p group is finished, the peers holding the just removed group interface shall be updated accordingly. The same must happen to group_mapping, as the p2p group was finished. Eduardo Abinader (2): gsupplicant: Remove peer group interface when group finished gsupplicant: Update

[PATCH 2/2] gsupplicant: Update group_mapping when group finished

2014-09-02 Thread Eduardo Abinader
Just updating group_mapping accordingly, as a p2p group has been signaled as finished. --- gsupplicant/supplicant.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/gsupplicant/supplicant.c b/gsupplicant/supplicant.c index 903def7..9796fe8 100644 --- a/gsupplicant/supplicant.c +++

[PATCH 1/2] gsupplicant: Remove peer group interface when group finished

2014-09-02 Thread Eduardo Abinader
When a p2p group has finished, update corresponding peers group interface. --- gsupplicant/supplicant.c | 27 +++ 1 file changed, 27 insertions(+) diff --git a/gsupplicant/supplicant.c b/gsupplicant/supplicant.c index 049a5b2..903def7 100644 --- a/gsupplicant/supplicant.c

Re: [PATCH 0/2] Clean group interface and mapping

2014-09-02 Thread Tomasz Bursztyka
Hi Eduardo, ACK on this patch-set Thanks, Tomasz ___ connman mailing list connman@connman.net https://lists.connman.net/mailman/listinfo/connman

Re: [PATCH 0/2] Clean group interface and mapping

2014-09-02 Thread Patrik Flykt
On Tue, 2014-09-02 at 08:23 -0400, Eduardo Abinader wrote: When a p2p group is finished, the peers holding the just removed group interface shall be updated accordingly. The same must happen to group_mapping, as the p2p group was finished. ...and applied. Thanks! Patrik

Re: [PATCH 0/8] Code cleanups

2014-09-02 Thread Patrik Flykt
On Thu, 2014-08-28 at 15:10 +0300, Patrik Flykt wrote: Here is a set of cleanup patches. The first four are not supposed to change any functionality but instead provide a bit better readability in the code. Patches 02, 04, 03 and 01 applied in this order. Patrik

Re: question: settings and profiles for connman

2014-09-02 Thread Benjamin Block
Hej, On 09:47 Tue 02 Sep , Patrik Flykt wrote: On Fri, 2014-08-29 at 15:01 +0200, Benjamin Block wrote: I just wanted to ask, if it is possible to configure connman in a way that I can switch to specific settings depending on the location I am at (no problem if I have to trigger

[PATCH] service: Move dbg on service_schedule_removed after sanity check

2014-09-02 Thread Eduardo Abinader
Avoid an invalid read by moving debug message after sanity check. --- src/service.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/service.c b/src/service.c index f5c0a23..d5f95ed 100644 --- a/src/service.c +++ b/src/service.c @@ -4358,13 +4358,13 @@ static void

[PATCH] gsupplicant: Add property calls to property_calls list

2014-09-02 Thread Eduardo Abinader
Although the logic for handling property call list was available, the property call list was not being populated. --- gsupplicant/dbus.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/gsupplicant/dbus.c b/gsupplicant/dbus.c index 130306e..4ff5d50 100644 --- a/gsupplicant/dbus.c +++