[PATCH] agent: Check for pointer validity before cancelling agent request

In the case where agent disappears from D-Bus while there are pending requests, request->driver may become null. As it's useless to send a Cancel to a nonexistent agent, not to mention accessing null pointer causes a crash, check for the pointer value before creating a D-Bus message. --- src/agent

Re: [PATCH] Release references to technologies held by rfkill during cleanup.

Hi, On Tue, 2014-10-21 at 12:27 -0500, David Lechner wrote: > --- > src/connman.h| 1 + > src/rfkill.c | 2 ++ > src/technology.c | 15 +++ > 3 files changed, 18 insertions(+) > > diff --git a/src/connman.h b/src/connman.h > index da01215..bab013b 100644 > ---

Re: [PATCH] Release references to technologies held by rfkill during cleanup.

Hi, On Tue, 2014-10-21 at 12:31 -0500, David Lechner wrote: > I have written a UI for connman an ran into an bug when restarting > connman. When restarting, most technologies send the TechnologyRemoved > signal via DBus. Bluetooth, however, never sent this signal, so when > connman res

[PATCH 1/2] test/wait-for-ready: wait for an interface to be ready

Adds a script that exits with success when state changes to "ready" --- Makefile.am | 2 +- test/wait-for-ready | 41 + 2 files changed, 42 insertions(+), 1 deletion(-) create mode 100755 test/wait-for-ready diff --git a/Makefile.am b/Makefile.am

[PATCH 2/2] connman-wait-online.service.in: systemd service that waits for network

Create a systemd service that uses test/wait-for-ready to wait for any interface to be in the 'ready' or 'online' state. This service will be pulled by network-online.target. This is similar to NetworkManager-wait-online.service as provided by network manager and systemd-networkd-wait-online.servi

[PATCH] proxy: remove timeout on proxy cleanup

Make sure the timeout source is cleaned when proxy_lookup struct is deallocated. --- src/proxy.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/proxy.c b/src/proxy.c index 0d1a25a..f331de9 100644 --- a/src/proxy.c +++ b/src/proxy.c @@ -44,6 +44,9 @@ struct proxy_lo

Re: [PATCH] agent: Check for pointer validity before cancelling agent request

Hi, On Wed, 2014-10-22 at 11:09 +0300, Hannu Mallat wrote: > In the case where agent disappears from D-Bus while there are pending > requests, request->driver may become null. As it's useless to send a > Cancel to a nonexistent agent, not to mention accessing null pointer > causes a crash

Re: [PATCH] agent: Check for pointer validity before cancelling agent request

On 22.10.2014 13:04, Patrik Flykt wrote: Mmmm, but the above can only happen in Jolla's version of ConnMan, there is/was commit 81195279ed07af08caf8c44fc390840b54b19ce2 in the Mer/Jolla tree that caused ->driver to become NULL in some special circumstances. Ah, you're correct. Forgot about tha

Re: [PATCH v2] config: Handle IN_MOVED_TO inotify event

On Tue, 2014-10-21 at 15:59 +0300, Tomasz Bursztyka wrote: > If the user moves a .config to /var/lib/connman which happens to be on > the same fs, this will raise IN_MOVED_FROM/IN_MOVE_TO inotify events > and not IN_DELETE/IN_CREATE. Applied, thanks! Patrik __

Re: [PATCH 2/2] connman-wait-online.service.in: systemd service that waits for network

Hi, On Wed, 2014-10-22 at 11:21 +0200, Noé Rubinstein wrote: > Create a systemd service that uses test/wait-for-ready to wait for any > interface to be in the 'ready' or 'online' state. This service will be > pulled by network-online.target. > > This is similar to NetworkManager-wait-onl

Bridging

Hello, Is it possible to bridge an interface that is managed by connman (e.g. wlan0) and an interface that is not managed by connman? Does connman provide something like: brctl addbr bridge brctl addif bridge wlan0 brctl addif bridge other Would it be possible to have connman manage the bridge?

Re: [PATCH] Release references to technologies held by rfkill during cleanup.

On 10/22/2014 03:14 AM, Patrik Flykt wrote: So it seems ConnMan is not doing the technology_put() cleanup in the correct place. As you noticed this currently happens only in __connman_technology_remove(), and not on shutdown where only free_rfkill() is called. So the code starting with the line "

[PATCH] Add support for PANU and GN roles to Bluetooth.

--- plugins/bluetooth.c | 42 +++--- 1 file changed, 27 insertions(+), 15 deletions(-) diff --git a/plugins/bluetooth.c b/plugins/bluetooth.c index 82217d0..29e828d 100644 --- a/plugins/bluetooth.c +++ b/plugins/bluetooth.c @@ -36,7 +36,9 @@ #define BLUEZ_SE