Re: [PATCH 6/6] service: Implement ClearProperty properly

2015-10-19 Thread Patrik Flykt
Hi, Thanks for these patches. I'm going to add text from the cover letter to this patch and nitpick on clearing AutoConnect below. On Thu, 2015-10-15 at 10:41 +0300, Jaakko Hannikainen wrote: > The previous implementation only cleared Error, which as per > documentation is wrong since Er

[PATCH 4/4] dnsproxy: don't do captive addr for loopback queries

2015-10-19 Thread Craig McQueen
--- src/dnsproxy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/dnsproxy.c b/src/dnsproxy.c index 45ecd69..37e9605 100644 --- a/src/dnsproxy.c +++ b/src/dnsproxy.c @@ -3554,7 +3554,7 @@ static bool udp_listener_event(GIOChannel *channel, GIOCondition condition,

[PATCH 1/4] dnsproxy: Added captive portal possibility

2015-10-19 Thread Craig McQueen
From: Alexandre Chataignon --- This is Alexandre's original patch. I have only changed the title slightly. src/connman.h| 4 ++- src/dnsproxy.c | 79 src/technology.c | 7 - src/tethering.c | 22 ++-- 4 files ch

[PATCH 3/4] Funcs to check if address is loopback or link-local

2015-10-19 Thread Craig McQueen
Use these functions in the code to simplify the logic. --- This is a possibly generically useful change. Note that the code in __connman_inet_get_running_interfaces() was a bit confusing -- the code for the IPv6 case checked for a link-local address, not a loopback address as the comment said.

[PATCH 2/4] dnsproxy: Fixes to captive portal implementation.

2015-10-19 Thread Craig McQueen
* Avoid corruption of response to a query that includes "additional" records (e.g. OPT). * Provide an A record response to only an A record query. --- src/dnsproxy.c | 115 ++- src/technology.c | 2 +- 2 files changed, 90 insertions(+), 27 de

[PATCH 0/4] Added captive portal possibility

2015-10-19 Thread Craig McQueen
The following patches are related to the captive portal code originally provided by Alexandre Chataignon. The first patch is a copy of the original patch, provided again as a reference. The 3 following patches are improvements I made following a review of Alexandre's patch, to improve the follo

RE: [PATCH] Added captive portal possibility

2015-10-19 Thread Craig McQueen
On 19-Oct-2015 7:29 PM Alexandre Chataignon wrote: > On 10/16/2015 07:52 AM, Craig McQueen wrote: > > I'm interested in this concept. I applied your patch to ConnMan 1.30, and > I've been testing it. > > > > In my testing with DNS queries using the Linux 'dig' utility, I found it > > returns > mal

Re: [RFC 1/3] ofono: create a list of contexts per modem

2015-10-19 Thread Mylène JOSSERAND
Hi Patrik, Thank you for the time you spent on my patches. 2015-10-19 14:16 GMT+02:00 Patrik Flykt : > > Hi, > > On Fri, 2015-10-09 at 08:37 +0200, Mylene JOSSERAND wrote: > > This is a first patch of a serie to implement a simultaneous APNs > context activation. > > > > The current co

Re: [RFC 1/3] ofono: create a list of contexts per modem

2015-10-19 Thread Patrik Flykt
Hi, On Fri, 2015-10-09 at 08:37 +0200, Mylene JOSSERAND wrote: > This is a first patch of a serie to implement a simultaneous APNs context > activation. > > The current commit removes the previous implementation of one context per > modem and > adds a list of contexts instead. As this

Re: Hidden network issue

2015-10-19 Thread Wawrzek Niewodniczanski
On 19 October 2015 at 11:31, Patrik Flykt wrote: > On Mon, 2015-10-19 at 11:14 +0100, Wawrzek Niewodniczanski wrote: >> Hello, >> >> Some time ago I asked about connection to hidden network. One of the >> information I remember was that following following identifier is >> wrong: >>

[RFC 8/8] doc: Move man pages under automake

2015-10-19 Thread Jaakko Hannikainen
This change prettifies man pages with and /var/lib so that it will show the actual value connman was compiled with, rather than just hinting at some magical compile time variable. --- .gitignore | 8 ++-- Makefile.am

[RFC 7/8] doc: Add connman-vpn-provider.config.5

2015-10-19 Thread Jaakko Hannikainen
--- Makefile.am | 3 +- doc/connman-vpn-provider.config.5 | 424 ++ doc/connman-vpn.8 | 3 +- doc/connmanctl.1 | 4 +- 4 files changed, 430 insertions(+), 4 deletions(-) create mode 100644 doc/connman

[RFC 0/8] Man page overhaul

2015-10-19 Thread Jaakko Hannikainen
This patchset rewrites half of the existing man pages and adds 4 new ones, since the old ones were either badly formatted, incomplete or simply wrong. It also moves them under automake so that end users will see proper paths to connman's files instead of suggesting that they are probably under /var

[RFC 3/8] doc: Rewrite connmanctl.1

2015-10-19 Thread Jaakko Hannikainen
The 2.5 year old version has tons of outdated info and is badly formatted. Rewrite the man page for up to date information, better formatting and examples. --- doc/connmanctl.1 | 301 +++ 1 file changed, 193 insertions(+), 108 deletions(-) diff

[RFC 1/8] doc: Use preferred formatting in connman.8

2015-10-19 Thread Jaakko Hannikainen
Presenting arguments in the format -W driver[,...] is preferred over -W driver1,driver2,... so use it instead. Change the modification date to -MM-DD. Update the copyright date. Show examples on their own line. Add an additional See Also -manpage. --- doc/connman.8 | 41 +--

[RFC 5/8] doc: Add connman-vpn.conf.5

2015-10-19 Thread Jaakko Hannikainen
--- Makefile.am| 2 +- doc/connman-vpn.8 | 2 +- doc/connman-vpn.conf.5 | 50 ++ 3 files changed, 52 insertions(+), 2 deletions(-) create mode 100644 doc/connman-vpn.conf.5 diff --git a/Makefile.am b/Makefile.am index 9193231..31

[RFC 6/8] doc: Add connman-service.config.5

2015-10-19 Thread Jaakko Hannikainen
--- Makefile.am | 2 +- doc/connman-service.config.5 | 197 +++ doc/connman.8| 3 +- doc/connmanctl.1 | 3 +- 4 files changed, 202 insertions(+), 3 deletions(-) create mode 100644 doc/connman-service.config

[RFC 2/8] doc: Reformat connman.conf.5

2015-10-19 Thread Jaakko Hannikainen
Reformat the man page for main.conf according to common man page conventions. In addition, add an example section with a simple configuration example. Update copyright and last modification dates. --- doc/connman.conf.5 | 51 ++- 1 file changed, 30 i

[RFC 4/8] doc: Add connman-vpn.8

2015-10-19 Thread Jaakko Hannikainen
--- Makefile.am | 6 -- doc/connman-vpn.8 | 62 +++ doc/connman.8 | 2 +- doc/connmanctl.1 | 2 +- 4 files changed, 68 insertions(+), 4 deletions(-) create mode 100644 doc/connman-vpn.8 diff --git a/Makefile.am b/Makefile.am i

Re: WPA2 connection problem

2015-10-19 Thread Patrik Flykt
Hi, On Mon, 2015-10-19 at 09:57 +, Wawrzek Niewodniczanski wrote: > I try to connected to Enterprise WPA2 and what I see in console is: > 'Could not connect net.connman.Error.InvalidArguments: Invalid > arguments' WPA2 EAP networks need to be configured using doc/config-format.txt. A

Re: Hidden network issue

2015-10-19 Thread Patrik Flykt
On Mon, 2015-10-19 at 11:14 +0100, Wawrzek Niewodniczanski wrote: > Hello, > > Some time ago I asked about connection to hidden network. One of the > information I remember was that following following identifier is > wrong: >wifi_70188ba36ecd_hidden_managed_psk > > One of

[PATCH] vpn: Fix wrong VPN parameters

2015-10-19 Thread Jaakko Hannikainen
Some VPN parameters are mistyped in the source, fix them and update documentation. Add deprecated-label to OpenVPN.TLSRemote. --- I went through all of the VPN parameters, and I believe the parameters are correct now (I don't have means to properly test them). Turns out xl2tpd.conf's man page is ac

Hidden network issue

2015-10-19 Thread Wawrzek Niewodniczanski
Hello, Some time ago I asked about connection to hidden network. One of the information I remember was that following following identifier is wrong: wifi_70188ba36ecd_hidden_managed_psk One of suggestion that time was to ancient version of connman. So now I retry is somethi

Re: [PATCH] gdhcp: Remove unnecessary operation on lease seconds

2015-10-19 Thread Patrik Flykt
On Thu, 2015-10-08 at 16:39 +0300, Patrik Flykt wrote: > Lease seconds will not overflow, they are specified as a delta from > now to a point in the future. Therefore no truncation of the > received value is necessary. Applied. Patrik ___ connm

Re: [PATCH] Added captive portal possibility

2015-10-19 Thread Alexandre Chataignon
On 10/19/2015 11:40 AM, Patrik Flykt wrote: I was thinking of any connection going to e.g. port 80 would be forced to the locally used x.x.x.1 address on the tether interface. Like an automatic proxy solution. This can then be refined to work only for a subset of hosts, by looking up e.g. www.goo

WPA2 connection problem

2015-10-19 Thread Wawrzek Niewodniczanski
Hi, I try to connected to Enterprise WPA2 and what I see in console is: 'Could not connect net.connman.Error.InvalidArguments: Invalid arguments' I'm using: connmand - 1.30 from Arch repo How can I debug it? Thanks, Wawrzek -- Dr Wawrzyniec Niewodniczańskior Wawrzek for short PhD in

Re: Timezone doesn't update when /etc/localtime symlink changes

2015-10-19 Thread Patrik Flykt
Hi, On Thu, 2015-10-15 at 11:28 +1100, Craig McQueen wrote: > That doesn't sound right -- it looks as though there's code in > timezone.c to watch the file for changes. __connman_timezone_init() > sets up an inotify on /etc. When inotify triggers it calls > inotify_data(). If the file th

Re: [PATCH] Added captive portal possibility

2015-10-19 Thread Patrik Flykt
Hi, On Mon, 2015-10-19 at 10:26 +0200, Alexandre Chataignon wrote: > This solution was the first I implemented (no need to modify connman > source code). > > The problem is that in your case, DNS requests are answered by a remote > DNS server. However, as I said, the tethering mode he

Re: [PATCH] Added captive portal possibility

2015-10-19 Thread Alexandre Chataignon
On 10/16/2015 07:52 AM, Craig McQueen wrote: I'm interested in this concept. I applied your patch to ConnMan 1.30, and I've been testing it. In my testing with DNS queries using the Linux 'dig' utility, I found it returns malformed responses. That is because the 'dig' query includes an additio

Re: [PATCH] Added captive portal possibility

2015-10-19 Thread Alexandre Chataignon
On 10/19/2015 09:55 AM, Patrik Flykt wrote: A captive portal is easier to implement by setting a NAT rule that redirects incoming connections to a desired port on the local x.x.x.1 tethering interface. Once the captive portal stuff is cleared out, the redirecting NAT rule for that host can be mod

Re: [PATCH] Added captive portal possibility

2015-10-19 Thread Patrik Flykt
On Fri, 2015-10-16 at 16:52 +1100, Craig McQueen wrote: > So the patch would need to be improved as follows: > > * Check that the query first question is for an A record, and only > send an A record if so. > * Calculate the correct length of the query header and question > record(s), in order to p

Re: [PATCH] Added captive portal possibility

2015-10-19 Thread Patrik Flykt
Hi, On Wed, 2015-09-23 at 11:20 +0200, Alexandre Chataignon wrote: > This patch adds the possibility to enable a captive portal while connman > is in tethering mode by sending its own IP via the DNS proxy (which acts > as a DNS server more than a proxy in this case). > > I needed this

Re: Enable/disable Wi-Fi tethering when Wi-Fi dongle is not plugged in

2015-10-19 Thread Patrik Flykt
Hi, On Thu, 2015-10-15 at 13:37 +1100, Craig McQueen wrote: > I'm setting PersistentTetheringMode = true in /etc/connman/main.conf. > I'm also providing an initial /var/lib/connman/settings which contains > parameters for WiFi tethering enabled. So when a user plugs in a Wi-Fi > USB dongl

Re: How to provide DHCP on a technology

2015-10-19 Thread Patrik Flykt
On Thu, 2015-10-15 at 09:26 +, John Ernberg wrote: > > USB Host USB Gadget > > +--+ +--+ > > | eth0| | | > > |ES|USB cable |Dev | > > | usb0|--|usb0 | > > +--