Re: [PATCH 1/5] dnsproxy: Rename append_domain() to append_or_remove_domain()

2015-11-02 Thread Patrik Flykt
On Thu, 2015-10-29 at 01:29 +0200, pasi.sjoh...@jolla.com wrote: > From: Pasi Sjöholm > > A new append_domain()- and remove_domain()-functions which both > call append_or_remove_domain()-function by setting boolean append- > variable accordingly. > > This enables a

Re: Ordering of NameServers is not always respected

2015-11-01 Thread Patrik Flykt
On Sat, 2015-10-31 at 17:21 +, Sam Nazarko wrote: > I think this is non standard behaviour -- DNS servers should be > written in the same order received from DHCP. If this is not the case, > then DNS ordering should at least be identical regardless of whether > DNS is being proxied or not.

Re: ConnMan doesn't clear rfkill softblock when Wi-Fi plugged in after start-up

2015-10-30 Thread Patrik Flykt
On Fri, 2015-10-30 at 12:28 +1100, Craig McQueen wrote: > Consider this pre-condition: > > * ConnMan is configured for Wi-Fi enabled and tethered. > * USB Wi-Fi device is not plugged in. > * Linux rfkill softblock is enabled for wlan. ConnMan follows the external softblock state. So if something

Re: Wi-Fi service won't auto-connect when Ethernet is already present

2015-10-30 Thread Patrik Flykt
On Fri, 2015-10-30 at 14:18 +1100, Craig McQueen wrote: > I'm using ConnMan v1.30 on a BeagleBone Black based system. I've got a > USB Wi-Fi device, as well as Ethernet. > > Is it possible to configure ConnMan so that it will auto-connect Wi-Fi > even if it's got an Ethernet connection? Ethernet

[RFC 4/5] src: Add tmpfiles.d support for resolv.conf

2015-10-30 Thread Patrik Flykt
Add tmpfiles.d support for unconditionally creating a symlink from [/var]/run/connman/resolv.conf to /etc/resolv.conf. To keep the same behavior as before, the configuration file is installed to tmpfiles.d. If /etc/resolv.conf behavior needs to be specified differently by a distribution, do not

[RFC 2/5] build: Use runstatedir instead of deriving it from localstatedir

2015-10-30 Thread Patrik Flykt
With $(runstatedir) being defined, use it instead of $(localstatedir)/run. --- Makefile.am | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile.am b/Makefile.am index 4319c4c..96abab7 100644 --- a/Makefile.am +++ b/Makefile.am @@ -161,8 +161,8 @@ endif CLEANFILES =

[RFC 0/5] Move resolv.conf to /run/connman

2015-10-30 Thread Patrik Flykt
are updated to use $(runstatedir) in patch 2/5. Please review and comment, Patrik Patrik Flykt (5): build: Define runstatedir build: Use runstatedir instead of deriving it from localstatedir resolver: Create STATEDIR and use it when writing resolv.conf src: Add tmpfiles.d support

[RFC 3/5] resolver: Create STATEDIR and use it when writing resolv.conf

2015-10-30 Thread Patrik Flykt
Create STATEDIR [/var]/run/connman and unconditionally write resolv.conf to this directory. --- src/main.c | 6 ++ src/resolver.c | 2 +- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/src/main.c b/src/main.c index e46fa7b..6cf6bc8 100644 --- a/src/main.c +++ b/src/main.c

[RFC 1/5] build: Define runstatedir

2015-10-30 Thread Patrik Flykt
Provide an m4 macro defining runstatedir as $(localstatedir)/var. This applies to automake versions < 2.70. --- .gitignore | 2 ++ configure.ac | 4 m4/configmake.m4 | 15 +++ 3 files changed, 21 insertions(+) create mode 100644 m4/configmake.m4 diff --git

[RFC 5/5] scripts: Handle link to resolv.conf in init script

2015-10-30 Thread Patrik Flykt
Add init script functionality to create a symlink by default from [/var]/run/connman/resolv.conf to /etc/resolv.conf. --- scripts/connman.in | 4 1 file changed, 4 insertions(+) diff --git a/scripts/connman.in b/scripts/connman.in index 1692b95..9cc5895 100644 --- a/scripts/connman.in +++

Re: connmanctl quitting before multiple return functions called

2015-10-29 Thread Patrik Flykt
Hi, On Thu, 2015-10-15 at 15:41 +1100, Craig McQueen wrote: > I agree, it would be best if connmanctl exits after all the method > calls have completed. I'd be happy to do a patch in principle, however > I'm new to this D-Bus stuff and unfamiliar with the connman codebase, > so at this

Re: [PATCH] connmanctl: Implement clock API with new clock commands

2015-10-29 Thread Patrik Flykt
Hi, On Thu, 2015-10-15 at 15:07 +1100, Craig McQueen wrote: > --- > > I'm not sure if you would like this use of commands. I'm interested not > only in _setting_ clock settings, but also in reading them conveniently. > The precedent in connmanctl is that there is one command to

Re: [PATCH 0/8] Man page overhaul

2015-10-28 Thread Patrik Flykt
On Mon, 2015-10-26 at 16:39 +0200, Jaakko Hannikainen wrote: > This patchset rewrites half of the existing man pages and adds 4 > new ones, since the old ones were either badly formatted, incomplete > or simply wrong. It also moves them under automake so that end users > will see proper paths to

Re: [PATCH] Set exit value in connmanctl

2015-10-28 Thread Patrik Flykt
Hi, On Tue, 2015-10-27 at 09:58 +0200, Mikko Tuumanen wrote: > --- > client/agent.c| 2 +- > client/commands.c | 27 +-- > client/dbus_helpers.c | 5 +++-- > client/input.c| 6 -- > client/input.h| 2 +- > 5 files changed, 30

Re: [PATCH] Set exit value in connmanctl

2015-10-28 Thread Patrik Flykt
On Tue, 2015-10-27 at 09:58 +0200, Mikko Tuumanen wrote: > --- > client/agent.c| 2 +- > client/commands.c | 27 +-- > client/dbus_helpers.c | 5 +++-- > client/input.c| 6 -- > client/input.h| 2 +- > 5 files changed, 30 insertions(+),

Re: [PATCH] unit: IP pools exist as long as they are referenced

2015-10-28 Thread Patrik Flykt
On Fri, 2015-10-23 at 14:59 +0300, Patrik Flykt wrote: > An IP pool exists after it has been created until it is unreferenced. > Make no assumptions that the ip pool address range will not be > re-assigned after it has ben unreferenced. > --- > > This behavior became obvious aft

Re: [PATCH 0/2] Keep same subnet when enabling/disabling tethering

2015-10-28 Thread Patrik Flykt
On Fri, 2015-10-23 at 14:38 +0300, Patrik Flykt wrote: > Hi, > > Here is a simple fix for reusing the same IPv4 subnet when tethering. > As before, the subnet is not guaranteed to always stay the same, but > with this change its previous value should be reused if nothin

Re: [PATCH] wifi: Reset device->scanning if scan has not returned in 15 secs

2015-10-28 Thread Patrik Flykt
Hi, On Fri, 2015-10-23 at 00:47 +0300, pasi.sjoh...@jolla.com wrote: > From: Pasi Sjöholm > > Due unknown reason sometimes device->scanning is not set to false after > wifi scanning (connman 1.30 and wpa_supplicant 2.5). > This is probably due

Re: [PATCH 8/8] doc: Move man pages under automake

2015-10-27 Thread Patrik Flykt
Hi, On Mon, 2015-10-26 at 16:40 +0200, Jaakko Hannikainen wrote: > --- a/Makefile.am > +++ b/Makefile.am > @@ -248,8 +248,6 @@ include Makefile.plugins > if CLIENT > bin_PROGRAMS += client/connmanctl > > -MANUAL_PAGES += doc/connmanctl.1 > - > client_connmanctl_SOURCES =

Re: [PATCH v2 2/2] Documentation change

2015-10-27 Thread Patrik Flykt
On Mon, 2015-10-26 at 20:41 -0700, Naveen Singh wrote: > From: nasingh > > Change the overview-api.txt to do the service transition from > failure state to idle. Applied, thanks! Patrik ___ connman

Re: [PATCH v2 1/2] Clear the Error property

2015-10-27 Thread Patrik Flykt
On Mon, 2015-10-26 at 20:41 -0700, Naveen Singh wrote: > From: nasingh > > It is been seen that if the service state has transitioned to failure > there is no way for it to get it back to idle. This fix allows the > state to be transitioned back to idle

Re: [PATCH 8/8] doc: Move man pages under automake

2015-10-27 Thread Patrik Flykt
On Tue, 2015-10-27 at 15:21 +0200, Patrik Flykt wrote: > --- a/Makefile.am > +++ b/Makefile.am > @@ -378,7 +378,12 @@ EXTRA_DIST += doc/overview-api.txt doc/behavior-api.txt \ > doc/vpn-config-format.txt \ > doc/vpn-con

[PATCH 8/8 v2] doc: Move man pages under automake

2015-10-27 Thread Patrik Flykt
From: Jaakko Hannikainen This change prettifies man pages with and /var/lib so that it will show the actual value connman was compiled with, rather than just hinting at some magical compile time variable. Add only the man page autoconf .in files to the dist tar

Re: [PATCH] Clear the Error property

2015-10-23 Thread Patrik Flykt
Hi, On Thu, 2015-10-22 at 22:30 -0700, Naveen Singh wrote: > From: nasingh > > It is been seen that if the service state has transitioned to failure > there is no way for it to get it back to idle. This fix allows the > state to be transitioned

[PATCH 0/2] Keep same subnet when enabling/disabling tethering

2015-10-23 Thread Patrik Flykt
ippool.c Cheers, Patrik Patrik Flykt (2): ippool: Try to assign the same subnet while tethering ippool: Remove unused hash table src/ippool.c | 45 +++-- 1 file changed, 15 insertions(+), 30 deletions(-) -- 2.1.4

[PATCH 1/2] ippool: Try to assign the same subnet while tethering

2015-10-23 Thread Patrik Flykt
When enabling and disabling tethering, the next available class C IPv4 subnet will be assigned and not the same one as last time. Fix this by starting with the last allocated block instead of unconditionally with the next free block. This way the subnet used for tethering will be the same as the

[PATCH 2/2] ippool: Remove unused hash table

2015-10-23 Thread Patrik Flykt
As IP pool structures were only added to and removed from the ippool_hash hash table, remove it as being unnecessary. Move freeing of pool data to the unref function. --- src/ippool.c | 39 --- 1 file changed, 12 insertions(+), 27 deletions(-) diff --git

[PATCH] unit: IP pools exist as long as they are referenced

2015-10-23 Thread Patrik Flykt
An IP pool exists after it has been created until it is unreferenced. Make no assumptions that the ip pool address range will not be re-assigned after it has ben unreferenced. --- This behavior became obvious after changing the ip pool allocation with the previous patches. Nevertheless, the unit

Re: [PATCH 0/4] Added captive portal possibility

2015-10-21 Thread Patrik Flykt
On Tue, 2015-10-20 at 14:14 +1100, Craig McQueen wrote: > The following patches are related to the captive portal code originally > provided by Alexandre Chataignon. The first patch is a copy of the > original patch, provided again as a reference. The 3 following patches > are improvements I

Re: Stale WPS state when authentication fails

2015-10-21 Thread Patrik Flykt
On Tue, 2015-10-20 at 16:06 -0700, Juha Kuikka wrote: > Hello, > > If I attempt to connect to a network using WPS (pin code or push button) > and the authentication fails it seems the "WiFi.UseWPS" flag never gets > reset. > > This causes the next connection attempt to default to the WPS mode

Re: DHCP & hostname faceplant

2015-10-21 Thread Patrik Flykt
Hi, On Thu, 2015-10-08 at 01:31 -0600, Daniel Wagner wrote: > I have uploaded two traces. Both created on my Linux machine. > > - This one is with an unmodified ConnMan: > >http://www.monom.org/connman/dhcp-not-working.pcapng > > - And this one is with a modified ConnMan which

Re: [PATCH v2] openvpn: Add MTU related options

2015-10-21 Thread Patrik Flykt
Hi, On Wed, 2015-10-21 at 12:12 +0200, Daniel Wagner wrote: > The use of the different MTU options depend on you server and link > configuration. I don't think you can derive it. OpenVPN seems to offer > an option to learn the MTU size by doing some measurements but that > takes around

Re: [PATCH] gdbus: move typedefs for interwork with strict compilers

2015-10-21 Thread Patrik Flykt
On Tue, 2015-10-20 at 23:44 -0700, Grant Erickson wrote: > Move enumeration type defintions AFTER the enumerations themselves are > declared > and defined such that the header works with strict compilers. Applied, thanks! Patrik ___ connman

Re: [PATCH v2] doc: Fix ClearProperty documentation

2015-10-21 Thread Patrik Flykt
On Wed, 2015-10-21 at 11:19 +0300, Patrik Flykt wrote: > ClearProperty applies only on the Error property and causes the > service to go to idle state. > --- > > Updated the text and noted that InvalidProperty is the only error that > can be returned. Applied. Now the imple

Re: [PATCH] service: Fix minor memory leak on exit

2015-10-21 Thread Patrik Flykt
On Tue, 2015-10-20 at 17:07 +0300, Slava Monich wrote: > services_notify->add and services_notify->remove are always created > and have to be always destroyed. Applied, thanks! Patrik ___ connman mailing list connman@connman.net

Re: WPA2 connection problem

2015-10-21 Thread Patrik Flykt
On Wed, 2015-10-21 at 09:55 +, Wawrzek Niewodniczanski wrote: > On 19 October 2015 at 10:45, Patrik Flykt <patrik.fl...@linux.intel.com> > wrote: > > > > Hi, > > > > On Mon, 2015-10-19 at 09:57 +, Wawrzek Niewodniczanski wrote: > >> I t

[PATCH v2] doc: Fix ClearProperty documentation

2015-10-21 Thread Patrik Flykt
ClearProperty applies only on the Error property and causes the service to go to idle state. --- Updated the text and noted that InvalidProperty is the only error that can be returned. doc/service-api.txt | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git

[PATCH] doc: Fix ClearProperty documentation

2015-10-20 Thread Patrik Flykt
ClearProperty applies only on the Error property and causes the service to go to idle state. --- doc/service-api.txt | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/doc/service-api.txt b/doc/service-api.txt index 88816d8..dca97cd 100644 --- a/doc/service-api.txt +++

Re: [RFC 4/8] doc: Add connman-vpn.8

2015-10-20 Thread Patrik Flykt
Hi, This fails distcheck with: make[2]: *** No rule to make target 'doc/connman-vpn.8', needed by 'all-am'. Stop. Makefile:1570: recipe for target 'all' failed make[1]: *** [all] Error 2 Makefile:5020: recipe for target 'distcheck' failed make: *** [distcheck] Error 1 result 2 On

Re: [PATCH v2] openvpn: Add MTU related options

2015-10-20 Thread Patrik Flykt
Hi, On Tue, 2015-10-20 at 14:26 +0200, Sven Schwedas wrote: > On 2015-10-20 14:04, Patrik Flykt wrote: > > Are any of these necessary for any use cases? If they are needed for > > something, could the currently specified OpenVPN.MTU be used to derive > > proper

Re: [RFC 8/8] doc: Move man pages under automake

2015-10-20 Thread Patrik Flykt
Hi, On Mon, 2015-10-19 at 13:50 +0300, Jaakko Hannikainen wrote: > This change prettifies man pages with and /var/lib > so that it will show the actual value connman was compiled with, > rather than just hinting at some magical compile time variable. > --- > .gitignore

Re: [PATCH] vpn: Fix wrong VPN parameters

2015-10-20 Thread Patrik Flykt
On Mon, 2015-10-19 at 13:16 +0300, Jaakko Hannikainen wrote: > Some VPN parameters are mistyped in the source, fix them > and update documentation. Add deprecated-label to > OpenVPN.TLSRemote. > --- > I went through all of the VPN parameters, and I believe the parameters are > correct now (I don't

Re: [PATCH] ipconfig: Ensure ifname is not null when setting ipv6 state

2015-10-20 Thread Patrik Flykt
On Sun, 2015-10-18 at 09:07 -0700, Abtin Keshavarzian wrote: > From: Abtin Keshavarzian > > This is a quick fix for the issue where removal of an interface may > cause IPv6 to be disabled/enabled on other interfaces. > When removing an ipdevice in free_ipdevice(), it is

Re: Enable/disable Wi-Fi tethering when Wi-Fi dongle is not plugged in

2015-10-19 Thread Patrik Flykt
Hi, On Thu, 2015-10-15 at 13:37 +1100, Craig McQueen wrote: > I'm setting PersistentTetheringMode = true in /etc/connman/main.conf. > I'm also providing an initial /var/lib/connman/settings which contains > parameters for WiFi tethering enabled. So when a user plugs in a Wi-Fi > USB

Re: [PATCH] Added captive portal possibility

2015-10-19 Thread Patrik Flykt
Hi, On Wed, 2015-09-23 at 11:20 +0200, Alexandre Chataignon wrote: > This patch adds the possibility to enable a captive portal while connman > is in tethering mode by sending its own IP via the DNS proxy (which acts > as a DNS server more than a proxy in this case). > > I needed this

Re: [PATCH] Added captive portal possibility

2015-10-19 Thread Patrik Flykt
On Fri, 2015-10-16 at 16:52 +1100, Craig McQueen wrote: > So the patch would need to be improved as follows: > > * Check that the query first question is for an A record, and only > send an A record if so. > * Calculate the correct length of the query header and question > record(s), in order to

Re: How to provide DHCP on a technology

2015-10-19 Thread Patrik Flykt
On Thu, 2015-10-15 at 09:26 +, John Ernberg wrote: > > USB Host USB Gadget > > +--+ +--+ > > | eth0| | | > > |ES|USB cable |Dev | > > | usb0|--|usb0 | > >

Re: [RFC 1/3] ofono: create a list of contexts per modem

2015-10-19 Thread Patrik Flykt
Hi, On Fri, 2015-10-09 at 08:37 +0200, Mylene JOSSERAND wrote: > This is a first patch of a serie to implement a simultaneous APNs context > activation. > > The current commit removes the previous implementation of one context per > modem and > adds a list of contexts instead. As

Re: [PATCH] gdhcp: Remove unnecessary operation on lease seconds

2015-10-19 Thread Patrik Flykt
On Thu, 2015-10-08 at 16:39 +0300, Patrik Flykt wrote: > Lease seconds will not overflow, they are specified as a delta from > now to a point in the future. Therefore no truncation of the > received value is necessary. Applied.

Re: WPA2 connection problem

2015-10-19 Thread Patrik Flykt
Hi, On Mon, 2015-10-19 at 09:57 +, Wawrzek Niewodniczanski wrote: > I try to connected to Enterprise WPA2 and what I see in console is: > 'Could not connect net.connman.Error.InvalidArguments: Invalid > arguments' WPA2 EAP networks need to be configured using doc/config-format.txt.

Re: [PATCH] Added captive portal possibility

2015-10-19 Thread Patrik Flykt
Hi, On Mon, 2015-10-19 at 10:26 +0200, Alexandre Chataignon wrote: > This solution was the first I implemented (no need to modify connman > source code). > > The problem is that in your case, DNS requests are answered by a remote > DNS server. However, as I said, the tethering mode

Re: Hidden network issue

2015-10-19 Thread Patrik Flykt
On Mon, 2015-10-19 at 11:14 +0100, Wawrzek Niewodniczanski wrote: > Hello, > > Some time ago I asked about connection to hidden network. One of the > information I remember was that following following identifier is > wrong: >wifi_70188ba36ecd_hidden_managed_psk > > One

Re: Timezone doesn't update when /etc/localtime symlink changes

2015-10-19 Thread Patrik Flykt
Hi, On Thu, 2015-10-15 at 11:28 +1100, Craig McQueen wrote: > That doesn't sound right -- it looks as though there's code in > timezone.c to watch the file for changes. __connman_timezone_init() > sets up an inotify on /etc. When inotify triggers it calls > inotify_data(). If the file

Re: [PATCH 6/6] service: Implement ClearProperty properly

2015-10-19 Thread Patrik Flykt
Hi, Thanks for these patches. I'm going to add text from the cover letter to this patch and nitpick on clearing AutoConnect below. On Thu, 2015-10-15 at 10:41 +0300, Jaakko Hannikainen wrote: > The previous implementation only cleared Error, which as per > documentation is wrong since

Re: service state transition to failure

2015-10-14 Thread Patrik Flykt
On Tue, 2015-10-13 at 14:42 -0700, Naveen Singh wrote: > There is nothing that application knows that connman does not know. > In fact application gets to know through connman that connection did > not go through. The way application gets connected back is to initiate > a scan and hoping that one

Re: service state transition to failure

2015-10-14 Thread Patrik Flykt
Hi, On Tue, 2015-10-13 at 23:24 -0700, Grant Erickson wrote: > Due to these constraints, the application knows best when to scan and > does so at its discretion. Neither connman nor wpa_s autoscan > infrastructure scan at the application-desired times. When they do > scan automatically,

Re: Enable/disable Wi-Fi tethering when Wi-Fi dongle is not plugged in

2015-10-14 Thread Patrik Flykt
On Wed, 2015-10-14 at 17:53 +1100, Craig McQueen wrote: > I am working on a system where a USB dongle is used for Wi-Fi > functionality. The Wi-Fi can be used in client or access point mode, > configurable. However, it seems it's not possible to enable/disable > tethering mode while the USB Wi-Fi

Re: How to provide DHCP on a technology

2015-10-14 Thread Patrik Flykt
On Wed, 2015-10-14 at 06:40 +, John Ernberg wrote: > I made a ramdisk out of /var/ when I made the file system read only. > Nothing is however preserved after a reboot, and that has not been > problem for me yet. That's actually a problem, as /var (especially /var/lib) is the only location

Re: Timezone doesn't update when /etc/localtime symlink changes

2015-10-14 Thread Patrik Flykt
Hi, On Wed, 2015-10-14 at 17:42 +1100, Craig McQueen wrote: > > In my target system, /etc/localtime is a symlink into the > appropriate file > > under /usr/share/zoneinfo. > > I've tried making /etc/localtime an ordinary file, rather than a > symlink. But still ConnMan doesn't notice

Re: connmanctl quitting before multiple return functions called

2015-10-14 Thread Patrik Flykt
Hi, On Wed, 2015-10-14 at 17:49 +1100, Craig McQueen wrote: > I've been looking into extending connmanctl's functionality with > configuration for the net.connman.Clock API. I've been developing a > command that can set clock properties, similar to the existing > "config" command. > >

Re: How to provide DHCP on a technology

2015-10-14 Thread Patrik Flykt
Hi, On Wed, 2015-10-14 at 13:09 +, John Ernberg wrote: > All I know is that cdc_ether interfaces shows up as usb0, the eth0 > ethernet is a real ethernet port. When looking in /sys/class/net/usb0 > it indeed shows up as a gadget in the uevent file. This now looks like you are

Re: service state transition to failure

2015-10-13 Thread Patrik Flykt
Hi, On Mon, 2015-10-12 at 21:46 -0700, Naveen Singh wrote: > In my previous email when I meant *"**User could be initiating scan" *I > actually meant "*Application could be initiating scan".* Well, don't. Now the responsibility of correct behavior is taken away from ConnMan and placed

Re: net.connman.Service setProperty

2015-10-13 Thread Patrik Flykt
On Tue, 2015-10-13 at 04:22 +, francobrun...@hotmail.com wrote: > Thanks. > > Are you able to change IPv4 configuration? I'm getting not supported error. 'IPv4.Configuration' is the property to change. On low-level the attribute is an 'sv' with the variant 'v' containing a dict which is of

Re: How to provide DHCP on a technology

2015-10-13 Thread Patrik Flykt
Hi, On Mon, 2015-10-12 at 14:26 +, John Ernberg wrote: > I'm using Connman in an embedded environment where a device will connect > to us over USB, this device will provide an ethernet interface on the > USB port, and the device will be in gadget mode. > Thus when they connect to

Re: How to provide DHCP on a technology

2015-10-13 Thread Patrik Flykt
Hi, On Tue, 2015-10-13 at 08:49 +, John Ernberg wrote: > ConnMan runs on the embedded system, which is the USB host side. > And when an USB gadget connects, I want to start a DHCP server on the > interface provided by cdc_ether so that the USB gadget that connects > can receive an

Re: service state transition to failure

2015-10-12 Thread Patrik Flykt
Hi, On Fri, 2015-10-09 at 10:52 -0700, Naveen Singh wrote: > This may not happen at all. My understanding is that wpa_supplicant would > time out only if the AP is not seen in subsequent scans. But the AP is > always found in scan as there is nothing wrong at 802.11 level. The user >

Re: service state transition to failure

2015-10-09 Thread Patrik Flykt
Hi, On Thu, 2015-10-08 at 13:25 -0700, Naveen Singh wrote: > I looked into the code and the documentation and I do not see any way for > service to go back to idle (even clearing the error property). I am not > sure how devices which are supposed to auto-connect handle this? This all

Re: service state transition to failure

2015-10-09 Thread Patrik Flykt
On Thu, 2015-10-08 at 13:30 -0700, Naveen Singh wrote: > 5. Now it is in failure state and will never be able to connect. It will be autoconnected once its state is no longer failure. The failure state is cleared once the service is removed. The service is removed once wpa_supplicant times out

Re: [PATCH] Resetting the service state to idle on Error event

2015-10-09 Thread Patrik Flykt
On Thu, 2015-10-08 at 18:33 -0700, Naveen Singh wrote: > From: Naveen Singh > > It is been seen that if the service state has transitioned to failure > there is no way for it to get it back to idle. This fix allows the state > to be transitioned back to idle as part of

Re: [PATCH] gdhcp:Remove unnecessary check

2015-10-08 Thread Patrik Flykt
On Mon, 2015-10-05 at 16:05 +0530, Maneesh Jain wrote: > Signed-off-by: Maneesh Jain Please explain in the commit message *why* the client_id check is unnecessary. Quickly looking at the code doesn't immediately reveal the reasoning behind this check. No signed-off-bys

Re: [PATCH] supplicant.c: Fixed Potential Crash issue

2015-10-08 Thread Patrik Flykt
Hi, On Mon, 2015-10-05 at 14:31 +0530, Maneesh Jain wrote: > Signed-off-by: Maneesh Jain > --- > gsupplicant/supplicant.c | 6 ++ > 1 files changed, 6 insertions(+) > > diff --git a/gsupplicant/supplicant.c b/gsupplicant/supplicant.c > index

Re: [PATCH] gsupplicant:Fix possible memory leak in signal_peer_found function

2015-10-08 Thread Patrik Flykt
On Mon, 2015-10-05 at 15:35 +0530, Maneesh Jain wrote: > Signed-off-by: Maneesh Jain We don't do/need signed-off-bys in this project. Short description here of the cause of the fix like "If supplicant_dbus_property_get_all() returns and error, the callback function will

Re: [PATCH v3] IPv6 timeserver for NTP

2015-10-08 Thread Patrik Flykt
Hi, On Tue, 2015-10-06 at 23:50 -0700, Naveen Singh wrote: > From: Naveen Singh > > Current NTP code is written with an assumption that timeserver is > always an IPv4 address. If there is an IPv6 timeserver then the socket > operation would fail with error as

Re: [PATCH V2] add management of dsa interface

2015-10-08 Thread Patrik Flykt
On Tue, 2015-10-06 at 10:51 +0200, Laurent Vaudoit wrote: > --- Added a commit message in similar style as the VLAN patch. In the future please describe the changes in the commit message! Applied, Patrik ___ connman mailing list

Re: [PATCH] gsupplicant:Fix Potential crash issue in case dbus_malloc() fail

2015-10-08 Thread Patrik Flykt
On Mon, 2015-10-05 at 15:24 +0530, Maneesh Jain wrote: > Signed-off-by: Maneesh Jain Added a shor commit message and removed the signed off by. Applied! Patrik ___ connman mailing list connman@connman.net

Re: service state transition to failure

2015-10-08 Thread Patrik Flykt
Hi, On Wed, 2015-10-07 at 21:21 -0700, Naveen Singh wrote: > I have few questions about service state transition to failure: > > 1. Can service state transition to Failure w/o generating an error event? I > am seeing that WiFi connection is not going through even if the AP is found > in

[PATCH] gdhcp: Remove unnecessary operation on lease seconds

2015-10-08 Thread Patrik Flykt
Lease seconds will not overflow, they are specified as a delta from now to a point in the future. Therefore no truncation of the received value is necessary. --- gdhcp/client.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/gdhcp/client.c b/gdhcp/client.c index

Re: clamping issue in dhcp lease

2015-10-08 Thread Patrik Flykt
On Wed, 2015-10-07 at 00:33 -0700, Naveen Singh wrote: > lease_seconds &= 0x0fff; This seems to be a bug and at the same time very old code. I'll try to find time to fix this. Patrik ___ connman mailing list connman@connman.net

Re: Fail to call SetProperty

2015-10-05 Thread Patrik Flykt
Hi, On Mon, 2015-10-05 at 14:50 +, Francesco Bruno wrote: > I'm trying to clear properties using the net.connman.Service > For instance in order to clear out the AutoConnected flag, I've > written the following code: > g_dbus_proxy_call_sync( myProxy, "ClearProperty", >

Re: [PATCH] IPv6 Timeserver for NTP

2015-10-05 Thread Patrik Flykt
On Mon, 2015-10-05 at 10:49 +0300, Jukka Rissanen wrote: > > Exactly this is what I am saying.My concern is for the type of > > timeserver_addr which is used for storing the IP address of the > > server. It cannot be sockaddr. It needs to be sockaddr_storage. > Where > > we know what IP address we

Re: Glib main loop stops dispatching

2015-10-02 Thread Patrik Flykt
On Thu, 2015-10-01 at 20:13 -0700, Naveen Singh wrote: > It does look like somehow glib main loop is not dispatching to correct > handlers and then it stops dispatching causing connman to hang. > > Has anyone seen any problem like this. I could provide complete logs > for this. Just before this

Re: [PATCH] add management of dsa interface

2015-10-01 Thread Patrik Flykt
Hi, git am complains of trailing white space errors on lines 47 and 56. While looking at the patch, all lines end with ^M, please fix. On Mon, 2015-09-28 at 14:48 +0200, Laurent Vaudoit wrote: > --- > plugins/ethernet.c | 60 > +++--- >

Re: [PATCH] IPv6 Timeserver for NTP

2015-10-01 Thread Patrik Flykt
Hi, On Wed, 2015-09-30 at 22:08 -0700, Naveen Singh wrote: > From: Naveen Singh > > Current NTP code is written with an assumption that timeserver is > always an IPv4 address. If there is an IPv6 timeserver then the socket > operation would fail with error as

Re: [help] Implementation of 2 internet contexts

2015-10-01 Thread Patrik Flykt
Hi, On Wed, 2015-09-30 at 17:13 +0200, Mylene Josserand wrote: > Hi everyone, > > > > On 05/13/2015 01:10 PM, Tomasz Bursztyka wrote: > >> Hi Mylene, > >> > >>> I understand and see (in outline) how adapt the code. > >>> Thank you for the tips, it will help me a lot if the Frederik

Re: How to set preferred services

2015-09-30 Thread Patrik Flykt
Hi, On Wed, 2015-09-30 at 07:59 +, Francesco Bruno wrote: > this is my first drop in this mailing list so please forgive me if I'm > going to ask something already answered. > I've seen that Connman allows to set the list of preferred > technologies and it works as espected.Now I'm

Re: [PATCH] IPv6 Timeserver for NTP

2015-09-25 Thread Patrik Flykt
On Thu, 2015-09-24 at 15:38 -0700, Naveen Singh wrote: > Isn't the IPv4 or IPv6 address passed as an argument to > __connman_ntp_start a character array? We would still need to convert > this character array to the IP addresses and for that we would need to > know the family. Do you think there is

Re: [PATCH] IPv6 Timeserver for NTP

2015-09-24 Thread Patrik Flykt
On Thu, 2015-09-24 at 11:14 +0300, Patrik Flykt wrote: > > + > > + if (ret) { > > + connman_error("cannot get the server info"); > > + return -1; > > + } > > + > > + family = info->ai_family; > > +

Re: [PATCH] IPv6 Timeserver for NTP

2015-09-24 Thread Patrik Flykt
Hi, On Wed, 2015-09-23 at 21:22 -0700, Naveen Singh wrote: > From: Naveen Singh > > Current NTP code is written with an assumption that timeserver is > always an IPv4 address. If there is an IPv6 timeserver then the socket > operation would fail with error as

Re: Can connman send local hostname on dhcp request?

2015-09-22 Thread Patrik Flykt
Hi, On Mon, 2015-09-21 at 21:34 +0200, Bert Haverkamp wrote: > I'm struggling to find an answer to this question. > I am running a raspberry with osmc, a distro that includes connman for > managing the connection. > I would like to have the hostname be sent in the dhcp request, so my

Re: DHCP & hostname faceplant

2015-09-22 Thread Patrik Flykt
Hi, On Fri, 2015-09-18 at 02:50 +, Daniel Wagner wrote: > The WiFi APs provided by the local ISP here in Utah does not like the > hostname in the DHCP Request packet. Without it the hostname I get the > ACK instead of the NACK as respond. Any ideas how we could handle this >

Re: Any known Connman Vulnerabilities ?

2015-09-21 Thread Patrik Flykt
Hi, On Mon, 2015-09-21 at 10:42 +, Lamsoge, Abhijit wrote: > Any currently known and fixed vulnerability in connman ? None reported/known since that very old version 0.85. > How does connman handle exploitation currently, if any ? If there are any exploits I hope we have a chance

Re: [PATCH] doc: Reformat connman.8

2015-09-18 Thread Patrik Flykt
On Thu, 2015-09-17 at 16:40 +0300, Jaakko Hannikainen wrote: > Reformat the man page so that it follows the convention of > common man pages (see: manual page of man); bold text > should be copied exactly as shown, italic text should be > replaced with the appropriate argument and arguments inside

[PATCH 2/3] connman.service: Fix dependencies for early boot

2015-09-17 Thread Patrik Flykt
Unset default dependencies in order to properly run at early boot but set a requirement for the save directory to be mounted. See the systemd.unit man page, Debian's wiki page https://wiki.debian.org/Teams/pkg-systemd/rcSMigration and the upstream systemd-networkd.service file for details. ---

[PATCH 3/3] connman.service: Prevent access to home and /run/user directories

2015-09-17 Thread Patrik Flykt
--- src/connman.service.in | 1 + 1 file changed, 1 insertion(+) diff --git a/src/connman.service.in b/src/connman.service.in index d96ea39..76ef968 100644 --- a/src/connman.service.in +++ b/src/connman.service.in @@ -13,6 +13,7 @@ BusName=net.connman Restart=on-failure

[PATCH 1/3] build: Add localstatedir to variable substitutions

2015-09-17 Thread Patrik Flykt
--- Makefile.am | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Makefile.am b/Makefile.am index 886cace..3d0645e 100644 --- a/Makefile.am +++ b/Makefile.am @@ -448,7 +448,8 @@ EXTRA_DIST += vpn/connman-task.te do_subst = $(AM_V_GEN)$(SED) \ -e

[PATCH 0/3] Systemd .service fixes

2015-09-17 Thread Patrik Flykt
Hi, Here are a few modifications to the ConnMan systemd .service file. In the future once resolv.conf file is written to /run, even more of the filesystem can be made read-only. Cheers, Patrik Patrik Flykt (3): build: Add localstatedir to variable substitutions

Re: [PATCH] service: clear credentials on manual connect failure

2015-09-17 Thread Patrik Flykt
Hi, On Tue, 2015-09-15 at 17:19 -0700, Adam Moore wrote: > Poor RF environments can cause connect-failed regardless > of password correctness. When performing a manual connection, > the correctness of the password has not been proved. Clear the > credentials in this case so they have an

Re: problem after suspend/resume using connman and switch

2015-09-15 Thread Patrik Flykt
On Tue, 2015-09-15 at 08:25 +0200, laurent vaudoit wrote: > After some analysis, it seems that ipv4ll is launch only on one > service if dhcp timeout. > So when we have more than one services, only the first one get an ip > from link local. The current implementation starts IPv4 link local after

Re: Wi-Fi access point use case - tether DNS and IP address

2015-09-15 Thread Patrik Flykt
Hi, On Tue, 2015-09-15 at 15:40 +1000, Craig McQueen wrote: > I'd like to use ConnMan in a device that connects to an Ethernet > network, and also (optionally) can operate Wi-Fi in access point mode > to provide technician type access to itself. > > So it looks like "tethering" is the

Re: [PATCH] resolver: allow writing to /etc/resolv.conf to be disabled

2015-09-15 Thread Patrik Flykt
Hi, On Tue, 2015-09-15 at 11:29 +, Sam Nazarko wrote: > >But also scripts/connman.in should be modified to create the > >needed symlink. > > Are you saying that you would like to create the symlink as part of > the packaging? I'm not sure this is necessarily a good idea, >

  1   2   3   4   5   6   7   8   9   10   >