___
connman mailing list
connman@connman.net
https://lists.connman.net/mailman/listinfo/connman
___
connman mailing list
connman@connman.net
https://lists.connman.net/mailman/listinfo/connman
Sometimes while switching network dhcp_initialize() fails because
interface is not up and hence dhcp->dhcp_client remains NULL. Here we
don't check return type of dhcp_initialize() and go on to call function
g_dhcp_client_start() and crash occurs.
Below trace is obtained when connman crashes:
connm
Hi,
I see only a .gif in your attachment, perhaps the actual patch is
missing? Also please send the patches as inline, you can for example use
"git send-email" to send them.
Cheers,
Jukka
___
connman mailing list
connman@connman.net
https://lists.con
Hi,
We still don't see your patch unfortunately.
Can you try with git send-email?
It's an opens-source mailing list here, so you don't need to send any
header specifying there is trade secret etc...
Thanks,
Tomasz
___
connman mailing list
connman@c
Hi,
Sometimes while switching network dhcp_initialize() fails because
interface is not up and hence dhcp->dhcp_client remains NULL. Here we
don't check return type of dhcp_initialize() and go on to call function
g_dhcp_client_start() and crash occurs.
Good catch, but this makes me think there
Hi
> Date: Wed, 30 Jul 2014 15:51:54 +0300
> From: tomasz.burszt...@linux.intel.com
> To: saurav.b...@samsung.com; connman@connman.net
> Subject: Re: [PATCH] dhcp: Fixed Crash on Switching Network
>
> Hi,
>
> > Sometimes while switching network dhcp_initialize() fai
Hi,
Thanks, patch looks ok to me. But that does not fix the root cause yet
since basically,
connman should never start dhcp client if the device is not up.
Though I think your patch should come in anyway, it's indeed necessary
to know if the
initialization went fine before proceeding further.
On Wed, 2014-08-06 at 14:29 +0530, Saurav Babu wrote:
> Sometimes while switching network dhcp_initialize() fails because
> interface is not up and hence dhcp->dhcp_client remains NULL. Here we
> don't check return type of dhcp_initialize() and go on to call function
> g_dhcp_client_start() and cra
___
connman mailing list
connman@connman.net
https://lists.connman.net/mailman/listinfo/connman
0001-dhcp-Fixed-Crash-on-Switching-Network.patch
Description: Binary data
___
connman mailing list
connman@connman.net
https://lists.connman.net/mailman/listinfo/connman
___
connman mailing list
connman@connman.net
https://lists.connman.net/mailman/listinfo/connman
___
connman mailing list
connman@connman.net
https://lists.connman.net/mailman/listinfo/connman
0001-dhcp-Fixed-Crash-on-Switching-Network.patch
Description: Binary data
___
connman mailing list
connman@connman.net
https://lists.connman.net/mailman/listinfo/connman
Hi,
Please do not send patches as attachments as the formatting gets mangled
when I reply to your patch.
On Mon, 2014-08-04 at 11:16 +, Saurav Babu wrote:
> diff --git a/src/dhcp.c b/src/dhcp.c index 132b787..a3dd3c4 100644 ---
> a/src/dhcp.c +++ b/src/dhcp.c @@ -587,6 +587,7 @@ int
On Mon, 2014-08-04 at 11:16 +, Saurav Babu wrote:
> Sometimes while switching network dhcp_initialize() fails because
> interface is not up and hence dhcp->dhcp_client remains NULL. Here we
> don't check return type of dhcp_initialize() and go on to call
> function g_dhcp_client_start() and cra
16 matches
Mail list logo
