Re: [PATCH] network: Call indicate error function in error case

2011-11-20 Thread Daniel Wagner
Hi Jukka, On 11/15/2011 12:13 PM, Jukka Rissanen wrote: >>> At some point we might also need to fix the service.c:combine_state(). >>> Something like this might do the trick (not tested at all): >>> >>> diff --git a/src/service.c b/src/service.c >>> index 30bf2fb..9b7208b 100644 >>> --- a/src/serv

Re: [PATCH] network: Call indicate error function in error case

2011-11-15 Thread Jukka Rissanen
Hi Daniel, On 11/15/2011 12:49 PM, Daniel Wagner wrote: Hi Jukka, On 15.11.2011 11:27, Jukka Rissanen wrote: At some point we might also need to fix the service.c:combine_state(). Something like this might do the trick (not tested at all): diff --git a/src/service.c b/src/service.c index 30bf

Re: [PATCH] network: Call indicate error function in error case

2011-11-15 Thread Daniel Wagner
Hi Jukka, On 15.11.2011 11:27, Jukka Rissanen wrote: > At some point we might also need to fix the service.c:combine_state(). > Something like this might do the trick (not tested at all): > > diff --git a/src/service.c b/src/service.c > index 30bf2fb..9b7208b 100644 > --- a/src/service.c > +++ b/

Re: [PATCH] network: Call indicate error function in error case

2011-11-15 Thread Jukka Rissanen
Hi Daniel, the patch looks good to me so ACK. On 11/15/2011 11:34 AM, Daniel Wagner wrote: From: Daniel Wagner Setting only one ipconfig type e.g. IPv4 is not enough. service.c:combine_state() will stay in associating state: src/service.c:service_indicate_state() service 0x6b1a60 old associat

[PATCH] network: Call indicate error function in error case

2011-11-15 Thread Daniel Wagner
From: Daniel Wagner Setting only one ipconfig type e.g. IPv4 is not enough. service.c:combine_state() will stay in associating state: src/service.c:service_indicate_state() service 0x6b1a60 old association - new failure/association => association After the patch it loosk like this: src/servic