Re: [PATCH 6/6] service: Implement ClearProperty properly

2015-10-20 Thread Marcel Holtmann
Hi Patrik, > Thanks for these patches. I'm going to add text from the cover letter to > this patch and nitpick on clearing AutoConnect below. > > On Thu, 2015-10-15 at 10:41 +0300, Jaakko Hannikainen wrote: >> The previous implementation only cleared Error, which as per >> documentation is wrong

Re: [PATCH 6/6] service: Implement ClearProperty properly

2015-10-19 Thread Patrik Flykt
Hi, Thanks for these patches. I'm going to add text from the cover letter to this patch and nitpick on clearing AutoConnect below. On Thu, 2015-10-15 at 10:41 +0300, Jaakko Hannikainen wrote: > The previous implementation only cleared Error, which as per > documentation is wrong since

[PATCH 6/6] service: Implement ClearProperty properly

2015-10-15 Thread Jaakko Hannikainen
The previous implementation only cleared Error, which as per documentation is wrong since Error is readonly. Add sane defaults to all readwrite fields. Reported by Francesco Bruno. --- src/service.c | 31 ++- 1 file changed, 26 insertions(+), 5 deletions(-) diff