Re: [PATCH service move 4/6] service: Prefer online state over ready when comparing services.

2011-08-22 Thread Patrik Flykt
On Thu, 2011-08-18 at 11:21 +0300, Jukka Rissanen wrote: + gboolean a_connected = is_connected(service_a), + b_connected = is_connected(service_b); I don't know what the coding style says, but I'd prefer 'gboolean b_connected' instead of the comma. Cheers,

[PATCH service move 4/6] service: Prefer online state over ready when comparing services.

2011-08-18 Thread Jukka Rissanen
--- src/service.c | 16 ++-- 1 files changed, 14 insertions(+), 2 deletions(-) diff --git a/src/service.c b/src/service.c index e92412e..1382705 100644 --- a/src/service.c +++ b/src/service.c @@ -3297,9 +3297,21 @@ static gint service_compare(gconstpointer a, gconstpointer b,